commit d64fe0f53c8f77a32cb7745a0a1c4309f9d0ba8d
author Niklas Brunlid <niklas.brunlid@sonymobile.com> Fri Jul 05 08:54:03 2013 +0200
committer Johan Redestig <johan.redestig@sonymobile.com> Wed Dec 18 12:51:26 2013 +0100
tree e033394453714c31652afcfb798b805711cb3765
parent 44291d9c2722e0d22dc6f909585f4302abdce205

MountService listeners can not be unregistered

When unregistering MountService listeners, their Binder proxy
objects were compared to registered listeners instead of their
backing objects.

Change-Id: Ie98a686b1d17544f1eda59fb3eb0dc02d836c1b2

services/java/com/android/server/MountService.java

diff --git a/services/java/com/android/server/MountService.java b/services/java/com/android/server/MountService.java
index e60231a..0d535cc 100644
--- a/services/java/com/android/server/MountService.java
+++ b/services/java/com/android/server/MountService.java
@@ -1411,7 +1411,7 @@
     public void unregisterListener(IMountServiceListener listener) {
         synchronized (mListeners) {
             for(MountServiceBinderListener bl : mListeners) {
-                if (bl.mListener == listener) {
+                if (bl.mListener.asBinder() == listener.asBinder()) {
                     mListeners.remove(mListeners.indexOf(bl));
                     listener.asBinder().unlinkToDeath(bl, 0);
                     return;