commit fcb310f93680b87943c90a321e2beedcb8c528b8
author Joe Onorato <joeo@google.com> Tue Nov 08 17:35:09 2011 -0800
committer Mike Lockwood <lockwood@google.com> Fri Feb 10 14:44:04 2012 -0800
tree 198517d088664eb173b2677166ce8439d38638bf
parent f5f4ec97916a22859abae69c7e8f522d36271eb6

For events, require that the parameters be marked in.

(because they won't work otherwise)

tools/aidl/aidl.cpp

diff --git a/tools/aidl/aidl.cpp b/tools/aidl/aidl.cpp
index e5689b9..8dbbf50 100644
--- a/tools/aidl/aidl.cpp
+++ b/tools/aidl/aidl.cpp
@@ -475,6 +475,15 @@
             err = 1;
         }
 
+        if (returnType == EVENT_FAKE_TYPE
+                && convert_direction(arg->direction.data) != IN_PARAMETER) {
+            fprintf(stderr, "%s:%d parameter %d: '%s %s' All paremeters on events must be 'in'.\n",
+                    filename, m->type.type.lineno, index,
+                    arg->type.type.data, arg->name.data);
+            err = 1;
+            goto next;
+        }
+
         if (arg->direction.data == NULL
                 && (arg->type.dimension != 0 || t->CanBeOutParameter())) {
             fprintf(stderr, "%s:%d parameter %d: '%s %s' can be an out"