Gitiles
Code Review Sign In
gerrit-public.fairphone.software / fp2-dev / platform / frameworks / compile / slang / 3f175af8a0644fb5fc53aa90e01c24f75855c5f7
commit3f175af8a0644fb5fc53aa90e01c24f75855c5f7[log] [tgz]
authorStephen Hines <srhines@google.com>Fri Sep 16 16:26:29 2011 -0700
committerStephen Hines <srhines@google.com>Fri Sep 16 16:31:03 2011 -0700
treec70b9d69f8e17c14daaa84f487a3901a898a585b
parent154e54e438e464a814ac33d10cb43686a068ed5d [diff]
Fix .rs.dtor scoping bug.

BUG=5267595

This change makes sure to scope any helper variables (like rsIntIter) to the
enclosing function (and not make them global). Prior to this change, if an
array iterator was created, it would be marked as a global symbol. The
libbcc library then sometimes removed this global as it was not able to
determine that it was actually used (.rs.dtor is not guaranteed to be called).
A fix should be made to libbcc as well, but the proper fix for llvm-rs-cc is
to scope any helper variable declarations to the calling function.

Change-Id: Ia46654cb0a114f6f5495e32ad1508d7d01e2084b
2 files changed
tree: c70b9d69f8e17c14daaa84f487a3901a898a585b
  1. BitWriter_2_9/
  2. tests/
  3. Android.mk
  4. llvm-rs-cc.cpp
  5. llvm-rs-link.cpp
  6. MODULE_LICENSE_APACHE2
  7. NOTICE
  8. os_sep.h
  9. README.html
  10. README.rst
  11. RSCCOptions.td
  12. rslib.bc
  13. rslib.ll
  14. rsScriptC_Lib.bc
  15. rsScriptC_Lib.rs
  16. RSSpec.mk
  17. slang-data.c
  18. slang.cpp
  19. slang.h
  20. slang_assert.h
  21. slang_backend.cpp
  22. slang_backend.h
  23. slang_diagnostic_buffer.cpp
  24. slang_diagnostic_buffer.h
  25. slang_pragma_recorder.cpp
  26. slang_pragma_recorder.h
  27. slang_rs.cpp
  28. slang_rs.h
  29. slang_rs_ast_replace.cpp
  30. slang_rs_ast_replace.h
  31. slang_rs_backend.cpp
  32. slang_rs_backend.h
  33. slang_rs_context.cpp
  34. slang_rs_context.h
  35. slang_rs_export_element.cpp
  36. slang_rs_export_element.h
  37. slang_rs_export_foreach.cpp
  38. slang_rs_export_foreach.h
  39. slang_rs_export_func.cpp
  40. slang_rs_export_func.h
  41. slang_rs_export_type.cpp
  42. slang_rs_export_type.h
  43. slang_rs_export_var.cpp
  44. slang_rs_export_var.h
  45. slang_rs_exportable.cpp
  46. slang_rs_exportable.h
  47. slang_rs_metadata.h
  48. slang_rs_metadata_spec.h
  49. slang_rs_metadata_spec_encoder.cpp
  50. slang_rs_object_ref_count.cpp
  51. slang_rs_object_ref_count.h
  52. slang_rs_pragma_handler.cpp
  53. slang_rs_pragma_handler.h
  54. slang_rs_reflect_utils.cpp
  55. slang_rs_reflect_utils.h
  56. slang_rs_reflection.cpp
  57. slang_rs_reflection.h
  58. slang_rs_spec_table.cpp
  59. slang_rs_type_spec.h
  60. slang_utils.cpp
  61. slang_utils.h
  62. slang_version.h
  63. SlangData.mk
  64. slangdata.py