tree 3d25321526cabf489ac8890a66edd0120a1abece
parent b970ae64505741ecb46cfce5d2dc8a9b87b1447c
author Paul Stewart <pstew@google.com> 1464741063 -0700
committer Dirk Vogt <dirk@fairphone.com> 1469632135 +0200

FPII-2181: Deal correctly with short strings

Deal correctly with short strings

The parseMacAddress function anticipates only properly formed
MAC addresses (6 hexadecimal octets separated by ":").  This
change properly deals with situations where the string is
shorter than expected, making sure that the passed in char*
reference in parseHexByte never exceeds the end of the string.

BUG: 28164077
TEST: Added a main function:

int main(int argc, char **argv) {
   unsigned char addr[6];
   if (argc > 1) {
      memset(addr, 0, sizeof(addr));
      parseMacAddress(argv[1], addr);
      printf("Result: %02x:%02x:%02x:%02x:%02x:%02x\n",
              addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
   }
}

Tested with "", "a" "ab" "ab:c" "abxc".

Change-Id: I0db8d0037e48b62333d475296a45b22ab0efe386
(cherry picked from commit 1921acbf2c82dd0813b3734f2609fe6f971c9c2f)