commit 053d38cf3db8e79ccde6996b2c44e77ccff54bfc
author Sungjoong Kang <sj3.kang@samsung.com> Mon Sep 17 17:46:52 2012 -0700
committer Rebecca Schultz Zavin <rebecca@android.com> Tue Sep 18 13:25:59 2012 -0700
tree 394d8d41193521ef2082f4230d65085e85f7e091
parent 9a77d67ea0c708e0f66241b902a3a505cd61e75d

hardware: samsung_slsi: libcamera2: Modify thread creators

This patch resolves the crash with pure virtual functions
on changing modes.
Thread creators are modified not to call run function.

Change-Id: Ib4864aaf46852583d742a8f36001ef93b0504e07
Signed-off-by: Sungjoong Kang <sj3.kang@samsung.com>

libcamera2/ExynosCameraHWInterface2.h

diff --git a/libcamera2/ExynosCameraHWInterface2.h b/libcamera2/ExynosCameraHWInterface2.h
index f66516d..ca25297 100644
--- a/libcamera2/ExynosCameraHWInterface2.h
+++ b/libcamera2/ExynosCameraHWInterface2.h
@@ -467,16 +467,10 @@
     public:
         MainThread(ExynosCameraHWInterface2 *hw):
             SignalDrivenThread(),
-            mHardware(hw) {
-//            Start("MainThread", PRIORITY_DEFAULT, 0);
-        }
+            mHardware(hw) { }
         ~MainThread();
-        status_t readyToRunInternal()
-	{
-            return NO_ERROR;
-        }
         void threadFunctionInternal()
-	{
+	    {
             mHardware->m_mainThreadFunc(this);
             return;
         }
@@ -488,13 +482,9 @@
         ExynosCameraHWInterface2 *mHardware;
     public:
         SensorThread(ExynosCameraHWInterface2 *hw):
-            SignalDrivenThread("SensorThread", PRIORITY_DEFAULT, 0),
+            SignalDrivenThread(),
             mHardware(hw) { }
         ~SensorThread();
-        status_t readyToRunInternal() {
-            mHardware->m_sensorThreadInitialize(this);
-            return NO_ERROR;
-        }
         void threadFunctionInternal() {
             mHardware->m_sensorThreadFunc(this);
             return;
@@ -508,13 +498,10 @@
         ExynosCameraHWInterface2 *mHardware;
     public:
         StreamThread(ExynosCameraHWInterface2 *hw, uint8_t new_index):
-            SignalDrivenThread("StreamThread", PRIORITY_DEFAULT, 0),
+            SignalDrivenThread(),
             mHardware(hw),
             m_index(new_index) { }
         ~StreamThread();
-        status_t readyToRunInternal() {
-            return NO_ERROR;
-        }
         void threadFunctionInternal() {
             mHardware->m_streamThreadFunc(this);
             return;
@@ -551,7 +538,6 @@
 
     void                m_mainThreadFunc(SignalDrivenThread * self);
     void                m_sensorThreadFunc(SignalDrivenThread * self);
-    void                m_sensorThreadInitialize(SignalDrivenThread * self);
     void                m_streamThreadFunc(SignalDrivenThread * self);
     void                m_streamThreadInitialize(SignalDrivenThread * self);