commit da5a71d42af7add8e6ab5c56cf31e5dc89a80f6c
author Jesse Hall <jessehall@google.com> Tue Aug 21 12:12:55 2012 -0700
committer Jesse Hall <jessehall@google.com> Wed Aug 22 15:45:26 2012 -0700
tree 6389f0d9767bcda7fc02be91a76808ebfa0fe993
parent 0fbe1706499c5d1c48b3c97669be79c5e6213cef

Update for cleanups in hwc interface

Change-Id: I8f43423df620bdeb1f7dd0a61d0222bf0c54f204

libhwc/hwc.cpp

diff --git a/libhwc/hwc.cpp b/libhwc/hwc.cpp
index d5b5851..2aa79f9 100644
--- a/libhwc/hwc.cpp
+++ b/libhwc/hwc.cpp
@@ -102,7 +102,7 @@
 
     const private_module_t  *gralloc_module;
     alloc_device_t          *alloc_device;
-    hwc_procs_t             *procs;
+    const hwc_procs_t       *procs;
     pthread_t               vsync_thread;
 
     int  hdmi_fd;
@@ -1041,7 +1041,7 @@
 {
     struct exynos5_hwc_composer_device_1_t* pdev =
             (struct exynos5_hwc_composer_device_1_t*)dev;
-    pdev->procs = const_cast<hwc_procs_t *>(procs);
+    pdev->procs = procs;
 }
 
 static int exynos5_query(struct hwc_composer_device_1* dev, int what, int *value)
@@ -1113,13 +1113,16 @@
     if (pdev->hdmi_hpd)
         ALOGI("HDMI Resolution changed to %dx%d", pdev->hdmi_cfg.h, pdev->hdmi_cfg.w);
 
-    if (pdev->procs && pdev->procs->invalidate)
+    /* hwc_dev->procs is set right after the device is opened, but there is
+     * still a race condition where a hotplug event might occur after the open
+     * but before the procs are registered. */
+    if (pdev->procs)
         pdev->procs->invalidate(pdev->procs);
 }
 
 static void handle_vsync_event(struct exynos5_hwc_composer_device_1_t *pdev)
 {
-    if (!pdev->procs || !pdev->procs->vsync)
+    if (!pdev->procs)
         return;
 
     int err = lseek(pdev->vsync_fd, 0, SEEK_SET);
@@ -1208,11 +1211,6 @@
     return 0;
 }
 
-struct hwc_methods_1 exynos5_methods = {
-    eventControl: exynos5_eventControl,
-    blank: exynos5_blank,
-};
-
 static int exynos5_close(hw_device_t* device);
 
 static int exynos5_open(const struct hw_module_t *module, const char *name,
@@ -1278,9 +1276,10 @@
 
     dev->base.prepare = exynos5_prepare;
     dev->base.set = exynos5_set;
-    dev->base.registerProcs = exynos5_registerProcs;
+    dev->base.eventControl = exynos5_eventControl;
+    dev->base.blank = exynos5_blank;
     dev->base.query = exynos5_query;
-    dev->base.methods = &exynos5_methods;
+    dev->base.registerProcs = exynos5_registerProcs;
 
     dev->bufs.pdev = dev;