commit a8e77ab86849156ea91758d1c1128f57ac5b7d21
author Doris Liu <tianliu@google.com> Sat Apr 26 01:30:39 2014 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Sat Apr 26 01:30:39 2014 +0000
tree 3804e07840427a842ef1bdc750bffe2239123c26
parent e5ba601d4e3aa9419886e2ea4b3b2e5ba3d3e2e7
parent 4931664284b9473b705b2e278d5bf5d939d7887c

Merge "DO NOT MERGE - Shutter button left handed support" into gb-ub-photos-denali

src/com/android/camera/VideoModule.java

diff --git a/src/com/android/camera/VideoModule.java b/src/com/android/camera/VideoModule.java
index a95336f..23a9f5b 100644
--- a/src/com/android/camera/VideoModule.java
+++ b/src/com/android/camera/VideoModule.java
@@ -372,7 +372,13 @@
 
     @Override
     public void onSingleTapUp(View view, int x, int y) {
-        if (mMediaRecorderRecording || mPaused || mCameraDevice == null) {
+        if (mPaused || mCameraDevice == null) {
+            return;
+        }
+        if (mMediaRecorderRecording) {
+            if (!mSnapshotInProgress) {
+                takeASnapshot();
+            }
             return;
         }
         // Check if metering area or focus area is supported.
@@ -387,7 +393,7 @@
         // Only take snapshots if video snapshot is supported by device
         if (CameraUtil.isVideoSnapshotSupported(mParameters) && !mIsVideoCaptureIntent) {
             if (!mMediaRecorderRecording || mPaused || mSnapshotInProgress
-                    || mAppController.isShutterEnabled()) {
+                    || !mAppController.isShutterEnabled()) {
                 return;
             }
 
@@ -399,7 +405,7 @@
             CameraUtil.setGpsParameters(mParameters, loc);
             mCameraDevice.setParameters(mParameters);
 
-            Log.v(TAG, "Video snapshot start");
+            Log.i(TAG, "Video snapshot start");
             mCameraDevice.takePicture(mHandler,
                     null, null, null, new JpegPictureCallback(loc));
             showVideoSnapshotUI(true);
@@ -1764,7 +1770,7 @@
 
         @Override
         public void onPictureTaken(byte [] jpegData, CameraProxy camera) {
-            Log.v(TAG, "onPictureTaken");
+            Log.i(TAG, "Video snapshot taken.");
             mSnapshotInProgress = false;
             showVideoSnapshotUI(false);
             storeImage(jpegData, mLocation);

src/com/android/camera/app/AndroidCameraManagerImpl.java

diff --git a/src/com/android/camera/app/AndroidCameraManagerImpl.java b/src/com/android/camera/app/AndroidCameraManagerImpl.java
index 2385bc1..3c72cfb 100644
--- a/src/com/android/camera/app/AndroidCameraManagerImpl.java
+++ b/src/com/android/camera/app/AndroidCameraManagerImpl.java
@@ -963,7 +963,7 @@
             mDispatchThread.runJob(new Runnable() {
                 @Override
                 public void run() {
-                    mCameraState.waitForStates(CAMERA_IDLE);
+                    mCameraState.waitForStates(CAMERA_IDLE | CAMERA_UNLOCKED);
                     mCameraHandler.requestTakePicture(ShutterCallbackForward
                             .getNewInstance(handler, AndroidCameraProxyImpl.this, shutter),
                             PictureCallbackForward