commit 2a85883088558f87a0eb4a88bd5531401396f5b4
author Brian Carlstrom <bdc@google.com> Thu May 26 09:30:26 2011 -0700
committer Brian Carlstrom <bdc@google.com> Thu May 26 09:30:26 2011 -0700
tree b2c69a962bbbc9b1b7be5a33e0f1306685055c65
parent bb04f703be50794c41e453e82c70e354a545ea54

Defend KeyChainActivity again callback exceptions.

Also remove some unnecessary throws in the KeyChainService

Change-Id: I1779229957a2e700effca33e15cea2e71e73b281

src/com/android/keychain/KeyChainActivity.java

diff --git a/src/com/android/keychain/KeyChainActivity.java b/src/com/android/keychain/KeyChainActivity.java
index 552a73a..aa60e41 100644
--- a/src/com/android/keychain/KeyChainActivity.java
+++ b/src/com/android/keychain/KeyChainActivity.java
@@ -143,7 +143,10 @@
         if (keyChainAliasResponse != null) {
             try {
                 keyChainAliasResponse.alias(alias);
-            } catch (RemoteException ignored) {
+            } catch (Exception ignored) {
+                // don't just catch RemoteException, caller could
+                // throw back a RuntimeException across processes
+                // which we should protect against.
             }
         }
         finish();