Remove previous code for moving FAB into TL
Use ray's approach of moving the view into TL so we won't
have to keep these states for animating the FAB.
b/17514925
Change-Id: Ib1c6328158a12defba9fc0c13640e1814481f89f
diff --git a/res/layout-sw600dp/floating_actions.xml b/res/layout-sw600dp/floating_actions.xml
index 28bc3cf..0a6cb45 100644
--- a/res/layout-sw600dp/floating_actions.xml
+++ b/res/layout-sw600dp/floating_actions.xml
@@ -16,11 +16,9 @@
limitations under the License.
-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
- android:id="@+id/floating_actions"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_gravity="bottom"
- android:visibility="invisible">
+ android:layout_gravity="bottom">
<com.android.mail.ui.ActionableToastBar
android:id="@+id/toast_bar"
diff --git a/src/com/android/mail/ui/AbstractActivityController.java b/src/com/android/mail/ui/AbstractActivityController.java
index c5425e4..a087369 100644
--- a/src/com/android/mail/ui/AbstractActivityController.java
+++ b/src/com/android/mail/ui/AbstractActivityController.java
@@ -1162,7 +1162,8 @@
@Override
public void onConversationListVisibilityChanged(boolean visible) {
- mFloatingComposeButton.setVisibility(visible ? View.VISIBLE : View.GONE);
+ mFloatingComposeButton.setVisibility(
+ !ViewMode.isSearchMode(mViewMode.getMode()) && visible ? View.VISIBLE : View.GONE);
informCursorVisiblity(visible);
commitAutoAdvanceOperation();
diff --git a/src/com/android/mail/ui/TwoPaneLayout.java b/src/com/android/mail/ui/TwoPaneLayout.java
index 6cf560c..a5fa76d 100644
--- a/src/com/android/mail/ui/TwoPaneLayout.java
+++ b/src/com/android/mail/ui/TwoPaneLayout.java
@@ -102,10 +102,6 @@
private View mConversationView;
private View mFoldersView;
private View mListView;
- private View mFloatingActions;
- private View mFloatingActionButton;
-
- private int mFloatingActionButtonEndMargin;
private final List<Runnable> mTransitionCompleteJobs = Lists.newArrayList();
@@ -136,8 +132,6 @@
// don't show the conversation list, but in landscape we do. This information is stored
// in the constants
mListCollapsible = !res.getBoolean(R.bool.is_tablet_landscape);
- mFloatingActionButtonEndMargin =
- res.getDimensionPixelOffset(R.dimen.floating_action_bar_margin);
mDrawerWidthMini = res.getDimensionPixelSize(R.dimen.two_pane_drawer_width_mini);
mDrawerWidthOpen = res.getDimensionPixelSize(R.dimen.two_pane_drawer_width_open);
@@ -159,8 +153,6 @@
mListView = findViewById(R.id.conversation_list_pane);
mConversationView = findViewById(R.id.conversation_pane);
mMiscellaneousView = findViewById(MISCELLANEOUS_VIEW_ID);
- mFloatingActions = findViewById(R.id.floating_actions);
- mFloatingActionButton = findViewById(R.id.compose_button);
// all panes start GONE in initial UNKNOWN mode to avoid drawing misplaced panes
mCurrentMode = ViewMode.UNKNOWN;
@@ -270,13 +262,7 @@
}
}
- // manually set FAB position the first time so it doesn't animate to its initial position
- if (mFloatingActions.getVisibility() != VISIBLE && mCurrentMode != ViewMode.UNKNOWN) {
- mFloatingActionButton.setX(computeFloatingActionButtonX(isRtl ? listX : convX, isRtl));
- mFloatingActions.setVisibility(VISIBLE);
- }
-
- animatePanes(foldersX, listX, convX, isRtl);
+ animatePanes(foldersX, listX, convX);
// For views that are not on the screen, let's set their visibility for accessibility.
final boolean folderVisible = isRtl ?
@@ -297,7 +283,7 @@
mPositionedIsDrawerOpen = isDrawerOpen;
}
- private void animatePanes(int foldersX, int listX, int convX, boolean isRtl) {
+ private void animatePanes(int foldersX, int listX, int convX) {
// If positioning has not yet happened, we don't need to animate panes into place.
// This happens on first layout, rotate, and when jumping straight to a conversation from
// a view intent.
@@ -321,16 +307,8 @@
mFoldersView.animate().x(foldersX);
mListView.animate().x(listX).setListener(mPaneAnimationListener);
- mFloatingActionButton.animate()
- .x(computeFloatingActionButtonX(isRtl ? listX : convX, isRtl));
- configureAnimations(mConversationView, mFoldersView, mListView, mMiscellaneousView,
- mFloatingActionButton);
- }
-
- private int computeFloatingActionButtonX(int edgeX, boolean isRtl) {
- return isRtl ? edgeX + mFloatingActionButtonEndMargin :
- edgeX - mFloatingActionButton.getWidth() - mFloatingActionButtonEndMargin;
+ configureAnimations(mConversationView, mFoldersView, mListView, mMiscellaneousView);
}
private void configureAnimations(View... views) {