commit 2cb29985655784b0775519e581bc3f29e95c45ea
author Sharvil Nanavati <sharvil@google.com> Fri Aug 01 17:00:12 2014 -0700
committer Andre Eisenbach <eisenbach@google.com> Mon Mar 16 16:51:28 2015 -0700
tree 33f0e2e6cafefb922cb143e49644b20292bd28b9
parent 36c1c09593a58717c78497cd55c4ed1dcf52183e

Define INVALID_FD to improve readability and reduce likelihood of errors

osi/src/semaphore.c

diff --git a/osi/src/semaphore.c b/osi/src/semaphore.c
index c1d038a..480dc8e 100644
--- a/osi/src/semaphore.c
+++ b/osi/src/semaphore.c
@@ -39,7 +39,7 @@
   semaphore_t *ret = malloc(sizeof(semaphore_t));
   if (ret) {
     ret->fd = eventfd(value, EFD_SEMAPHORE);
-    if (ret->fd == -1) {
+    if (ret->fd == INVALID_FD) {
       ALOGE("%s unable to allocate semaphore: %s", __func__, strerror(errno));
       free(ret);
       ret = NULL;
@@ -49,14 +49,14 @@
 }
 
 void semaphore_free(semaphore_t *semaphore) {
-  if (semaphore->fd != -1)
+  if (semaphore->fd != INVALID_FD)
     close(semaphore->fd);
   free(semaphore);
 }
 
 void semaphore_wait(semaphore_t *semaphore) {
   assert(semaphore != NULL);
-  assert(semaphore->fd != -1);
+  assert(semaphore->fd != INVALID_FD);
 
   uint64_t value;
   if (eventfd_read(semaphore->fd, &value) == -1)
@@ -65,7 +65,7 @@
 
 bool semaphore_try_wait(semaphore_t *semaphore) {
   assert(semaphore != NULL);
-  assert(semaphore->fd != -1);
+  assert(semaphore->fd != INVALID_FD);
 
   int flags = fcntl(semaphore->fd, F_GETFL);
   if (flags == -1) {
@@ -88,7 +88,7 @@
 
 void semaphore_post(semaphore_t *semaphore) {
   assert(semaphore != NULL);
-  assert(semaphore->fd != -1);
+  assert(semaphore->fd != INVALID_FD);
 
   if (eventfd_write(semaphore->fd, 1ULL) == -1)
     ALOGE("%s unable to post to semaphore: %s", __func__, strerror(errno));
@@ -96,6 +96,6 @@
 
 int semaphore_get_fd(const semaphore_t *semaphore) {
   assert(semaphore != NULL);
-  assert(semaphore->fd != -1);
+  assert(semaphore->fd != INVALID_FD);
   return semaphore->fd;
 }