Gitiles
Code Review Sign In
gerrit-public.fairphone.software / fp2-dev / platform / system / netd / c2b26cb83d9bf3f91e986625efcc40fc8eb79a13
commitc2b26cb83d9bf3f91e986625efcc40fc8eb79a13[log] [tgz]
authorNick Kralevich <nnk@google.com>Thu Feb 23 13:04:26 2012 -0800
committerNick Kralevich <nnk@google.com>Thu Feb 23 14:50:29 2012 -0800
treeb7e558b58713fd3d81c961d248000ca7adf20091
parent0a379691e04700b3b44948450b1e3db92ef2ec01 [diff]
BandwidthController: fix format string bugs

In 876666947664c718a8d0cae9bbddb06cc91f912c, a new %s
was added to ALERT_IPT_TEMPLATE. Not all users of this string
were updated.

This change modifies ALERT_IPT_TEMPLATE to be a #define, which
allows gcc's format string detection work.

Add -Werror=format to error out on any string format warning.

Testing: Code compiles. I don't know how to test this change
properly.

Bug: 5948299
Change-Id: I0ec307972e6bf50abd8ba099166c22069a6c6580
3 files changed
tree: b7e558b58713fd3d81c961d248000ca7adf20091
  1. Android.mk
  2. BandwidthController.cpp
  3. BandwidthController.h
  4. CleanSpec.mk
  5. CommandListener.cpp
  6. CommandListener.h
  7. DnsProxyListener.cpp
  8. DnsProxyListener.h
  9. logwrapper.c
  10. main.cpp
  11. NatController.cpp
  12. NatController.h
  13. ndc.c
  14. NetdCommand.cpp
  15. NetdCommand.h
  16. NetdConstants.cpp
  17. NetdConstants.h
  18. NetlinkHandler.cpp
  19. NetlinkHandler.h
  20. NetlinkManager.cpp
  21. NetlinkManager.h
  22. oem_iptables_hook.cpp
  23. oem_iptables_hook.h
  24. PanController.cpp
  25. PanController.h
  26. PppController.cpp
  27. PppController.h
  28. ResolverController.cpp
  29. ResolverController.h
  30. ResponseCode.h
  31. SecondaryTableController.cpp
  32. SecondaryTableController.h
  33. SoftapController.cpp
  34. SoftapController.h
  35. TetherController.cpp
  36. TetherController.h
  37. ThrottleController.cpp
  38. ThrottleController.h