commit f30a2981e883881ff529ccff70e57744eee4d84d
author Hanumantha Reddy Pothula <c_hpothu@qti.qualcomm.com> Fri May 15 15:02:30 2015 +0530
committer Satyanarayana Dash <c_sadash@qti.qualcomm.com> Mon May 18 16:50:25 2015 +0530
tree 8bdbd1ddc3c7c452e4cc15c90e7edc34ba356ea1
parent 9f6aa7ba9f8366350b8c67cf094fcd982c26417d

wlan: Initialize SAP lock appropriately.

When driver is in bad state (SSR re_init fail) then there is a
possibility of accessing uninitialized SAP lock (staInfo_lock)
during driver unload.
Hence initializing staInfo_lock in WLANSAP_Open(). So that valid
lock will be acquired during driver unload.

Change-Id: I7c90040305e566a0e0216558e1280fdc692bc8a3
CRs-Fixed: 837474

CORE/SAP/src/sapModule.c

diff --git a/CORE/SAP/src/sapModule.c b/CORE/SAP/src/sapModule.c
index 14c9e09..ceb8a63 100644
--- a/CORE/SAP/src/sapModule.c
+++ b/CORE/SAP/src/sapModule.c
@@ -165,6 +165,14 @@
 
     WLANSAP_CleanCB(pSapCtx, 0 /*do not empty*/);
 
+    if (!VOS_IS_STATUS_SUCCESS(vos_spin_lock_init(&pSapCtx->staInfo_lock)))
+    {
+        VOS_TRACE( VOS_MODULE_ID_SAP, VOS_TRACE_LEVEL_ERROR,
+                 "WLANSAP_Start failed init staInfo_lock");
+        vos_free_context(pvosGCtx, VOS_MODULE_ID_SAP, pSapCtx);
+        return VOS_STATUS_E_FAULT;
+    }
+
     // Setup the "link back" to the VOSS context
     pSapCtx->pvosGCtx = pvosGCtx;
 
@@ -257,13 +265,6 @@
         return VOS_STATUS_E_FAULT;
     }
 
-    if (!VOS_IS_STATUS_SUCCESS(vos_spin_lock_init(&pSapCtx->staInfo_lock)))
-    {
-        VOS_TRACE( VOS_MODULE_ID_SAP, VOS_TRACE_LEVEL_ERROR,
-                 "WLANSAP_Start failed init staInfo_lock\n");
-        return VOS_STATUS_E_FAULT;
-    }
-
     return VOS_STATUS_SUCCESS;
 }/* WLANSAP_Start */