commit d625055fccbaf9b0c9d90c608293a01113544720
author Greg Grisco <ggrisco@codeaurora.org> Wed Jun 29 14:40:23 2011 -0700
committer Linux Build Service Account <lnxbuild@localhost> Tue Jul 12 23:21:49 2011 -0600
tree a5e76662a603bdec593602b0967e646380454977
parent d8b7afc7da224a6db79b4a085ad5d1da008aa7f4

Clean up warnings in lk code

Change-Id: I05b3a6cf07cde7e60586b1816c2f1279f64f5cf4

dev/keys/gpio_keypad.c

diff --git a/dev/keys/gpio_keypad.c b/dev/keys/gpio_keypad.c
index 136d77b..0883c6a 100644
--- a/dev/keys/gpio_keypad.c
+++ b/dev/keys/gpio_keypad.c
@@ -42,6 +42,8 @@
 #include <kernel/timer.h>
 #include <reg.h>
 #include <platform/iomap.h>
+#include <platform/timer.h>
+#include <platform.h>
 
 #define LINUX_MACHTYPE_8660_QT      3298
 
@@ -593,24 +595,24 @@
     static int key_detected=-1;
 
     /* Row GPIOs 8,9,10 are used for sensing here */
-    for(gpio=8;gpio<=10;gpio++)
+    for (gpio=8;gpio<=10;gpio++)
     {
         bool status;
         status = pm8058_gpio_get(gpio);
-        if(status == 0)
+        if (status == 0)
             new_state |= (1<<(gpio-8));
     }
 
     bits_changed = last_state ^ new_state;
 
-    if(bits_changed)
+    if (bits_changed)
     {
-        int shift;
-        for(int rows=0;rows<(qwerty_keypad->keypad_info)->rows;rows++)
+        int shift = 0;
+        for (unsigned int rows = 0; rows < (qwerty_keypad->keypad_info)->rows; rows++)
         {
-            if((bits_changed & (1<<rows)) == 0)
+            if ((bits_changed & (1<<rows)) == 0)
                 continue;
-            shift = rows*8 + 3;
+            shift = rows * 8 + 3;
         }
         if ((qwerty_keypad->keypad_info)->keymap[shift])
         {
@@ -665,9 +667,9 @@
 void pmic_write(unsigned address, unsigned data)
 {
   write_func wr_function = &i2c_ssbi_write_bytes;
-  if(wr_function == NULL)
+  if (wr_function == NULL)
     return;
-  if ((*wr_function)(&data, 1, address))
+  if ((*wr_function)((unsigned char *) &data, 1, address))
     dprintf (CRITICAL, "Error in initializing register\n");
 
 }