platform: msm_shared: Assert if there is no signature or target name mismatch
Currently we continue if there is no signature and if there is a target
name mismatch. With this change assert if the above is invalid.
Change-Id: I76d7a18ed47118647986c70e863a95af4aafd6fb
diff --git a/platform/msm_shared/boot_verifier.c b/platform/msm_shared/boot_verifier.c
index 4a1749b..1e1491f 100644
--- a/platform/msm_shared/boot_verifier.c
+++ b/platform/msm_shared/boot_verifier.c
@@ -514,14 +514,14 @@
if(!sig_len)
{
dprintf(CRITICAL, "boot_verifier: Error while reading signature length.\n");
- goto verify_image_error;
+ ASSERT(0);
}
if((sig = d2i_VERIFIED_BOOT_SIG(NULL, (const unsigned char **) &sig_addr, sig_len)) == NULL)
{
dprintf(CRITICAL,
"boot_verifier: verification failure due to target name mismatch\n");
- goto verify_image_error;
+ ASSERT(0);
}
cert = sig->certificate;
@@ -532,7 +532,6 @@
ret = verify_image_with_sig(img_addr, img_size, pname, sig, user_keystore);
-verify_image_error:
if(sig != NULL)
VERIFIED_BOOT_SIG_free(sig);
return ret;