commit 1778ca298b06ec86af5fc9603447c379cbfb477b
author Bruno Prémont <bonbons@linux-vserver.org> Fri Aug 06 10:08:04 2010 +0200
committer Jiri Kosina <jkosina@suse.cz> Fri Aug 06 14:53:10 2010 +0200
tree dd6e0c5d6c02d052bd2ebfffc1d16bba7a2a8cd6
parent a106025015c8d24af6518aba3ac19c4dc9098b7c

HID: picolcd: correct ordering of framebuffer freeing

Fix the free() ordering (which was never reached due to wrong check).

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

drivers/hid/hid-picolcd.c

diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
index c0bdeba..bc2e077 100644
--- a/drivers/hid/hid-picolcd.c
+++ b/drivers/hid/hid-picolcd.c
@@ -550,8 +550,8 @@
 	may_release = !*ref_cnt;
 	mutex_unlock(&info->lock);
 	if (may_release) {
-		framebuffer_release(info);
 		vfree((u8 *)info->fix.smem_start);
+		framebuffer_release(info);
 	}
 }