drm/i915: add a default always-on power well
So far we distinguished platforms without a dynamic power well with
the HAS_POWER_WELL macro and for such platforms we didn't call any power
domain functions. Instead of doing this check we can add an always-on
power well for these platforms and call the power domain functions
unconditionally. For always-on power wells we only increase/decrease
their refcounts, otherwise they are nop.
This makes high level driver code more readable and as a bonus provides
some idea of the current power domains state for all platforms (once
the relevant debugfs entry is added).
v3: rename intel_power_wells to i9xx_always_on_power_well (Paulo)
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Paulo Zanoni <paulo.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 5331925..6b4f91e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5644,9 +5644,6 @@
bool is_enabled;
int i;
- if (!HAS_POWER_WELL(dev))
- return true;
-
power_domains = &dev_priv->power_domains;
is_enabled = true;
@@ -5754,9 +5751,6 @@
struct i915_power_well *power_well;
int i;
- if (!HAS_POWER_WELL(dev))
- return;
-
power_domains = &dev_priv->power_domains;
mutex_lock(&power_domains->lock);
@@ -5773,9 +5767,6 @@
struct i915_power_well *power_well;
int i;
- if (!HAS_POWER_WELL(dev))
- return;
-
power_domains = &dev_priv->power_domains;
mutex_lock(&power_domains->lock);
@@ -5814,6 +5805,14 @@
}
EXPORT_SYMBOL_GPL(i915_release_power_well);
+static struct i915_power_well i9xx_always_on_power_well[] = {
+ {
+ .name = "always-on",
+ .always_on = 1,
+ .domains = POWER_DOMAIN_MASK,
+ },
+};
+
static struct i915_power_well hsw_power_wells[] = {
{
.name = "always-on",
@@ -5852,9 +5851,6 @@
struct drm_i915_private *dev_priv = dev->dev_private;
struct i915_power_domains *power_domains = &dev_priv->power_domains;
- if (!HAS_POWER_WELL(dev))
- return 0;
-
mutex_init(&power_domains->lock);
/*
@@ -5868,7 +5864,7 @@
set_power_wells(power_domains, bdw_power_wells);
hsw_pwr = power_domains;
} else {
- WARN_ON(1);
+ set_power_wells(power_domains, i9xx_always_on_power_well);
}
return 0;
@@ -5886,9 +5882,6 @@
struct i915_power_well *power_well;
int i;
- if (!HAS_POWER_WELL(dev))
- return;
-
mutex_lock(&power_domains->lock);
for_each_power_well(i, power_well, POWER_DOMAIN_MASK, power_domains) {
if (power_well->set)
@@ -5907,9 +5900,6 @@
{
struct drm_i915_private *dev_priv = dev->dev_private;
- if (!HAS_POWER_WELL(dev))
- return;
-
/* For now, we need the power well to be always enabled. */
intel_display_set_init_power(dev, true);
intel_power_domains_resume(dev);