tree 333869fbe5a5e159f283caa5695f70454089a37d
parent 37d933e8b41b83bb8278815e366aec5a542b7e31
author Dan Carpenter <dan.carpenter@oracle.com> 1599047791 +0300
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> 1599671067 +0200

net: gemini: Fix another missing clk_disable_unprepare() in probe

[ Upstream commit eb0f3bc463d59d86402f19c59aa44e82dc3fab6d ]

We recently added some calls to clk_disable_unprepare() but we missed
the last error path if register_netdev() fails.

I made a couple cleanups so we avoid mistakes like this in the future.
First I reversed the "if (!ret)" condition and pulled the code in one
indent level.  Also, the "port->netdev = NULL;" is not required because
"port" isn't used again outside this function so I deleted that line.

Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>