commit 5d0c288b7362ad7ee235b59352ac2a89480e4757
author Alexey Starikovskiy <alexey.y.starikovskiy@intel.com> Thu Dec 07 18:42:16 2006 +0300
committer Len Brown <len.brown@intel.com> Fri Dec 08 02:56:06 2006 -0500
tree d84a59fa93d765b6dfbfb89fceba691ac1a5b7b2
parent e41334c0a6ef71458f255db25f011d15099e7cca

ACPI: ec: Query only single query at a time.

Signed-off-by: Len Brown <len.brown@intel.com>

drivers/acpi/ec.c

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index acfe883..a85f795 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -104,6 +104,7 @@
 	unsigned long data_addr;
 	unsigned long global_lock;
 	struct semaphore sem;
+	atomic_t query_pending;
 	atomic_t leaving_burst;	/* 0 : No, 1 : Yes, 2: abort */
 	wait_queue_head_t wait;
 } *ec_ecdt;
@@ -257,6 +258,8 @@
 			     command);
 			goto end;
 		}
+	} else if (command == ACPI_EC_COMMAND_QUERY) {
+		atomic_set(&ec->query_pending, 0);
 	}
 
 	for (; rdata_len > 0; rdata_len --) {
@@ -425,17 +428,9 @@
 {
 	struct acpi_ec *ec = (struct acpi_ec *)ec_cxt;
 	u8 value = 0;
-	static char object_name[8];
+	char object_name[8];
 
-	if (!ec)
-		return;
-
-	value = acpi_ec_read_status(ec);
-
-	if (!(value & ACPI_EC_FLAG_SCI))
-		return;
-
-	if (acpi_ec_query(ec, &value))
+	if (!ec || acpi_ec_query(ec, &value))
 		return;
 
 	snprintf(object_name, 8, "_Q%2.2X", value);
@@ -457,7 +452,8 @@
 	}
 
 	value = acpi_ec_read_status(ec);
-	if (value & ACPI_EC_FLAG_SCI) {
+	if ((value & ACPI_EC_FLAG_SCI) && !atomic_read(&ec->query_pending)) {
+		atomic_set(&ec->query_pending, 1);
 		status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
 	}
 
@@ -652,6 +648,7 @@
 	ec->handle = device->handle;
 	ec->uid = -1;
 	init_MUTEX(&ec->sem);
+	atomic_set(&ec->query_pending, 0);
 	if (acpi_ec_mode == EC_INTR) {
 		atomic_set(&ec->leaving_burst, 1);
 		init_waitqueue_head(&ec->wait);