commit 69ec98d7e5661a1c98ec51c26d6e91af3bbe0e72
author Dan Carpenter <dan.carpenter@oracle.com> Thu Oct 15 21:16:30 2015 +0300
committer Takashi Iwai <tiwai@suse.de> Sat Oct 17 12:04:16 2015 +0200
tree 95e5e388c1378cc8b36349abdd6cf2402ca7660e
parent 90bbaf66ee7b946952f1e82a0069639dea5fd893

ALSA: firewire-tascam: fix an LED bug

We recently tried to add some new code to support turning the LED on and
off but the code in snd_tscm_transaction_reregister() is unreachable.

Fixes: e65e2cb99e44 ('ALSA: firewire-tascam: Turn on/off FireWire LED')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/firewire/tascam/tascam-transaction.c

diff --git a/sound/firewire/tascam/tascam-transaction.c b/sound/firewire/tascam/tascam-transaction.c
index 1c9a88b..45c3ce3 100644
--- a/sound/firewire/tascam/tascam-transaction.c
+++ b/sound/firewire/tascam/tascam-transaction.c
@@ -249,7 +249,7 @@
 
 	/* Turn on messaging. */
 	reg = cpu_to_be32(0x00000001);
-	return snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
+	err = snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
 				  TSCM_ADDR_BASE + TSCM_OFFSET_MIDI_TX_ON,
 				  &reg, sizeof(reg), 0);
 	if (err < 0)