commit 7a9a7b774fd543467313894fe53bc7dcc47d5708
author Trond Myklebust <trond.myklebust@primarydata.com> Sun May 18 13:47:14 2014 -0400
committer Trond Myklebust <trond.myklebust@primarydata.com> Sun May 18 13:47:14 2014 -0400
tree 2b5441b6117ca18162fc44ec32f953be97297646
parent 1f2edbe3fe2111a59fcd1bb3b9725066bc9ed686

SUNRPC: Fix a module reference issue in rpcsec_gss

We're not taking a reference in the case where _gss_mech_get_by_pseudoflavor
loops without finding the correct rpcsec_gss flavour, so why are we
releasing it?

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

net/sunrpc/auth_gss/gss_mech_switch.c

diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c
index 27ce262..92d5ab9 100644
--- a/net/sunrpc/auth_gss/gss_mech_switch.c
+++ b/net/sunrpc/auth_gss/gss_mech_switch.c
@@ -218,10 +218,8 @@
 
 	spin_lock(&registered_mechs_lock);
 	list_for_each_entry(pos, &registered_mechs, gm_list) {
-		if (!mech_supports_pseudoflavor(pos, pseudoflavor)) {
-			module_put(pos->gm_owner);
+		if (!mech_supports_pseudoflavor(pos, pseudoflavor))
 			continue;
-		}
 		if (try_module_get(pos->gm_owner))
 			gm = pos;
 		break;