tree 1991a72f789ee66251dcb65ac16ff1adf62a1bd4
parent 0b5eca67bd2d0e6f6d0ccdc316aced0cc4bf2e9f
author Tony Lindgren <tony@atomide.com> 1516901705 -0800
committer Mark Brown <broonie@kernel.org> 1516904426 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQFHBAABCgAxFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlpqH+oTHGJyb29uaWVA
 a2VybmVsLm9yZwAKCRAk1otyXVSH0CodB/9vSP0R5yV3LvTpPBaIOmZSdj0q+JeX
 IsQFcUlJx4OH1xsx6FV6NxGNFH110oooqSGIuOKmWXT9kt7583yq9se8SCkg32oT
 btKldRKe9Jvul16DpD6ylAvHDrnUkaNVj9TyQaeQ7/6G++zO9ZjS0x3gd7RDsdcA
 wRmE4GYh8TQQcaQ/+XpItvWUL1TWMmGNIjYWXvsCqgslEwdFXW11yZmWJRn767l8
 9VOBxa0gHvsS6/vBLWA2gDR7smdExHIollsKKthwU0ojiYIVY0fFLif0mJrN2sNd
 +I8+ebd9Y9DM7ZP5Ro5Q1wGaPBi/rqYbS/UjcjniscR32rRYsbsJH357
 =OUJu
 -----END PGP SIGNATURE-----

ASoC: Fix twl4030 and 6040 regression by adding back read and write

Commit 3bb0f7c31b1a ("ASoC: don't use snd_soc_write/read on twl4030")
caused regressions for both twl4030 and twl6040 as it assumes the
ASoC driver is using regmap. As a side effect, this also causes a
considerable increase in idle power consumption omap3 boards using
twl4030 as the PMIC.

This is because the removal of read and write function pointers
causes some of the ASoC IO functions to not do anything. For example,
snd_soc_register_card() calls snd_soc_dapm_new_widgets() that calls
snd_soc_codec_drv_read() that now does nothing.

A long term solution suggested by Mark Brown <broonie@kernel.org>
is to make the twl drivers use regmap by adding a call to
snd_soc_codec_set_regmap(). This however needs more consideration
as currently the driver internal reads do caching and we would have
both regmap access and internal read/write access accessing the same
hardware registers.

So to fix the regression, let's just do a partial revert adding back
the read and write function pointers. Note that other non-regmap
ASoC drivers may need similar patches.

Fixes: 3bb0f7c31b1a ("ASoC: don't use snd_soc_write/read on twl4030")
Fixes: 93a00c467fe9 ("ASoC: don't use snd_soc_write/read on twl6040")
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Mark Brown <broonie@kernel.org>