tree c05df82e54139b41ffbd2ed9763514ca65f17746
parent a821328c2f3003b908880792d71b2781b44fa53c
author NeilBrown <neil@brown.name> 1521534591 +1100
committer James Hogan <jhogan@kernel.org> 1521675819 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlqy7j0ACgkQbAtpk944
 dnrRFg/+Mmyw2Zq2UbjXcKvR8zlr8cNlcB4vJ3JfLwiqtAPjhP/wnybMUUtsPkLa
 ps/qIyQQxvhl5o5563JxZBJT6/VGZIzrU00a0XFSR2Bpp4GtiZ22KJueRSXkg/bS
 9LkJenb4fgb9Zy8DGq+mON5JDpjhaWwWtZtNWLTsT57/UID+mJz4f5gM//cKKQ8b
 mpEFgXL3FpTWeeL9J9qpmgHnx9h8J2TKpM2iVs7xKaXrm9mxyeZZu3tZyjDLpnj6
 oQgDF4GH0qcZNnIgDe4nLfSFakYAh7HxWWXBD8N20u+KpCPLBtVd8kDwQMZ0IxjM
 4MJ7Bl3su4MH/JP9q1kwz8EPgCEtBMuC0hkakadDFdlYdMVFru1GrgxrF1LGayZv
 uWbUhjfw7M0hUmst3ek5ru3CAALN04s6WBLeeZZx6/FoXpOJHG+0D29Dwia/RNaC
 Hn3jodxHQmXY1XAXEmjYWODVaWpQwL7cwiJaiFcf8AMbLbqvBkMMZNLr68GyigGL
 qItFAhyw5Q0HrFpFwPf5DOK1eRYPYQqVAKlSQj+HehlNRiSWEtpEoW13FQwPyNiZ
 k81sXN7xlqns1NYKeC3Yw8fS1GK8pDME4pgbvdM6qv2oc/qiu0J6QIgXH/oLBqCf
 zhiSRuNjkVmhaPJ9GNEel2REy06tOou13PQ3+SDXD9aLqa7FZYs=
 =CFrX
 -----END PGP SIGNATURE-----

MIPS: ralink: Remove ralink_halt()

ralink_halt() does nothing that machine_halt() doesn't already do, so it
adds no value.

It actually causes incorrect behaviour due to the "unreachable()" at the
end. This tells the compiler that the end of the function will never be
reached, which isn't true. The compiler responds by not adding a
'return' instruction, so control simply moves on to whatever bytes come
afterwards in memory. In my tested, that was the ralink_restart()
function. This means that an attempt to 'halt' the machine would
actually cause a reboot.

So remove ralink_halt() so that a 'halt' really does halt.

Fixes: c06e836ada59 ("MIPS: ralink: adds reset code")
Signed-off-by: NeilBrown <neil@brown.name>
Cc: John Crispin <john@phrozen.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: <stable@vger.kernel.org> # 3.9+
Patchwork: https://patchwork.linux-mips.org/patch/18851/
Signed-off-by: James Hogan <jhogan@kernel.org>