tree 55455adc381b020f070659eb5435685a4dabda7a
parent e5ce067b7b6e123a88929a18a8a58811ffcec279
author Matthew R. Ochs <mrochs@linux.vnet.ibm.com> 1445458449 -0500
committer James Bottomley <JBottomley@Odin.com> 1446192902 +0900

cxlflash: Correct usage of scsi_host_put()

Currently, scsi_host_put() is being called prematurely in the
remove path and is missing entirely in an error cleanup path.
The former can lead to memory being freed too early with
subsequent access potentially corrupting data whilst the former
would result in a memory leak.

Move the usage on remove to be the last cleanup action taken
and introduce a call to scsi_host_put() in the one initialization
error path that does not use remove to cleanup.

Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <manoj@linux.vnet.ibm.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>