tree 13cb745526d6c46d8d2f2c0dc30eba546f1f5857
parent ced255c0c5fb9ab52c9465982f23b1c14005ef8b
author David Howells <dhowells@redhat.com> 1443195008 +0100
committer David Howells <dhowells@redhat.com> 1443195008 +0100

KEYS: Fix race between key destruction and finding a keyring by name

There appears to be a race between:

 (1) key_gc_unused_keys() which frees key->security and then calls
     keyring_destroy() to unlink the name from the name list

 (2) find_keyring_by_name() which calls key_permission(), thus accessing
     key->security, on a key before checking to see whether the key usage is 0
     (ie. the key is dead and might be cleaned up).

Fix this by calling ->destroy() before cleaning up the core key data -
including key->security.

Reported-by: Petr Matousek <pmatouse@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>