| commit | 9561f7faa45cb855b1ba83a4acf3f2ad3665e71f | [log] [tgz] |
|---|---|---|
| author | Dan Carpenter <dan.carpenter@oracle.com> | Fri Sep 23 09:21:13 2011 +0300 |
| committer | Jiri Kosina <jkosina@suse.cz> | Tue Sep 27 01:33:10 2011 +0200 |
| tree | 89138048c81d60f29a1cc605c2aae679bdeb4850 | |
| parent | 65b01bd561dc995aab116aa784f97a37f7c49a65 [diff] |
HID: hiddev: potential info leak in hiddev_ioctl()
Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.
In this case, the hiddev_devinfo struct has a two byte hole.
struct hiddev_devinfo {
__u32 bustype; /* 0 4 */
__u32 busnum; /* 4 4 */
__u32 devnum; /* 8 4 */
__u32 ifnum; /* 12 4 */
__s16 vendor; /* 16 2 */
__s16 product; /* 18 2 */
__s16 version; /* 20 2 */
/* XXX 2 bytes hole, try to pack */
__u32 num_applications; /* 24 4 */
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>