tree ee8549ff39f7b3cb11b3aaeb5c365b371e36547f
parent 7928b2cbe55b2a410a0f5c1f154610059c57b1b2
author Charles Keepax <ckeepax@opensource.cirrus.com> 1518459346 +0000
committer Mark Brown <broonie@kernel.org> 1518524864 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQFHBAABCgAxFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlqC2cATHGJyb29uaWVA
 a2VybmVsLm9yZwAKCRAk1otyXVSH0CezB/4v54y7xUejvkzIDwKsL70d4dI17/EM
 WCNYJKPuQzXGFCORM4/CTCGff3fhEGoYON8ukVEzRfyt12kuXKDalWKyrK3/ppV8
 is2qek16XtfkHTySP1wQiTolYlquFHHb5AjCDUw5n6R7Tja2qwneaCtefQff2jpt
 +wkayXztjZb/0uO270Gs+NlW7NzBpjnQY7TMTJjl9gDqNrgTL+1YJbshd4ynK5mk
 PsGWpJgJDbUcz5DgOxxUdLL/4ohfYe723Ae9rvl8H2qjcYv2bF76JY5gBnw9Ups2
 t/bisFyE1qc6BIeFsOsTwGrXdzPEEApKnOeo8fMWHDLQt7kSSyb5z3pR
 =PvRr
 -----END PGP SIGNATURE-----

regmap: Don't use format_val in regmap_bulk_read

A bulk read can be implemented either through regmap_raw_read, or
by reading each register individually using regmap_read.  Both
regmap_read and regmap_bulk_read should return values in native
endian. In the individual case the current implementation calls
format_val to put the data into the output array, which can cause
endian issues. The regmap_read will have already converted the data
into native endian, if the hosts endian differs from the device then
format_val will switch the endian back again.

Rather than using format_val simply use the code that is called if
there is no format_val function. This code supports all cases except
24-bit but there don't appear to be any users of regmap_bulk_read for
24-bit. Additionally, it would have to be a big endian host for the
old code to actually function correctly anyway.

Fixes: 15b8d2c41fe5 ("regmap: Fix regmap_bulk_read in BE mode")
Reported-by: David Rhodes <david.rhodes@cirrus.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>