tree 7536e2f5b457d8626a5d242a82bffe4f31fd0421
parent 9188dbaed68a4b23dc96eba165265c08caa7dc2a
author Julia Lawall <Julia.Lawall@lip6.fr> 1428235589 +0200
committer Jiri Kosina <jkosina@suse.cz> 1428267390 +0200

HID: logitech-hidpp: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>