tree 7624163947dd570869a61c42ac12cf91227838a3
parent 39a80bbf577864ff28bb42b0dbc5086b4206c587
author Colin Ian King <colin.king@canonical.com> 1576791166 +0000
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> 1582529677 +0100

clocksource/drivers/bcm2835_timer: Fix memory leak of timer

[ Upstream commit 2052d032c06761330bca4944bb7858b00960e868 ]

Currently when setup_irq fails the error exit path will leak the
recently allocated timer structure.  Originally the code would
throw a panic but a later commit changed the behaviour to return
via the err_iounmap path and hence we now have a memory leak. Fix
this by adding a err_timer_free error path that kfree's timer.

Addresses-Coverity: ("Resource Leak")
Fixes: 524a7f08983d ("clocksource/drivers/bcm2835_timer: Convert init function to return error")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20191219213246.34437-1-colin.king@canonical.com
Signed-off-by: Sasha Levin <sashal@kernel.org>