commit ee34e2644a78e2561742bea8c4bdcf83cabf90a7
author Tudor-Dan Ambarus <tudor.ambarus@microchip.com> Thu May 25 10:18:07 2017 +0300
committer Herbert Xu <herbert@gondor.apana.org.au> Sat Jun 10 12:04:26 2017 +0800
tree eb077fddef51f7e0abd4a9fba05ca523cff91b49
parent 7380c56d2fcaa882a0809aad075c3f9fdc3b3c50

crypto: dh - fix memleak in setkey

setkey can be called multiple times during the existence
of the transformation object. In case of multiple setkey calls,
the old key was not freed and we leaked memory.
Free the old MPI key if any.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

crypto/dh.c

diff --git a/crypto/dh.c b/crypto/dh.c
index 7cec0498..e151f12 100644
--- a/crypto/dh.c
+++ b/crypto/dh.c
@@ -85,6 +85,9 @@
 	struct dh_ctx *ctx = dh_get_ctx(tfm);
 	struct dh params;
 
+	/* Free the old MPI key if any */
+	dh_free_ctx(ctx);
+
 	if (crypto_dh_decode_key(buf, len, &params) < 0)
 		return -EINVAL;