blob: 31c8df5d20c74997035dee803f7cd56b1980916d [file] [log] [blame]
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -08001HOWTO do Linux kernel development
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -03002=================================
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -08003
4This is the be-all, end-all document on this topic. It contains
5instructions on how to become a Linux kernel developer and how to learn
6to work with the Linux kernel development community. It tries to not
7contain anything related to the technical aspects of kernel programming,
8but will help point you in the right direction for that.
9
10If anything in this document becomes out of date, please send in patches
11to the maintainer of this file, who is listed at the bottom of the
12document.
13
14
15Introduction
16------------
17
18So, you want to learn how to become a Linux kernel developer? Or you
19have been told by your manager, "Go write a Linux driver for this
20device." This document's goal is to teach you everything you need to
21know to achieve this by describing the process you need to go through,
22and hints on how to work with the community. It will also try to
23explain some of the reasons why the community works like it does.
24
25The kernel is written mostly in C, with some architecture-dependent
26parts written in assembly. A good understanding of C is required for
27kernel development. Assembly (any architecture) is not required unless
28you plan to do low-level development for that architecture. Though they
29are not a good substitute for a solid C education and/or years of
30experience, the following books are good for, if anything, reference:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030031
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080032 - "The C Programming Language" by Kernighan and Ritchie [Prentice Hall]
33 - "Practical C Programming" by Steve Oualline [O'Reilly]
Robert P. J. Day4de0ca82007-01-17 04:54:07 -050034 - "C: A Reference Manual" by Harbison and Steele [Prentice Hall]
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080035
36The kernel is written using GNU C and the GNU toolchain. While it
37adheres to the ISO C89 standard, it uses a number of extensions that are
38not featured in the standard. The kernel is a freestanding C
39environment, with no reliance on the standard C library, so some
40portions of the C standard are not supported. Arbitrary long long
41divisions and floating point are not allowed. It can sometimes be
42difficult to understand the assumptions the kernel has on the toolchain
43and the extensions that it uses, and unfortunately there is no
44definitive reference for them. Please check the gcc info pages (`info
45gcc`) for some information on them.
46
47Please remember that you are trying to learn how to work with the
48existing development community. It is a diverse group of people, with
49high standards for coding, style and procedure. These standards have
50been created over time based on what they have found to work best for
51such a large and geographically dispersed team. Try to learn as much as
52possible about these standards ahead of time, as they are well
53documented; do not expect people to adapt to you or your company's way
54of doing things.
55
56
57Legal Issues
58------------
59
60The Linux kernel source code is released under the GPL. Please see the
61file, COPYING, in the main directory of the source tree, for details on
62the license. If you have further questions about the license, please
63contact a lawyer, and do not ask on the Linux kernel mailing list. The
64people on the mailing lists are not lawyers, and you should not rely on
65their statements on legal matters.
66
67For common questions and answers about the GPL, please see:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030068
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080069 http://www.gnu.org/licenses/gpl-faq.html
70
71
72Documentation
Philippe Loctauxce655082016-03-07 02:36:18 +010073-------------
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080074
75The Linux kernel source tree has a large range of documents that are
76invaluable for learning how to interact with the kernel community. When
77new features are added to the kernel, it is recommended that new
78documentation files are also added which explain how to use the feature.
79When a kernel change causes the interface that the kernel exposes to
80userspace to change, it is recommended that you send the information or
81a patch to the manual pages explaining the change to the manual pages
Michael Kerrisk09b05f52008-10-03 15:23:45 -070082maintainer at mtk.manpages@gmail.com, and CC the list
83linux-api@vger.kernel.org.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080084
85Here is a list of files that are in the kernel source tree that are
86required reading:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030087
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080088 README
89 This file gives a short background on the Linux kernel and describes
90 what is necessary to do to configure and build the kernel. People
91 who are new to the kernel should start here.
92
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -030093 :ref:`Documentation/Changes <changes>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080094 This file gives a list of the minimum levels of various software
95 packages that are necessary to build and run the kernel
96 successfully.
97
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -030098 :ref:`Documentation/CodingStyle <codingstyle>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080099 This describes the Linux kernel coding style, and some of the
100 rationale behind it. All new code is expected to follow the
101 guidelines in this document. Most maintainers will only accept
102 patches if these rules are followed, and many people will only
103 review code if it is in the proper style.
104
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300105 :ref:`Documentation/SubmittingPatches <submittingpatches>` and :ref:`Documentation/SubmittingDrivers <submittingdrivers>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800106 These files describe in explicit detail how to successfully create
107 and send a patch, including (but not limited to):
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300108
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800109 - Email contents
110 - Email format
111 - Who to send it to
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300112
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800113 Following these rules will not guarantee success (as all patches are
114 subject to scrutiny for content and style), but not following them
115 will almost always prevent it.
116
117 Other excellent descriptions of how to create patches properly are:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300118
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800119 "The Perfect Patch"
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300120
SeongJae Park937d9f52013-12-06 18:04:42 +0900121 http://www.ozlabs.org/~akpm/stuff/tpp.txt
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300122
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800123 "Linux kernel patch submission format"
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300124
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800125 http://linux.yyz.us/patch-format.html
126
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300127 :ref:`Documentation/stable_api_nonsense.txt <stable_api_nonsense>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800128 This file describes the rationale behind the conscious decision to
129 not have a stable API within the kernel, including things like:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300130
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800131 - Subsystem shim-layers (for compatibility?)
132 - Driver portability between Operating Systems.
133 - Mitigating rapid change within the kernel source tree (or
134 preventing rapid change)
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300135
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800136 This document is crucial for understanding the Linux development
137 philosophy and is very important for people moving to Linux from
138 development on other Operating Systems.
139
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300140 :ref:`Documentation/SecurityBugs <securitybugs>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800141 If you feel you have found a security problem in the Linux kernel,
142 please follow the steps in this document to help notify the kernel
143 developers, and help solve the issue.
144
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300145 :ref:`Documentation/ManagementStyle <managementstyle>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800146 This document describes how Linux kernel maintainers operate and the
147 shared ethos behind their methodologies. This is important reading
148 for anyone new to kernel development (or anyone simply curious about
149 it), as it resolves a lot of common misconceptions and confusion
150 about the unique behavior of kernel maintainers.
151
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300152 :ref:`Documentation/stable_kernel_rules.txt <stable_kernel_rules>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800153 This file describes the rules on how the stable kernel releases
154 happen, and what to do if you want to get a change into one of these
155 releases.
156
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300157 :ref:`Documentation/kernel-docs.txt <kernel_docs>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800158 A list of external documentation that pertains to kernel
159 development. Please consult this list if you do not find what you
160 are looking for within the in-kernel documentation.
161
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300162 :ref:`Documentation/applying-patches.txt <applying_patches>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800163 A good introduction describing exactly what a patch is and how to
164 apply it to the different development branches of the kernel.
165
166The kernel also has a large number of documents that can be
167automatically generated from the source code itself. This includes a
168full description of the in-kernel API, and rules on how to handle
169locking properly. The documents will be created in the
170Documentation/DocBook/ directory and can be generated as PDF,
171Postscript, HTML, and man pages by running:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300172
173::
174
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800175 make pdfdocs
176 make psdocs
177 make htmldocs
178 make mandocs
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300179
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800180respectively from the main kernel source directory.
181
182
183Becoming A Kernel Developer
184---------------------------
185
186If you do not know anything about Linux kernel development, you should
187look at the Linux KernelNewbies project:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300188
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800189 http://kernelnewbies.org
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300190
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800191It consists of a helpful mailing list where you can ask almost any type
192of basic kernel development question (make sure to search the archives
193first, before asking something that has already been answered in the
194past.) It also has an IRC channel that you can use to ask questions in
195real-time, and a lot of helpful documentation that is useful for
196learning about Linux kernel development.
197
198The website has basic information about code organization, subsystems,
199and current projects (both in-tree and out-of-tree). It also describes
200some basic logistical information, like how to compile a kernel and
201apply a patch.
202
203If you do not know where you want to start, but you want to look for
204some task to start doing to join into the kernel development community,
205go to the Linux Kernel Janitor's project:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300206
Peter Loeffler5645a712016-01-30 21:53:53 +0100207 http://kernelnewbies.org/KernelJanitors
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300208
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800209It is a great place to start. It describes a list of relatively simple
210problems that need to be cleaned up and fixed within the Linux kernel
211source tree. Working with the developers in charge of this project, you
212will learn the basics of getting your patch into the Linux kernel tree,
213and possibly be pointed in the direction of what to go work on next, if
214you do not already have an idea.
215
216If you already have a chunk of code that you want to put into the kernel
217tree, but need some help getting it in the proper form, the
218kernel-mentors project was created to help you out with this. It is a
219mailing list, and can be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300220
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800221 http://selenic.com/mailman/listinfo/kernel-mentors
222
223Before making any actual modifications to the Linux kernel code, it is
224imperative to understand how the code in question works. For this
225purpose, nothing is better than reading through it directly (most tricky
226bits are commented well), perhaps even with the help of specialized
227tools. One such tool that is particularly recommended is the Linux
228Cross-Reference project, which is able to present source code in a
229self-referential, indexed webpage format. An excellent up-to-date
230repository of the kernel code may be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300231
Doug Smythies1d125542015-11-22 15:42:48 -0800232 http://lxr.free-electrons.com/
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800233
234
235The development process
236-----------------------
237
238Linux kernel development process currently consists of a few different
239main kernel "branches" and lots of different subsystem-specific kernel
240branches. These different branches are:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300241
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500242 - main 4.x kernel tree
243 - 4.x.y -stable kernel tree
244 - 4.x -git kernel patches
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800245 - subsystem specific kernel trees and patches
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500246 - the 4.x -next kernel tree for integration tests
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800247
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002484.x kernel tree
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800249-----------------
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002504.x kernels are maintained by Linus Torvalds, and can be found on
251kernel.org in the pub/linux/kernel/v4.x/ directory. Its development
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800252process is as follows:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300253
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800254 - As soon as a new kernel is released a two weeks window is open,
255 during this period of time maintainers can submit big diffs to
256 Linus, usually the patches that have already been included in the
Stefan Richterc607cf02010-01-15 13:23:51 +0100257 -next kernel for a few weeks. The preferred way to submit big changes
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800258 is using git (the kernel's source management tool, more information
Randy Dunlape234ebf2010-04-06 16:16:59 -0700259 can be found at http://git-scm.com/) but plain patches are also just
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800260 fine.
261 - After two weeks a -rc1 kernel is released it is now possible to push
262 only patches that do not include new features that could affect the
263 stability of the whole kernel. Please note that a whole new driver
264 (or filesystem) might be accepted after -rc1 because there is no
265 risk of causing regressions with such a change as long as the change
266 is self-contained and does not affect areas outside of the code that
267 is being added. git can be used to send patches to Linus after -rc1
268 is released, but the patches need to also be sent to a public
269 mailing list for review.
270 - A new -rc is released whenever Linus deems the current git tree to
271 be in a reasonably sane state adequate for testing. The goal is to
272 release a new -rc kernel every week.
273 - Process continues until the kernel is considered "ready", the
274 process should last around 6 weeks.
275
276It is worth mentioning what Andrew Morton wrote on the linux-kernel
277mailing list about kernel releases:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300278
279::
280
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800281 "Nobody knows when a kernel will be released, because it's
282 released according to perceived bug status, not according to a
283 preconceived timeline."
284
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002854.x.y -stable kernel tree
Philippe Loctauxce655082016-03-07 02:36:18 +0100286-------------------------
Kees Cook591bfc62012-04-18 23:16:45 -0700287Kernels with 3-part versions are -stable kernels. They contain
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800288relatively small and critical fixes for security problems or significant
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500289regressions discovered in a given 4.x kernel.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800290
291This is the recommended branch for users who want the most recent stable
292kernel and are not interested in helping test development/experimental
293versions.
294
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500295If no 4.x.y kernel is available, then the highest numbered 4.x
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800296kernel is the current stable kernel.
297
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002984.x.y are maintained by the "stable" team <stable@vger.kernel.org>, and
Joe Perches2eb7f202011-12-09 14:12:00 -0800299are released as needs dictate. The normal release period is approximately
Jonathan Corbet0fe8a3c2008-04-25 11:23:56 -0600300two weeks, but it can be longer if there are no pressing problems. A
301security-related problem, instead, can cause a release to happen almost
302instantly.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800303
304The file Documentation/stable_kernel_rules.txt in the kernel tree
305documents what kinds of changes are acceptable for the -stable tree, and
306how the release process works.
307
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003084.x -git patches
Philippe Loctauxce655082016-03-07 02:36:18 +0100309----------------
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800310These are daily snapshots of Linus' kernel tree which are managed in a
311git repository (hence the name.) These patches are usually released
312daily and represent the current state of Linus' tree. They are more
313experimental than -rc kernels since they are generated automatically
314without even a cursory glance to see if they are sane.
315
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800316Subsystem Specific kernel trees and patches
317-------------------------------------------
Stefan Richterc607cf02010-01-15 13:23:51 +0100318The maintainers of the various kernel subsystems --- and also many
319kernel subsystem developers --- expose their current state of
320development in source repositories. That way, others can see what is
321happening in the different areas of the kernel. In areas where
322development is rapid, a developer may be asked to base his submissions
323onto such a subsystem kernel tree so that conflicts between the
324submission and other already ongoing work are avoided.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800325
Stefan Richterc607cf02010-01-15 13:23:51 +0100326Most of these repositories are git trees, but there are also other SCMs
327in use, or patch queues being published as quilt series. Addresses of
328these subsystem repositories are listed in the MAINTAINERS file. Many
329of them can be browsed at http://git.kernel.org/.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800330
Stefan Richterc607cf02010-01-15 13:23:51 +0100331Before a proposed patch is committed to such a subsystem tree, it is
332subject to review which primarily happens on mailing lists (see the
333respective section below). For several kernel subsystems, this review
334process is tracked with the tool patchwork. Patchwork offers a web
335interface which shows patch postings, any comments on a patch or
336revisions to it, and maintainers can mark patches as under review,
337accepted, or rejected. Most of these patchwork sites are listed at
Justin P. Mattock0ea6e612010-07-23 20:51:24 -0700338http://patchwork.kernel.org/.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800339
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003404.x -next kernel tree for integration tests
Philippe Loctauxce655082016-03-07 02:36:18 +0100341-------------------------------------------
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500342Before updates from subsystem trees are merged into the mainline 4.x
Stefan Richterc607cf02010-01-15 13:23:51 +0100343tree, they need to be integration-tested. For this purpose, a special
344testing repository exists into which virtually all subsystem trees are
345pulled on an almost daily basis:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300346
Kees Cook591bfc62012-04-18 23:16:45 -0700347 http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800348
Stefan Richterc607cf02010-01-15 13:23:51 +0100349This way, the -next kernel gives a summary outlook onto what will be
350expected to go into the mainline kernel at the next merge period.
351Adventurous testers are very welcome to runtime-test the -next kernel.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800352
Stefan Richter8a465c32007-06-27 14:10:01 -0700353
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800354Bug Reporting
355-------------
356
357bugzilla.kernel.org is where the Linux kernel developers track kernel
358bugs. Users are encouraged to report all bugs that they find in this
359tool. For details on how to use the kernel bugzilla, please see:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300360
Jiri Pirko0302c012008-07-13 12:13:59 -0700361 http://bugzilla.kernel.org/page.cgi?id=faq.html
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800362
363The file REPORTING-BUGS in the main kernel source directory has a good
364template for how to report a possible kernel bug, and details what kind
365of information is needed by the kernel developers to help track down the
366problem.
367
368
Diego Calleja3f271002006-09-30 23:27:49 -0700369Managing bug reports
370--------------------
371
372One of the best ways to put into practice your hacking skills is by fixing
373bugs reported by other people. Not only you will help to make the kernel
374more stable, you'll learn to fix real world problems and you will improve
375your skills, and other developers will be aware of your presence. Fixing
Qi Yong4db29c12007-06-12 13:06:49 +0800376bugs is one of the best ways to get merits among other developers, because
Diego Calleja3f271002006-09-30 23:27:49 -0700377not many people like wasting time fixing other people's bugs.
378
379To work in the already reported bug reports, go to http://bugzilla.kernel.org.
380If you want to be advised of the future bug reports, you can subscribe to the
381bugme-new mailing list (only new bug reports are mailed here) or to the
382bugme-janitor mailing list (every change in the bugzilla is mailed here)
383
Jonathan Corbet0fe8a3c2008-04-25 11:23:56 -0600384 http://lists.linux-foundation.org/mailman/listinfo/bugme-new
385 http://lists.linux-foundation.org/mailman/listinfo/bugme-janitors
Diego Calleja3f271002006-09-30 23:27:49 -0700386
387
388
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800389Mailing lists
390-------------
391
392As some of the above documents describe, the majority of the core kernel
393developers participate on the Linux Kernel Mailing list. Details on how
394to subscribe and unsubscribe from the list can be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300395
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800396 http://vger.kernel.org/vger-lists.html#linux-kernel
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300397
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800398There are archives of the mailing list on the web in many different
399places. Use a search engine to find these archives. For example:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300400
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800401 http://dir.gmane.org/gmane.linux.kernel
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300402
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800403It is highly recommended that you search the archives about the topic
404you want to bring up, before you post it to the list. A lot of things
405already discussed in detail are only recorded at the mailing list
406archives.
407
408Most of the individual kernel subsystems also have their own separate
409mailing list where they do their development efforts. See the
410MAINTAINERS file for a list of what these lists are for the different
411groups.
412
413Many of the lists are hosted on kernel.org. Information on them can be
414found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300415
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800416 http://vger.kernel.org/vger-lists.html
417
418Please remember to follow good behavioral habits when using the lists.
419Though a bit cheesy, the following URL has some simple guidelines for
420interacting with the list (or any list):
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300421
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800422 http://www.albion.com/netiquette/
423
424If multiple people respond to your mail, the CC: list of recipients may
425get pretty large. Don't remove anybody from the CC: list without a good
426reason, or don't reply only to the list address. Get used to receiving the
427mail twice, one from the sender and the one from the list, and don't try
428to tune that by adding fancy mail-headers, people will not like it.
429
430Remember to keep the context and the attribution of your replies intact,
431keep the "John Kernelhacker wrote ...:" lines at the top of your reply, and
432add your statements between the individual quoted sections instead of
433writing at the top of the mail.
434
435If you add patches to your mail, make sure they are plain readable text
436as stated in Documentation/SubmittingPatches. Kernel developers don't
437want to deal with attachments or compressed patches; they may want
438to comment on individual lines of your patch, which works only that way.
439Make sure you use a mail program that does not mangle spaces and tab
440characters. A good first test is to send the mail to yourself and try
441to apply your own patch by yourself. If that doesn't work, get your
442mail program fixed or change it until it works.
443
444Above all, please remember to show respect to other subscribers.
445
446
447Working with the community
448--------------------------
449
450The goal of the kernel community is to provide the best possible kernel
451there is. When you submit a patch for acceptance, it will be reviewed
452on its technical merits and those alone. So, what should you be
453expecting?
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300454
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800455 - criticism
456 - comments
457 - requests for change
458 - requests for justification
459 - silence
460
461Remember, this is part of getting your patch into the kernel. You have
462to be able to take criticism and comments about your patches, evaluate
463them at a technical level and either rework your patches or provide
464clear and concise reasoning as to why those changes should not be made.
465If there are no responses to your posting, wait a few days and try
466again, sometimes things get lost in the huge volume.
467
468What should you not do?
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300469
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800470 - expect your patch to be accepted without question
471 - become defensive
472 - ignore comments
473 - resubmit the patch without making any of the requested changes
474
475In a community that is looking for the best technical solution possible,
476there will always be differing opinions on how beneficial a patch is.
477You have to be cooperative, and willing to adapt your idea to fit within
478the kernel. Or at least be willing to prove your idea is worth it.
479Remember, being wrong is acceptable as long as you are willing to work
480toward a solution that is right.
481
482It is normal that the answers to your first patch might simply be a list
483of a dozen things you should correct. This does _not_ imply that your
484patch will not be accepted, and it is _not_ meant against you
485personally. Simply correct all issues raised against your patch and
486resend it.
487
488
489Differences between the kernel community and corporate structures
490-----------------------------------------------------------------
491
492The kernel community works differently than most traditional corporate
493development environments. Here are a list of things that you can try to
Cristian Stoica106f9d92012-12-07 16:37:11 +0200494do to avoid problems:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300495
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800496 Good things to say regarding your proposed changes:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300497
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800498 - "This solves multiple problems."
499 - "This deletes 2000 lines of code."
500 - "Here is a patch that explains what I am trying to describe."
501 - "I tested it on 5 different architectures..."
502 - "Here is a series of small patches that..."
503 - "This increases performance on typical machines..."
504
505 Bad things you should avoid saying:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300506
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800507 - "We did it this way in AIX/ptx/Solaris, so therefore it must be
508 good..."
509 - "I've being doing this for 20 years, so..."
510 - "This is required for my company to make money"
511 - "This is for our Enterprise product line."
512 - "Here is my 1000 page design document that describes my idea"
513 - "I've been working on this for 6 months..."
514 - "Here's a 5000 line patch that..."
515 - "I rewrote all of the current mess, and here it is..."
516 - "I have a deadline, and this patch needs to be applied now."
517
518Another way the kernel community is different than most traditional
519software engineering work environments is the faceless nature of
520interaction. One benefit of using email and irc as the primary forms of
521communication is the lack of discrimination based on gender or race.
522The Linux kernel work environment is accepting of women and minorities
523because all you are is an email address. The international aspect also
524helps to level the playing field because you can't guess gender based on
525a person's name. A man may be named Andrea and a woman may be named Pat.
526Most women who have worked in the Linux kernel and have expressed an
527opinion have had positive experiences.
528
529The language barrier can cause problems for some people who are not
530comfortable with English. A good grasp of the language can be needed in
531order to get ideas across properly on mailing lists, so it is
532recommended that you check your emails to make sure they make sense in
533English before sending them.
534
535
536Break up your changes
537---------------------
538
539The Linux kernel community does not gladly accept large chunks of code
540dropped on it all at once. The changes need to be properly introduced,
541discussed, and broken up into tiny, individual portions. This is almost
542the exact opposite of what companies are used to doing. Your proposal
543should also be introduced very early in the development process, so that
544you can receive feedback on what you are doing. It also lets the
545community feel that you are working with them, and not simply using them
546as a dumping ground for your feature. However, don't send 50 emails at
547one time to a mailing list, your patch series should be smaller than
548that almost all of the time.
549
550The reasons for breaking things up are the following:
551
5521) Small patches increase the likelihood that your patches will be
553 applied, since they don't take much time or effort to verify for
554 correctness. A 5 line patch can be applied by a maintainer with
555 barely a second glance. However, a 500 line patch may take hours to
556 review for correctness (the time it takes is exponentially
557 proportional to the size of the patch, or something).
558
559 Small patches also make it very easy to debug when something goes
560 wrong. It's much easier to back out patches one by one than it is
561 to dissect a very large patch after it's been applied (and broken
562 something).
563
5642) It's important not only to send small patches, but also to rewrite
565 and simplify (or simply re-order) patches before submitting them.
566
567Here is an analogy from kernel developer Al Viro:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300568
569::
570
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800571 "Think of a teacher grading homework from a math student. The
572 teacher does not want to see the student's trials and errors
573 before they came up with the solution. They want to see the
574 cleanest, most elegant answer. A good student knows this, and
575 would never submit her intermediate work before the final
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300576 solution.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800577
578 The same is true of kernel development. The maintainers and
579 reviewers do not want to see the thought process behind the
580 solution to the problem one is solving. They want to see a
581 simple and elegant solution."
582
583It may be challenging to keep the balance between presenting an elegant
584solution and working together with the community and discussing your
585unfinished work. Therefore it is good to get early in the process to
586get feedback to improve your work, but also keep your changes in small
587chunks that they may get already accepted, even when your whole task is
588not ready for inclusion now.
589
590Also realize that it is not acceptable to send patches for inclusion
591that are unfinished and will be "fixed up later."
592
593
594Justify your change
595-------------------
596
597Along with breaking up your patches, it is very important for you to let
598the Linux community know why they should add this change. New features
599must be justified as being needed and useful.
600
601
602Document your change
603--------------------
604
605When sending in your patches, pay special attention to what you say in
606the text in your email. This information will become the ChangeLog
607information for the patch, and will be preserved for everyone to see for
608all time. It should describe the patch completely, containing:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300609
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800610 - why the change is necessary
611 - the overall design approach in the patch
612 - implementation details
613 - testing results
614
615For more details on what this should all look like, please see the
616ChangeLog section of the document:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300617
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800618 "The Perfect Patch"
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300619
SeongJae Park937d9f52013-12-06 18:04:42 +0900620 http://www.ozlabs.org/~akpm/stuff/tpp.txt
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800621
622
623
624
625All of these things are sometimes very hard to do. It can take years to
626perfect these practices (if at all). It's a continuous process of
627improvement that requires a lot of patience and determination. But
628don't give up, it's possible. Many have done it before, and each had to
629start exactly where you are now.
630
631
632
633
634----------
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300635
Paolo Ciarrocchi5bd982e2006-04-25 22:47:51 +0200636Thanks to Paolo Ciarrocchi who allowed the "Development Process"
Justin P. Mattock0ea6e612010-07-23 20:51:24 -0700637(http://lwn.net/Articles/94386/) section
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800638to be based on text he had written, and to Randy Dunlap and Gerrit
639Huizenga for some of the list of things you should and should not say.
640Also thanks to Pat Mochel, Hanna Linder, Randy Dunlap, Kay Sievers,
641Vojtech Pavlik, Jan Kara, Josh Boyer, Kees Cook, Andrew Morton, Andi
642Kleen, Vadim Lobanov, Jesper Juhl, Adrian Bunk, Keri Harris, Frans Pop,
643David A. Wheeler, Junio Hamano, Michael Kerrisk, and Alex Shepard for
644their review, comments, and contributions. Without their help, this
645document would not have been possible.
646
647
648
649Maintainer: Greg Kroah-Hartman <greg@kroah.com>