blob: 33ee8cb32f8314a8e3a90710a3f4bcebfa3fdb8e [file] [log] [blame]
Greg Kroah-Hartmanb2441312017-11-01 15:07:57 +01001// SPDX-License-Identifier: GPL-2.0
Mike Marshall5db11c22015-07-17 10:38:12 -04002/*
3 * (C) 2001 Clemson University and The University of Chicago
4 *
5 * Changes by Acxiom Corporation to add protocol version to kernel
6 * communication, Copyright Acxiom Corporation, 2005.
7 *
8 * See COPYING in top-level directory.
9 */
10
11#include "protocol.h"
Mike Marshall575e9462015-12-04 12:56:14 -050012#include "orangefs-kernel.h"
13#include "orangefs-dev-proto.h"
14#include "orangefs-bufmap.h"
Martin Brandenburg44f46412016-08-15 11:38:36 -040015#include "orangefs-debugfs.h"
Mike Marshall5db11c22015-07-17 10:38:12 -040016
17#include <linux/debugfs.h>
18#include <linux/slab.h>
19
20/* this file implements the /dev/pvfs2-req device node */
21
Martin Brandenburg482664d2016-08-12 12:02:31 -040022uint32_t orangefs_userspace_version;
Martin Brandenburgf2ee3b72016-08-09 15:59:26 -040023
Mike Marshall5db11c22015-07-17 10:38:12 -040024static int open_access_count;
25
Martin Brandenburga0fe0512016-08-15 15:21:16 -040026static DEFINE_MUTEX(devreq_mutex);
27
Mike Marshall5db11c22015-07-17 10:38:12 -040028#define DUMP_DEVICE_ERROR() \
29do { \
30 gossip_err("*****************************************************\n");\
Yi Liu8bb8aef2015-11-24 15:12:14 -050031 gossip_err("ORANGEFS Device Error: You cannot open the device file "); \
Mike Marshall5db11c22015-07-17 10:38:12 -040032 gossip_err("\n/dev/%s more than once. Please make sure that\nthere " \
Yi Liu8bb8aef2015-11-24 15:12:14 -050033 "are no ", ORANGEFS_REQDEVICE_NAME); \
Mike Marshall5db11c22015-07-17 10:38:12 -040034 gossip_err("instances of a program using this device\ncurrently " \
35 "running. (You must verify this!)\n"); \
36 gossip_err("For example, you can use the lsof program as follows:\n");\
37 gossip_err("'lsof | grep %s' (run this as root)\n", \
Yi Liu8bb8aef2015-11-24 15:12:14 -050038 ORANGEFS_REQDEVICE_NAME); \
Mike Marshall5db11c22015-07-17 10:38:12 -040039 gossip_err(" open_access_count = %d\n", open_access_count); \
40 gossip_err("*****************************************************\n");\
41} while (0)
42
43static int hash_func(__u64 tag, int table_size)
44{
Mike Marshall2c590d52015-07-24 10:37:15 -040045 return do_div(tag, (unsigned int)table_size);
Mike Marshall5db11c22015-07-17 10:38:12 -040046}
47
Yi Liu8bb8aef2015-11-24 15:12:14 -050048static void orangefs_devreq_add_op(struct orangefs_kernel_op_s *op)
Mike Marshall5db11c22015-07-17 10:38:12 -040049{
50 int index = hash_func(op->tag, hash_table_size);
51
Martin Brandenburg1d503612016-08-16 11:38:14 -040052 list_add_tail(&op->list, &orangefs_htable_ops_in_progress[index]);
Mike Marshall5db11c22015-07-17 10:38:12 -040053}
54
Mike Marshallca9f5182016-02-26 10:21:12 -050055/*
56 * find the op with this tag and remove it from the in progress
57 * hash table.
58 */
Yi Liu8bb8aef2015-11-24 15:12:14 -050059static struct orangefs_kernel_op_s *orangefs_devreq_remove_op(__u64 tag)
Mike Marshall5db11c22015-07-17 10:38:12 -040060{
Yi Liu8bb8aef2015-11-24 15:12:14 -050061 struct orangefs_kernel_op_s *op, *next;
Mike Marshall5db11c22015-07-17 10:38:12 -040062 int index;
63
64 index = hash_func(tag, hash_table_size);
65
Martin Brandenburg1d503612016-08-16 11:38:14 -040066 spin_lock(&orangefs_htable_ops_in_progress_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -040067 list_for_each_entry_safe(op,
68 next,
Martin Brandenburg1d503612016-08-16 11:38:14 -040069 &orangefs_htable_ops_in_progress[index],
Mike Marshall5db11c22015-07-17 10:38:12 -040070 list) {
Al Viro05a50a52016-02-18 18:59:44 -050071 if (op->tag == tag && !op_state_purged(op) &&
72 !op_state_given_up(op)) {
Al Viroed42fe02016-01-22 19:47:47 -050073 list_del_init(&op->list);
Martin Brandenburg1d503612016-08-16 11:38:14 -040074 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -040075 return op;
76 }
77 }
78
Martin Brandenburg1d503612016-08-16 11:38:14 -040079 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -040080 return NULL;
81}
82
Martin Brandenburgacfcbaf2016-03-05 13:17:39 -050083/* Returns whether any FS are still pending remounted */
84static int mark_all_pending_mounts(void)
85{
86 int unmounted = 1;
87 struct orangefs_sb_info_s *orangefs_sb = NULL;
88
89 spin_lock(&orangefs_superblocks_lock);
90 list_for_each_entry(orangefs_sb, &orangefs_superblocks, list) {
91 /* All of these file system require a remount */
92 orangefs_sb->mount_pending = 1;
93 unmounted = 0;
94 }
95 spin_unlock(&orangefs_superblocks_lock);
96 return unmounted;
97}
98
99/*
100 * Determine if a given file system needs to be remounted or not
101 * Returns -1 on error
102 * 0 if already mounted
103 * 1 if needs remount
104 */
105static int fs_mount_pending(__s32 fsid)
106{
107 int mount_pending = -1;
108 struct orangefs_sb_info_s *orangefs_sb = NULL;
109
110 spin_lock(&orangefs_superblocks_lock);
111 list_for_each_entry(orangefs_sb, &orangefs_superblocks, list) {
112 if (orangefs_sb->fs_id == fsid) {
113 mount_pending = orangefs_sb->mount_pending;
114 break;
115 }
116 }
117 spin_unlock(&orangefs_superblocks_lock);
118 return mount_pending;
119}
120
Yi Liu8bb8aef2015-11-24 15:12:14 -0500121static int orangefs_devreq_open(struct inode *inode, struct file *file)
Mike Marshall5db11c22015-07-17 10:38:12 -0400122{
123 int ret = -EINVAL;
124
Jann Horn78fee0b2016-06-25 01:51:52 +0200125 /* in order to ensure that the filesystem driver sees correct UIDs */
126 if (file->f_cred->user_ns != &init_user_ns) {
127 gossip_err("%s: device cannot be opened outside init_user_ns\n",
128 __func__);
129 goto out;
130 }
131
Mike Marshall5db11c22015-07-17 10:38:12 -0400132 if (!(file->f_flags & O_NONBLOCK)) {
Mike Marshall97f10022015-12-11 16:45:03 -0500133 gossip_err("%s: device cannot be opened in blocking mode\n",
134 __func__);
Mike Marshall5db11c22015-07-17 10:38:12 -0400135 goto out;
136 }
137 ret = -EACCES;
Mike Marshall97f10022015-12-11 16:45:03 -0500138 gossip_debug(GOSSIP_DEV_DEBUG, "client-core: opening device\n");
Mike Marshall5db11c22015-07-17 10:38:12 -0400139 mutex_lock(&devreq_mutex);
140
141 if (open_access_count == 0) {
Al Virofee25ce2016-01-22 19:46:08 -0500142 open_access_count = 1;
Al Virofb6d2522016-01-19 12:00:26 -0500143 ret = 0;
Mike Marshall5db11c22015-07-17 10:38:12 -0400144 } else {
145 DUMP_DEVICE_ERROR();
146 }
147 mutex_unlock(&devreq_mutex);
148
149out:
150
151 gossip_debug(GOSSIP_DEV_DEBUG,
152 "pvfs2-client-core: open device complete (ret = %d)\n",
153 ret);
154 return ret;
155}
156
Mike Marshall97f10022015-12-11 16:45:03 -0500157/* Function for read() callers into the device */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500158static ssize_t orangefs_devreq_read(struct file *file,
Mike Marshall5db11c22015-07-17 10:38:12 -0400159 char __user *buf,
160 size_t count, loff_t *offset)
161{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500162 struct orangefs_kernel_op_s *op, *temp;
163 __s32 proto_ver = ORANGEFS_KERNEL_PROTO_VERSION;
164 static __s32 magic = ORANGEFS_DEVREQ_MAGIC;
Martin Brandenburga0ec1de2018-01-22 15:44:52 -0500165 struct orangefs_kernel_op_s *cur_op;
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500166 unsigned long ret;
Mike Marshall5db11c22015-07-17 10:38:12 -0400167
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500168 /* We do not support blocking IO. */
Mike Marshall5db11c22015-07-17 10:38:12 -0400169 if (!(file->f_flags & O_NONBLOCK)) {
Mike Marshall97f10022015-12-11 16:45:03 -0500170 gossip_err("%s: blocking read from client-core.\n",
171 __func__);
Mike Marshall5db11c22015-07-17 10:38:12 -0400172 return -EINVAL;
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500173 }
174
175 /*
Martin Brandenburga762ae62015-12-15 14:22:06 -0500176 * The client will do an ioctl to find MAX_DEV_REQ_UPSIZE, then
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500177 * always read with that size buffer.
178 */
Martin Brandenburga762ae62015-12-15 14:22:06 -0500179 if (count != MAX_DEV_REQ_UPSIZE) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500180 gossip_err("orangefs: client-core tried to read wrong size\n");
181 return -EINVAL;
182 }
183
Martin Brandenburgb7a57cc2017-04-25 15:38:06 -0400184 /* Check for an empty list before locking. */
185 if (list_empty(&orangefs_request_list))
186 return -EAGAIN;
187
Al Viroed42fe02016-01-22 19:47:47 -0500188restart:
Martin Brandenburga0ec1de2018-01-22 15:44:52 -0500189 cur_op = NULL;
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500190 /* Get next op (if any) from top of list. */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500191 spin_lock(&orangefs_request_list_lock);
192 list_for_each_entry_safe(op, temp, &orangefs_request_list, list) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500193 __s32 fsid;
194 /* This lock is held past the end of the loop when we break. */
195 spin_lock(&op->lock);
Al Viro05a50a52016-02-18 18:59:44 -0500196 if (unlikely(op_state_purged(op) || op_state_given_up(op))) {
Al Viroed42fe02016-01-22 19:47:47 -0500197 spin_unlock(&op->lock);
198 continue;
199 }
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500200
201 fsid = fsid_of_op(op);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500202 if (fsid != ORANGEFS_FS_ID_NULL) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500203 int ret;
204 /* Skip ops whose filesystem needs to be mounted. */
205 ret = fs_mount_pending(fsid);
206 if (ret == 1) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400207 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall5090c962016-02-04 13:29:27 -0500208 "%s: mount pending, skipping op tag "
209 "%llu %s\n",
210 __func__,
211 llu(op->tag),
212 get_opname_string(op));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500213 spin_unlock(&op->lock);
Mike Marshall5db11c22015-07-17 10:38:12 -0400214 continue;
Mike Marshall97f10022015-12-11 16:45:03 -0500215 /*
216 * Skip ops whose filesystem we don't know about unless
Martin Brandenburg1ec16882017-04-14 14:22:41 -0400217 * it is being mounted or unmounted. It is possible for
218 * a filesystem we don't know about to be unmounted if
219 * it fails to mount in the kernel after userspace has
220 * been sent the mount request.
Mike Marshall97f10022015-12-11 16:45:03 -0500221 */
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500222 /* XXX: is there a better way to detect this? */
223 } else if (ret == -1 &&
Mike Marshall97f10022015-12-11 16:45:03 -0500224 !(op->upcall.type ==
225 ORANGEFS_VFS_OP_FS_MOUNT ||
226 op->upcall.type ==
Martin Brandenburg1ec16882017-04-14 14:22:41 -0400227 ORANGEFS_VFS_OP_GETATTR ||
228 op->upcall.type ==
229 ORANGEFS_VFS_OP_FS_UMOUNT)) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500230 gossip_debug(GOSSIP_DEV_DEBUG,
231 "orangefs: skipping op tag %llu %s\n",
232 llu(op->tag), get_opname_string(op));
233 gossip_err(
234 "orangefs: ERROR: fs_mount_pending %d\n",
235 fsid);
236 spin_unlock(&op->lock);
237 continue;
Mike Marshall5db11c22015-07-17 10:38:12 -0400238 }
239 }
Mike Marshall5db11c22015-07-17 10:38:12 -0400240 /*
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500241 * Either this op does not pertain to a filesystem, is mounting
242 * a filesystem, or pertains to a mounted filesystem. Let it
243 * through.
Mike Marshall5db11c22015-07-17 10:38:12 -0400244 */
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500245 cur_op = op;
246 break;
Mike Marshall5db11c22015-07-17 10:38:12 -0400247 }
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500248
249 /*
250 * At this point we either have a valid op and can continue or have not
251 * found an op and must ask the client to try again later.
252 */
253 if (!cur_op) {
Yi Liu8bb8aef2015-11-24 15:12:14 -0500254 spin_unlock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500255 return -EAGAIN;
256 }
257
Mike Marshallca9f5182016-02-26 10:21:12 -0500258 gossip_debug(GOSSIP_DEV_DEBUG, "%s: reading op tag %llu %s\n",
259 __func__,
260 llu(cur_op->tag),
261 get_opname_string(cur_op));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500262
263 /*
264 * Such an op should never be on the list in the first place. If so, we
265 * will abort.
266 */
267 if (op_state_in_progress(cur_op) || op_state_serviced(cur_op)) {
268 gossip_err("orangefs: ERROR: Current op already queued.\n");
Al Viro05a50a52016-02-18 18:59:44 -0500269 list_del_init(&cur_op->list);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500270 spin_unlock(&cur_op->lock);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500271 spin_unlock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500272 return -EAGAIN;
273 }
Mike Marshallca9f5182016-02-26 10:21:12 -0500274
Al Viroed42fe02016-01-22 19:47:47 -0500275 list_del_init(&cur_op->list);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500276 spin_unlock(&orangefs_request_list_lock);
Al Viroed42fe02016-01-22 19:47:47 -0500277
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500278 spin_unlock(&cur_op->lock);
279
280 /* Push the upcall out. */
281 ret = copy_to_user(buf, &proto_ver, sizeof(__s32));
282 if (ret != 0)
283 goto error;
Mike Marshall95f5f882018-05-11 17:11:48 -0400284 ret = copy_to_user(buf + sizeof(__s32), &magic, sizeof(__s32));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500285 if (ret != 0)
286 goto error;
Mike Marshall95f5f882018-05-11 17:11:48 -0400287 ret = copy_to_user(buf + 2 * sizeof(__s32),
288 &cur_op->tag,
289 sizeof(__u64));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500290 if (ret != 0)
291 goto error;
Mike Marshall95f5f882018-05-11 17:11:48 -0400292 ret = copy_to_user(buf + 2 * sizeof(__s32) + sizeof(__u64),
293 &cur_op->upcall,
294 sizeof(struct orangefs_upcall_s));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500295 if (ret != 0)
296 goto error;
297
Martin Brandenburg1d503612016-08-16 11:38:14 -0400298 spin_lock(&orangefs_htable_ops_in_progress_lock);
Al Viroed42fe02016-01-22 19:47:47 -0500299 spin_lock(&cur_op->lock);
300 if (unlikely(op_state_given_up(cur_op))) {
301 spin_unlock(&cur_op->lock);
Martin Brandenburg1d503612016-08-16 11:38:14 -0400302 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Al Viro05a50a52016-02-18 18:59:44 -0500303 complete(&cur_op->waitq);
Al Viroed42fe02016-01-22 19:47:47 -0500304 goto restart;
305 }
306
307 /*
308 * Set the operation to be in progress and move it between lists since
309 * it has been sent to the client.
310 */
311 set_op_state_inprogress(cur_op);
Mike Marshall9d9e7ba2016-03-03 13:46:48 -0500312 gossip_debug(GOSSIP_DEV_DEBUG,
313 "%s: 1 op:%s: op_state:%d: process:%s:\n",
314 __func__,
315 get_opname_string(cur_op),
316 cur_op->op_state,
317 current->comm);
Al Viroed42fe02016-01-22 19:47:47 -0500318 orangefs_devreq_add_op(cur_op);
319 spin_unlock(&cur_op->lock);
Martin Brandenburg1d503612016-08-16 11:38:14 -0400320 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Al Viroed42fe02016-01-22 19:47:47 -0500321
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500322 /* The client only asks to read one size buffer. */
Martin Brandenburga762ae62015-12-15 14:22:06 -0500323 return MAX_DEV_REQ_UPSIZE;
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500324error:
325 /*
326 * We were unable to copy the op data to the client. Put the op back in
327 * list. If client has crashed, the op will be purged later when the
328 * device is released.
329 */
330 gossip_err("orangefs: Failed to copy data to user space\n");
Yi Liu8bb8aef2015-11-24 15:12:14 -0500331 spin_lock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500332 spin_lock(&cur_op->lock);
Al Viroed42fe02016-01-22 19:47:47 -0500333 if (likely(!op_state_given_up(cur_op))) {
334 set_op_state_waiting(cur_op);
Mike Marshall9d9e7ba2016-03-03 13:46:48 -0500335 gossip_debug(GOSSIP_DEV_DEBUG,
336 "%s: 2 op:%s: op_state:%d: process:%s:\n",
337 __func__,
338 get_opname_string(cur_op),
339 cur_op->op_state,
340 current->comm);
Al Viroed42fe02016-01-22 19:47:47 -0500341 list_add(&cur_op->list, &orangefs_request_list);
Al Viro05a50a52016-02-18 18:59:44 -0500342 spin_unlock(&cur_op->lock);
343 } else {
344 spin_unlock(&cur_op->lock);
345 complete(&cur_op->waitq);
Al Viroed42fe02016-01-22 19:47:47 -0500346 }
Yi Liu8bb8aef2015-11-24 15:12:14 -0500347 spin_unlock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500348 return -EFAULT;
Mike Marshall5db11c22015-07-17 10:38:12 -0400349}
350
Mike Marshall97f10022015-12-11 16:45:03 -0500351/*
Mike Marshallb3ae4752016-01-13 11:18:12 -0500352 * Function for writev() callers into the device.
353 *
354 * Userspace should have written:
355 * - __u32 version
356 * - __u32 magic
357 * - __u64 tag
358 * - struct orangefs_downcall_s
359 * - trailer buffer (in the case of READDIR operations)
Mike Marshall97f10022015-12-11 16:45:03 -0500360 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500361static ssize_t orangefs_devreq_write_iter(struct kiocb *iocb,
Mike Marshall5db11c22015-07-17 10:38:12 -0400362 struct iov_iter *iter)
363{
Mike Marshallb3ae4752016-01-13 11:18:12 -0500364 ssize_t ret;
365 struct orangefs_kernel_op_s *op = NULL;
366 struct {
367 __u32 version;
368 __u32 magic;
369 __u64 tag;
370 } head;
371 int total = ret = iov_iter_count(iter);
Mike Marshallb3ae4752016-01-13 11:18:12 -0500372 int downcall_size = sizeof(struct orangefs_downcall_s);
373 int head_size = sizeof(head);
374
375 gossip_debug(GOSSIP_DEV_DEBUG, "%s: total:%d: ret:%zd:\n",
376 __func__,
377 total,
378 ret);
379
380 if (total < MAX_DEV_REQ_DOWNSIZE) {
Mike Marshallcf0c2772016-01-19 12:04:40 -0500381 gossip_err("%s: total:%d: must be at least:%u:\n",
Mike Marshallb3ae4752016-01-13 11:18:12 -0500382 __func__,
383 total,
Mike Marshallcf0c2772016-01-19 12:04:40 -0500384 (unsigned int) MAX_DEV_REQ_DOWNSIZE);
Al Viroed42fe02016-01-22 19:47:47 -0500385 return -EFAULT;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500386 }
Mike Marshall95f5f882018-05-11 17:11:48 -0400387
Al Virocbbd26b2016-11-01 22:09:04 -0400388 if (!copy_from_iter_full(&head, head_size, iter)) {
Mike Marshallb3ae4752016-01-13 11:18:12 -0500389 gossip_err("%s: failed to copy head.\n", __func__);
Al Viroed42fe02016-01-22 19:47:47 -0500390 return -EFAULT;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500391 }
392
393 if (head.version < ORANGEFS_MINIMUM_USERSPACE_VERSION) {
394 gossip_err("%s: userspace claims version"
395 "%d, minimum version required: %d.\n",
396 __func__,
397 head.version,
398 ORANGEFS_MINIMUM_USERSPACE_VERSION);
Al Viroed42fe02016-01-22 19:47:47 -0500399 return -EPROTO;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500400 }
401
402 if (head.magic != ORANGEFS_DEVREQ_MAGIC) {
403 gossip_err("Error: Device magic number does not match.\n");
Al Viroed42fe02016-01-22 19:47:47 -0500404 return -EPROTO;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500405 }
406
Martin Brandenburg482664d2016-08-12 12:02:31 -0400407 if (!orangefs_userspace_version) {
408 orangefs_userspace_version = head.version;
409 } else if (orangefs_userspace_version != head.version) {
Martin Brandenburgf2ee3b72016-08-09 15:59:26 -0400410 gossip_err("Error: userspace version changes\n");
411 return -EPROTO;
412 }
413
Mike Marshallca9f5182016-02-26 10:21:12 -0500414 /* remove the op from the in progress hash table */
Mike Marshallb3ae4752016-01-13 11:18:12 -0500415 op = orangefs_devreq_remove_op(head.tag);
416 if (!op) {
Mike Marshall05973c22017-02-09 14:38:50 -0500417 gossip_debug(GOSSIP_DEV_DEBUG,
418 "%s: No one's waiting for tag %llu\n",
419 __func__, llu(head.tag));
Al Viroed42fe02016-01-22 19:47:47 -0500420 return ret;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500421 }
422
Al Virocbbd26b2016-11-01 22:09:04 -0400423 if (!copy_from_iter_full(&op->downcall, downcall_size, iter)) {
Mike Marshallb3ae4752016-01-13 11:18:12 -0500424 gossip_err("%s: failed to copy downcall.\n", __func__);
Al Viro5964c1b2016-02-18 18:53:41 -0500425 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500426 }
427
428 if (op->downcall.status)
429 goto wakeup;
430
431 /*
Mike Marshall95f5f882018-05-11 17:11:48 -0400432 * We've successfully peeled off the head and the downcall.
Mike Marshallb3ae4752016-01-13 11:18:12 -0500433 * Something has gone awry if total doesn't equal the
434 * sum of head_size, downcall_size and trailer_size.
435 */
436 if ((head_size + downcall_size + op->downcall.trailer_size) != total) {
437 gossip_err("%s: funky write, head_size:%d"
438 ": downcall_size:%d: trailer_size:%lld"
439 ": total size:%d:\n",
440 __func__,
441 head_size,
442 downcall_size,
443 op->downcall.trailer_size,
444 total);
Al Viro5964c1b2016-02-18 18:53:41 -0500445 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500446 }
447
448 /* Only READDIR operations should have trailers. */
449 if ((op->downcall.type != ORANGEFS_VFS_OP_READDIR) &&
450 (op->downcall.trailer_size != 0)) {
451 gossip_err("%s: %x operation with trailer.",
452 __func__,
453 op->downcall.type);
Al Viro5964c1b2016-02-18 18:53:41 -0500454 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500455 }
456
457 /* READDIR operations should always have trailers. */
458 if ((op->downcall.type == ORANGEFS_VFS_OP_READDIR) &&
459 (op->downcall.trailer_size == 0)) {
460 gossip_err("%s: %x operation with no trailer.",
461 __func__,
462 op->downcall.type);
Al Viro5964c1b2016-02-18 18:53:41 -0500463 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500464 }
465
466 if (op->downcall.type != ORANGEFS_VFS_OP_READDIR)
467 goto wakeup;
468
Colin Ian King81e3d022018-01-26 19:42:47 +0000469 op->downcall.trailer_buf = vzalloc(op->downcall.trailer_size);
Markus Elfring07a25852017-08-17 21:00:07 +0200470 if (!op->downcall.trailer_buf)
Al Viro5964c1b2016-02-18 18:53:41 -0500471 goto Enomem;
Markus Elfring07a25852017-08-17 21:00:07 +0200472
Al Virocbbd26b2016-11-01 22:09:04 -0400473 if (!copy_from_iter_full(op->downcall.trailer_buf,
474 op->downcall.trailer_size, iter)) {
Mike Marshallb3ae4752016-01-13 11:18:12 -0500475 gossip_err("%s: failed to copy trailer.\n", __func__);
476 vfree(op->downcall.trailer_buf);
Al Viro5964c1b2016-02-18 18:53:41 -0500477 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500478 }
479
480wakeup:
Al Viro2a9e5c22016-01-23 13:45:46 -0500481 /*
Mike Marshall9f08cfe2016-02-26 14:39:08 -0500482 * Return to vfs waitqueue, and back to service_operation
Mike Marshall95f5f882018-05-11 17:11:48 -0400483 * through wait_for_matching_downcall.
Al Viro2a9e5c22016-01-23 13:45:46 -0500484 */
485 spin_lock(&op->lock);
Al Viro5964c1b2016-02-18 18:53:41 -0500486 if (unlikely(op_is_cancel(op))) {
Al Viro2a9e5c22016-01-23 13:45:46 -0500487 spin_unlock(&op->lock);
Al Viro78699e22016-02-11 23:07:19 -0500488 put_cancel(op);
Al Viro5964c1b2016-02-18 18:53:41 -0500489 } else if (unlikely(op_state_given_up(op))) {
490 spin_unlock(&op->lock);
Al Viro05a50a52016-02-18 18:59:44 -0500491 complete(&op->waitq);
Al Viro5964c1b2016-02-18 18:53:41 -0500492 } else {
493 set_op_state_serviced(op);
Mike Marshall9d9e7ba2016-03-03 13:46:48 -0500494 gossip_debug(GOSSIP_DEV_DEBUG,
495 "%s: op:%s: op_state:%d: process:%s:\n",
496 __func__,
497 get_opname_string(op),
498 op->op_state,
499 current->comm);
Al Viro5964c1b2016-02-18 18:53:41 -0500500 spin_unlock(&op->lock);
501 }
Mike Marshallb3ae4752016-01-13 11:18:12 -0500502 return ret;
Al Viroed42fe02016-01-22 19:47:47 -0500503
Al Viro5964c1b2016-02-18 18:53:41 -0500504Efault:
505 op->downcall.status = -(ORANGEFS_ERROR_BIT | 9);
506 ret = -EFAULT;
507 goto wakeup;
508
509Enomem:
510 op->downcall.status = -(ORANGEFS_ERROR_BIT | 8);
511 ret = -ENOMEM;
512 goto wakeup;
Mike Marshall5db11c22015-07-17 10:38:12 -0400513}
514
Mike Marshall5db11c22015-07-17 10:38:12 -0400515/*
516 * NOTE: gets called when the last reference to this device is dropped.
517 * Using the open_access_count variable, we enforce a reference count
518 * on this file so that it can be opened by only one process at a time.
519 * the devreq_mutex is used to make sure all i/o has completed
Yi Liu8bb8aef2015-11-24 15:12:14 -0500520 * before we call orangefs_bufmap_finalize, and similar such tricky
Mike Marshall5db11c22015-07-17 10:38:12 -0400521 * situations
522 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500523static int orangefs_devreq_release(struct inode *inode, struct file *file)
Mike Marshall5db11c22015-07-17 10:38:12 -0400524{
525 int unmounted = 0;
526
527 gossip_debug(GOSSIP_DEV_DEBUG,
528 "%s:pvfs2-client-core: exiting, closing device\n",
529 __func__);
530
531 mutex_lock(&devreq_mutex);
Al Viroea2c9c92016-02-13 21:01:21 -0500532 orangefs_bufmap_finalize();
Mike Marshall5db11c22015-07-17 10:38:12 -0400533
Al Virofee25ce2016-01-22 19:46:08 -0500534 open_access_count = -1;
Mike Marshall5db11c22015-07-17 10:38:12 -0400535
536 unmounted = mark_all_pending_mounts();
Yi Liu8bb8aef2015-11-24 15:12:14 -0500537 gossip_debug(GOSSIP_DEV_DEBUG, "ORANGEFS Device Close: Filesystem(s) %s\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400538 (unmounted ? "UNMOUNTED" : "MOUNTED"));
Mike Marshall5db11c22015-07-17 10:38:12 -0400539
Mike Marshall5db11c22015-07-17 10:38:12 -0400540 purge_waiting_ops();
Mike Marshall5db11c22015-07-17 10:38:12 -0400541 purge_inprogress_ops();
Al Viroea2c9c92016-02-13 21:01:21 -0500542
543 orangefs_bufmap_run_down();
544
Mike Marshall5db11c22015-07-17 10:38:12 -0400545 gossip_debug(GOSSIP_DEV_DEBUG,
546 "pvfs2-client-core: device close complete\n");
Al Virofee25ce2016-01-22 19:46:08 -0500547 open_access_count = 0;
Martin Brandenburg482664d2016-08-12 12:02:31 -0400548 orangefs_userspace_version = 0;
Al Virofee25ce2016-01-22 19:46:08 -0500549 mutex_unlock(&devreq_mutex);
Mike Marshall5db11c22015-07-17 10:38:12 -0400550 return 0;
551}
552
553int is_daemon_in_service(void)
554{
555 int in_service;
556
557 /*
558 * What this function does is checks if client-core is alive
559 * based on the access count we maintain on the device.
560 */
561 mutex_lock(&devreq_mutex);
562 in_service = open_access_count == 1 ? 0 : -EIO;
563 mutex_unlock(&devreq_mutex);
564 return in_service;
565}
566
Al Viro78699e22016-02-11 23:07:19 -0500567bool __is_daemon_in_service(void)
568{
569 return open_access_count == 1;
570}
571
Mike Marshall5db11c22015-07-17 10:38:12 -0400572static inline long check_ioctl_command(unsigned int command)
573{
574 /* Check for valid ioctl codes */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500575 if (_IOC_TYPE(command) != ORANGEFS_DEV_MAGIC) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400576 gossip_err("device ioctl magic numbers don't match! Did you rebuild pvfs2-client-core/libpvfs2? [cmd %x, magic %x != %x]\n",
577 command,
578 _IOC_TYPE(command),
Yi Liu8bb8aef2015-11-24 15:12:14 -0500579 ORANGEFS_DEV_MAGIC);
Mike Marshall5db11c22015-07-17 10:38:12 -0400580 return -EINVAL;
581 }
582 /* and valid ioctl commands */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500583 if (_IOC_NR(command) >= ORANGEFS_DEV_MAXNR || _IOC_NR(command) <= 0) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400584 gossip_err("Invalid ioctl command number [%d >= %d]\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500585 _IOC_NR(command), ORANGEFS_DEV_MAXNR);
Mike Marshall5db11c22015-07-17 10:38:12 -0400586 return -ENOIOCTLCMD;
587 }
588 return 0;
589}
590
591static long dispatch_ioctl_command(unsigned int command, unsigned long arg)
592{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500593 static __s32 magic = ORANGEFS_DEVREQ_MAGIC;
Martin Brandenburga762ae62015-12-15 14:22:06 -0500594 static __s32 max_up_size = MAX_DEV_REQ_UPSIZE;
595 static __s32 max_down_size = MAX_DEV_REQ_DOWNSIZE;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500596 struct ORANGEFS_dev_map_desc user_desc;
Mike Marshall5db11c22015-07-17 10:38:12 -0400597 int ret = 0;
Mike Marshall5db11c22015-07-17 10:38:12 -0400598 int upstream_kmod = 1;
Al Viro45996492016-03-25 19:56:34 -0400599 struct orangefs_sb_info_s *orangefs_sb;
Mike Marshall5db11c22015-07-17 10:38:12 -0400600
601 /* mtmoore: add locking here */
602
603 switch (command) {
Yi Liu8bb8aef2015-11-24 15:12:14 -0500604 case ORANGEFS_DEV_GET_MAGIC:
Mike Marshall5db11c22015-07-17 10:38:12 -0400605 return ((put_user(magic, (__s32 __user *) arg) == -EFAULT) ?
606 -EIO :
607 0);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500608 case ORANGEFS_DEV_GET_MAX_UPSIZE:
Mike Marshall5db11c22015-07-17 10:38:12 -0400609 return ((put_user(max_up_size,
610 (__s32 __user *) arg) == -EFAULT) ?
611 -EIO :
612 0);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500613 case ORANGEFS_DEV_GET_MAX_DOWNSIZE:
Mike Marshall5db11c22015-07-17 10:38:12 -0400614 return ((put_user(max_down_size,
615 (__s32 __user *) arg) == -EFAULT) ?
616 -EIO :
617 0);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500618 case ORANGEFS_DEV_MAP:
Mike Marshall5db11c22015-07-17 10:38:12 -0400619 ret = copy_from_user(&user_desc,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500620 (struct ORANGEFS_dev_map_desc __user *)
Mike Marshall5db11c22015-07-17 10:38:12 -0400621 arg,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500622 sizeof(struct ORANGEFS_dev_map_desc));
Al Viroea2c9c92016-02-13 21:01:21 -0500623 /* WTF -EIO and not -EFAULT? */
624 return ret ? -EIO : orangefs_bufmap_initialize(&user_desc);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500625 case ORANGEFS_DEV_REMOUNT_ALL:
Mike Marshall5db11c22015-07-17 10:38:12 -0400626 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall97f10022015-12-11 16:45:03 -0500627 "%s: got ORANGEFS_DEV_REMOUNT_ALL\n",
628 __func__);
Mike Marshall5db11c22015-07-17 10:38:12 -0400629
630 /*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500631 * remount all mounted orangefs volumes to regain the lost
Mike Marshall5db11c22015-07-17 10:38:12 -0400632 * dynamic mount tables (if any) -- NOTE: this is done
633 * without keeping the superblock list locked due to the
Mike Marshalladcf34a2016-02-24 16:54:27 -0500634 * upcall/downcall waiting. also, the request mutex is
Mike Marshall5db11c22015-07-17 10:38:12 -0400635 * used to ensure that no operations will be serviced until
636 * all of the remounts are serviced (to avoid ops between
637 * mounts to fail)
638 */
Martin Brandenburg1d503612016-08-16 11:38:14 -0400639 ret = mutex_lock_interruptible(&orangefs_request_mutex);
Mike Marshall5db11c22015-07-17 10:38:12 -0400640 if (ret < 0)
641 return ret;
642 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall97f10022015-12-11 16:45:03 -0500643 "%s: priority remount in progress\n",
644 __func__);
Al Viro45996492016-03-25 19:56:34 -0400645 spin_lock(&orangefs_superblocks_lock);
646 list_for_each_entry(orangefs_sb, &orangefs_superblocks, list) {
647 /*
648 * We have to drop the spinlock, so entries can be
649 * removed. They can't be freed, though, so we just
650 * keep the forward pointers and zero the back ones -
651 * that way we can get to the rest of the list.
652 */
653 if (!orangefs_sb->list.prev)
654 continue;
655 gossip_debug(GOSSIP_DEV_DEBUG,
656 "%s: Remounting SB %p\n",
657 __func__,
658 orangefs_sb);
Mike Marshall5db11c22015-07-17 10:38:12 -0400659
Al Viro45996492016-03-25 19:56:34 -0400660 spin_unlock(&orangefs_superblocks_lock);
661 ret = orangefs_remount(orangefs_sb);
662 spin_lock(&orangefs_superblocks_lock);
663 if (ret) {
664 gossip_debug(GOSSIP_DEV_DEBUG,
665 "SB %p remount failed\n",
666 orangefs_sb);
667 break;
Mike Marshall5db11c22015-07-17 10:38:12 -0400668 }
669 }
Al Viro45996492016-03-25 19:56:34 -0400670 spin_unlock(&orangefs_superblocks_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -0400671 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall97f10022015-12-11 16:45:03 -0500672 "%s: priority remount complete\n",
673 __func__);
Martin Brandenburg1d503612016-08-16 11:38:14 -0400674 mutex_unlock(&orangefs_request_mutex);
Mike Marshall5db11c22015-07-17 10:38:12 -0400675 return ret;
676
Yi Liu8bb8aef2015-11-24 15:12:14 -0500677 case ORANGEFS_DEV_UPSTREAM:
Mike Marshall5db11c22015-07-17 10:38:12 -0400678 ret = copy_to_user((void __user *)arg,
679 &upstream_kmod,
680 sizeof(upstream_kmod));
681
682 if (ret != 0)
683 return -EIO;
684 else
685 return ret;
686
Yi Liu8bb8aef2015-11-24 15:12:14 -0500687 case ORANGEFS_DEV_CLIENT_MASK:
Martin Brandenburg44f46412016-08-15 11:38:36 -0400688 return orangefs_debugfs_new_client_mask((void __user *)arg);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500689 case ORANGEFS_DEV_CLIENT_STRING:
Martin Brandenburg44f46412016-08-15 11:38:36 -0400690 return orangefs_debugfs_new_client_string((void __user *)arg);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500691 case ORANGEFS_DEV_DEBUG:
Martin Brandenburg44f46412016-08-15 11:38:36 -0400692 return orangefs_debugfs_new_debug((void __user *)arg);
Mike Marshall5db11c22015-07-17 10:38:12 -0400693 default:
694 return -ENOIOCTLCMD;
695 }
696 return -ENOIOCTLCMD;
697}
698
Yi Liu8bb8aef2015-11-24 15:12:14 -0500699static long orangefs_devreq_ioctl(struct file *file,
Mike Marshall5db11c22015-07-17 10:38:12 -0400700 unsigned int command, unsigned long arg)
701{
702 long ret;
703
704 /* Check for properly constructed commands */
705 ret = check_ioctl_command(command);
706 if (ret < 0)
707 return (int)ret;
708
709 return (int)dispatch_ioctl_command(command, arg);
710}
711
712#ifdef CONFIG_COMPAT /* CONFIG_COMPAT is in .config */
713
Yi Liu8bb8aef2015-11-24 15:12:14 -0500714/* Compat structure for the ORANGEFS_DEV_MAP ioctl */
715struct ORANGEFS_dev_map_desc32 {
Mike Marshall5db11c22015-07-17 10:38:12 -0400716 compat_uptr_t ptr;
717 __s32 total_size;
718 __s32 size;
719 __s32 count;
720};
721
Mike Marshall5db11c22015-07-17 10:38:12 -0400722/*
723 * 32 bit user-space apps' ioctl handlers when kernel modules
724 * is compiled as a 64 bit one
725 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500726static long orangefs_devreq_compat_ioctl(struct file *filp, unsigned int cmd,
Mike Marshall5db11c22015-07-17 10:38:12 -0400727 unsigned long args)
728{
729 long ret;
Mike Marshall5db11c22015-07-17 10:38:12 -0400730
731 /* Check for properly constructed commands */
732 ret = check_ioctl_command(cmd);
733 if (ret < 0)
734 return ret;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500735 if (cmd == ORANGEFS_DEV_MAP) {
Al Viro430ff792018-05-27 08:52:48 -0400736 struct ORANGEFS_dev_map_desc desc;
737 struct ORANGEFS_dev_map_desc32 d32;
738
739 if (copy_from_user(&d32, (void __user *)args, sizeof(d32)))
740 return -EFAULT;
741
742 desc.ptr = compat_ptr(d32.ptr);
743 desc.total_size = d32.total_size;
744 desc.size = d32.size;
745 desc.count = d32.count;
746 return orangefs_bufmap_initialize(&desc);
Mike Marshall5db11c22015-07-17 10:38:12 -0400747 }
748 /* no other ioctl requires translation */
Al Viro430ff792018-05-27 08:52:48 -0400749 return dispatch_ioctl_command(cmd, args);
Mike Marshall5db11c22015-07-17 10:38:12 -0400750}
751
Mike Marshall2c590d52015-07-24 10:37:15 -0400752#endif /* CONFIG_COMPAT is in .config */
753
Martin Brandenburgbdd6f082018-04-03 16:27:13 +0000754static __poll_t orangefs_devreq_poll(struct file *file,
755 struct poll_table_struct *poll_table)
756{
757 __poll_t poll_revent_mask = 0;
758
759 poll_wait(file, &orangefs_request_list_waitq, poll_table);
760
761 if (!list_empty(&orangefs_request_list))
762 poll_revent_mask |= EPOLLIN;
763 return poll_revent_mask;
764}
765
Mike Marshall5db11c22015-07-17 10:38:12 -0400766/* the assigned character device major number */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500767static int orangefs_dev_major;
Mike Marshall5db11c22015-07-17 10:38:12 -0400768
Martin Brandenburgbdd6f082018-04-03 16:27:13 +0000769static const struct file_operations orangefs_devreq_file_operations = {
770 .owner = THIS_MODULE,
771 .read = orangefs_devreq_read,
772 .write_iter = orangefs_devreq_write_iter,
773 .open = orangefs_devreq_open,
774 .release = orangefs_devreq_release,
775 .unlocked_ioctl = orangefs_devreq_ioctl,
776
777#ifdef CONFIG_COMPAT /* CONFIG_COMPAT is in .config */
778 .compat_ioctl = orangefs_devreq_compat_ioctl,
779#endif
780 .poll = orangefs_devreq_poll
781};
782
Mike Marshall5db11c22015-07-17 10:38:12 -0400783/*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500784 * Initialize orangefs device specific state:
Mike Marshall5db11c22015-07-17 10:38:12 -0400785 * Must be called at module load time only
786 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500787int orangefs_dev_init(void)
Mike Marshall5db11c22015-07-17 10:38:12 -0400788{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500789 /* register orangefs-req device */
790 orangefs_dev_major = register_chrdev(0,
791 ORANGEFS_REQDEVICE_NAME,
792 &orangefs_devreq_file_operations);
793 if (orangefs_dev_major < 0) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400794 gossip_debug(GOSSIP_DEV_DEBUG,
795 "Failed to register /dev/%s (error %d)\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500796 ORANGEFS_REQDEVICE_NAME, orangefs_dev_major);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500797 return orangefs_dev_major;
Mike Marshall5db11c22015-07-17 10:38:12 -0400798 }
799
800 gossip_debug(GOSSIP_DEV_DEBUG,
801 "*** /dev/%s character device registered ***\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500802 ORANGEFS_REQDEVICE_NAME);
Mike Marshall5db11c22015-07-17 10:38:12 -0400803 gossip_debug(GOSSIP_DEV_DEBUG, "'mknod /dev/%s c %d 0'.\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500804 ORANGEFS_REQDEVICE_NAME, orangefs_dev_major);
Mike Marshall5db11c22015-07-17 10:38:12 -0400805 return 0;
806}
807
Yi Liu8bb8aef2015-11-24 15:12:14 -0500808void orangefs_dev_cleanup(void)
Mike Marshall5db11c22015-07-17 10:38:12 -0400809{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500810 unregister_chrdev(orangefs_dev_major, ORANGEFS_REQDEVICE_NAME);
Mike Marshall5db11c22015-07-17 10:38:12 -0400811 gossip_debug(GOSSIP_DEV_DEBUG,
812 "*** /dev/%s character device unregistered ***\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500813 ORANGEFS_REQDEVICE_NAME);
Mike Marshall5db11c22015-07-17 10:38:12 -0400814}