blob: ca05ba217f5fd4038bcc511adff8a5b95823fb3e [file] [log] [blame]
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001#!/usr/bin/perl -w
Dave Jonesdbf004d2010-01-12 16:59:52 -05002# (c) 2001, Dave Jones. (the file handling bit)
Andy Whitcroft00df3442007-06-08 13:47:06 -07003# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
Andy Whitcroft2a5a2c22009-01-06 14:41:23 -08004# (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
Andy Whitcroft015830b2010-10-26 14:23:17 -07005# (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
Andy Whitcroft0a920b52007-06-01 00:46:48 -07006# Licensed under the terms of the GNU GPL License version 2
7
8use strict;
9
10my $P = $0;
Andy Whitcroft00df3442007-06-08 13:47:06 -070011$P =~ s@.*/@@g;
Andy Whitcroft0a920b52007-06-01 00:46:48 -070012
Joe Perches000d1cc12011-07-25 17:13:25 -070013my $V = '0.32';
Andy Whitcroft0a920b52007-06-01 00:46:48 -070014
15use Getopt::Long qw(:config no_auto_abbrev);
16
17my $quiet = 0;
18my $tree = 1;
19my $chk_signoff = 1;
20my $chk_patch = 1;
Andy Whitcroft773647a2008-03-28 14:15:58 -070021my $tst_only;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070022my $emacs = 0;
Andy Whitcroft8905a672007-11-28 16:21:06 -080023my $terse = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070024my $file = 0;
25my $check = 0;
Andy Whitcroft8905a672007-11-28 16:21:06 -080026my $summary = 1;
27my $mailback = 0;
Andy Whitcroft13214ad2008-02-08 04:22:03 -080028my $summary_file = 0;
Joe Perches000d1cc12011-07-25 17:13:25 -070029my $show_types = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070030my $root;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -080031my %debug;
Joe Perches000d1cc12011-07-25 17:13:25 -070032my %ignore_type = ();
33my @ignore = ();
Hannes Eder77f5b102009-09-21 17:04:37 -070034my $help = 0;
Joe Perches000d1cc12011-07-25 17:13:25 -070035my $configuration_file = ".checkpatch.conf";
Hannes Eder77f5b102009-09-21 17:04:37 -070036
37sub help {
38 my ($exitcode) = @_;
39
40 print << "EOM";
41Usage: $P [OPTION]... [FILE]...
42Version: $V
43
44Options:
45 -q, --quiet quiet
46 --no-tree run without a kernel tree
47 --no-signoff do not check for 'Signed-off-by' line
48 --patch treat FILE as patchfile (default)
49 --emacs emacs compile window format
50 --terse one line per report
51 -f, --file treat FILE as regular source file
52 --subjective, --strict enable more subjective tests
Joe Perches000d1cc12011-07-25 17:13:25 -070053 --ignore TYPE(,TYPE2...) ignore various comma separated message types
54 --show-types show the message "types" in the output
Hannes Eder77f5b102009-09-21 17:04:37 -070055 --root=PATH PATH to the kernel tree root
56 --no-summary suppress the per-file summary
57 --mailback only produce a report in case of warnings/errors
58 --summary-file include the filename in summary
59 --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of
60 'values', 'possible', 'type', and 'attr' (default
61 is all off)
62 --test-only=WORD report only warnings/errors containing WORD
63 literally
64 -h, --help, --version display this help and exit
65
66When FILE is - read standard input.
67EOM
68
69 exit($exitcode);
70}
71
Joe Perches000d1cc12011-07-25 17:13:25 -070072my $conf = which_conf($configuration_file);
73if (-f $conf) {
74 my @conf_args;
75 open(my $conffile, '<', "$conf")
76 or warn "$P: Can't find a readable $configuration_file file $!\n";
77
78 while (<$conffile>) {
79 my $line = $_;
80
81 $line =~ s/\s*\n?$//g;
82 $line =~ s/^\s*//g;
83 $line =~ s/\s+/ /g;
84
85 next if ($line =~ m/^\s*#/);
86 next if ($line =~ m/^\s*$/);
87
88 my @words = split(" ", $line);
89 foreach my $word (@words) {
90 last if ($word =~ m/^#/);
91 push (@conf_args, $word);
92 }
93 }
94 close($conffile);
95 unshift(@ARGV, @conf_args) if @conf_args;
96}
97
Andy Whitcroft0a920b52007-06-01 00:46:48 -070098GetOptions(
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -070099 'q|quiet+' => \$quiet,
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700100 'tree!' => \$tree,
101 'signoff!' => \$chk_signoff,
102 'patch!' => \$chk_patch,
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700103 'emacs!' => \$emacs,
Andy Whitcroft8905a672007-11-28 16:21:06 -0800104 'terse!' => \$terse,
Hannes Eder77f5b102009-09-21 17:04:37 -0700105 'f|file!' => \$file,
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700106 'subjective!' => \$check,
107 'strict!' => \$check,
Joe Perches000d1cc12011-07-25 17:13:25 -0700108 'ignore=s' => \@ignore,
109 'show-types!' => \$show_types,
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700110 'root=s' => \$root,
Andy Whitcroft8905a672007-11-28 16:21:06 -0800111 'summary!' => \$summary,
112 'mailback!' => \$mailback,
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800113 'summary-file!' => \$summary_file,
114
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800115 'debug=s' => \%debug,
Andy Whitcroft773647a2008-03-28 14:15:58 -0700116 'test-only=s' => \$tst_only,
Hannes Eder77f5b102009-09-21 17:04:37 -0700117 'h|help' => \$help,
118 'version' => \$help
119) or help(1);
120
121help(0) if ($help);
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700122
123my $exit = 0;
124
125if ($#ARGV < 0) {
Hannes Eder77f5b102009-09-21 17:04:37 -0700126 print "$P: no input files\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700127 exit(1);
128}
129
Joe Perches000d1cc12011-07-25 17:13:25 -0700130@ignore = split(/,/, join(',',@ignore));
131foreach my $word (@ignore) {
132 $word =~ s/\s*\n?$//g;
133 $word =~ s/^\s*//g;
134 $word =~ s/\s+/ /g;
135 $word =~ tr/[a-z]/[A-Z]/;
136
137 next if ($word =~ m/^\s*#/);
138 next if ($word =~ m/^\s*$/);
139
140 $ignore_type{$word}++;
141}
142
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800143my $dbg_values = 0;
144my $dbg_possible = 0;
Andy Whitcroft7429c692008-07-23 21:29:06 -0700145my $dbg_type = 0;
Andy Whitcrofta1ef2772008-10-15 22:02:17 -0700146my $dbg_attr = 0;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800147for my $key (keys %debug) {
Andy Whitcroft21caa132009-01-06 14:41:30 -0800148 ## no critic
149 eval "\${dbg_$key} = '$debug{$key}';";
150 die "$@" if ($@);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800151}
152
Andy Whitcroftd2c0a232010-10-26 14:23:12 -0700153my $rpt_cleaners = 0;
154
Andy Whitcroft8905a672007-11-28 16:21:06 -0800155if ($terse) {
156 $emacs = 1;
157 $quiet++;
158}
159
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700160if ($tree) {
161 if (defined $root) {
162 if (!top_of_kernel_tree($root)) {
163 die "$P: $root: --root does not point at a valid tree\n";
164 }
165 } else {
166 if (top_of_kernel_tree('.')) {
167 $root = '.';
168 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
169 top_of_kernel_tree($1)) {
170 $root = $1;
171 }
172 }
173
174 if (!defined $root) {
175 print "Must be run from the top-level dir. of a kernel tree\n";
176 exit(2);
177 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700178}
179
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700180my $emitted_corrupt = 0;
181
Andy Whitcroft2ceb5322009-10-26 16:50:14 -0700182our $Ident = qr{
183 [A-Za-z_][A-Za-z\d_]*
184 (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
185 }x;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700186our $Storage = qr{extern|static|asmlinkage};
187our $Sparse = qr{
188 __user|
189 __kernel|
190 __force|
191 __iomem|
192 __must_check|
193 __init_refok|
Andy Whitcroft417495e2009-02-27 14:03:08 -0800194 __kprobes|
Sven Eckelmann165e72a2011-07-25 17:13:23 -0700195 __ref|
196 __rcu
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700197 }x;
Wolfram Sang52131292010-03-05 13:43:51 -0800198
199# Notes to $Attribute:
200# We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700201our $Attribute = qr{
202 const|
Joe Perches03f1df72010-10-26 14:23:16 -0700203 __percpu|
204 __nocast|
205 __safe|
206 __bitwise__|
207 __packed__|
208 __packed2__|
209 __naked|
210 __maybe_unused|
211 __always_unused|
212 __noreturn|
213 __used|
214 __cold|
215 __noclone|
216 __deprecated|
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700217 __read_mostly|
218 __kprobes|
Wolfram Sang52131292010-03-05 13:43:51 -0800219 __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
Andy Whitcroft24e1d812008-10-15 22:02:18 -0700220 ____cacheline_aligned|
221 ____cacheline_aligned_in_smp|
Andy Whitcroft5fe3af12009-01-06 14:41:18 -0800222 ____cacheline_internodealigned_in_smp|
223 __weak
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700224 }x;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700225our $Modifier;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700226our $Inline = qr{inline|__always_inline|noinline};
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700227our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
228our $Lval = qr{$Ident(?:$Member)*};
229
Joe Perchesd7c76ba2012-01-10 15:09:58 -0800230our $Constant = qr{(?i:(?:[0-9]+|0x[0-9a-f]+)[ul]*)};
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700231our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
Andy Whitcroft86f9d052009-01-06 14:41:24 -0800232our $Compare = qr{<=|>=|==|!=|<|>};
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700233our $Operators = qr{
234 <=|>=|==|!=|
235 =>|->|<<|>>|<|>|!|~|
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800236 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700237 }x;
238
Andy Whitcroft8905a672007-11-28 16:21:06 -0800239our $NonptrType;
240our $Type;
241our $Declare;
242
Joe Perches15662b32011-10-31 17:13:12 -0700243our $NON_ASCII_UTF8 = qr{
244 [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
Andy Whitcroft171ae1a2008-04-29 00:59:32 -0700245 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
246 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
247 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
248 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
249 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
250 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
251}x;
252
Joe Perches15662b32011-10-31 17:13:12 -0700253our $UTF8 = qr{
254 [\x09\x0A\x0D\x20-\x7E] # ASCII
255 | $NON_ASCII_UTF8
256}x;
257
Andy Whitcroft8ed22ca2008-10-15 22:02:32 -0700258our $typeTypedefs = qr{(?x:
Andy Whitcroftfb9e9092009-09-21 17:04:38 -0700259 (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
Andy Whitcroft8ed22ca2008-10-15 22:02:32 -0700260 atomic_t
261)};
262
Joe Perches691e6692010-03-05 13:43:51 -0800263our $logFunctions = qr{(?x:
Joe Perches6e60c022011-07-25 17:13:27 -0700264 printk(?:_ratelimited|_once|)|
265 [a-z0-9]+_(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
266 WARN(?:_RATELIMIT|_ONCE|)|
Joe Perchesb0531722011-05-24 17:13:40 -0700267 panic|
268 MODULE_[A-Z_]+
Joe Perches691e6692010-03-05 13:43:51 -0800269)};
270
Joe Perches20112472011-07-25 17:13:23 -0700271our $signature_tags = qr{(?xi:
272 Signed-off-by:|
273 Acked-by:|
274 Tested-by:|
275 Reviewed-by:|
276 Reported-by:|
277 To:|
278 Cc:
279)};
280
Andy Whitcroft8905a672007-11-28 16:21:06 -0800281our @typeList = (
282 qr{void},
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700283 qr{(?:unsigned\s+)?char},
284 qr{(?:unsigned\s+)?short},
285 qr{(?:unsigned\s+)?int},
286 qr{(?:unsigned\s+)?long},
287 qr{(?:unsigned\s+)?long\s+int},
288 qr{(?:unsigned\s+)?long\s+long},
289 qr{(?:unsigned\s+)?long\s+long\s+int},
Andy Whitcroft8905a672007-11-28 16:21:06 -0800290 qr{unsigned},
291 qr{float},
292 qr{double},
293 qr{bool},
Andy Whitcroft8905a672007-11-28 16:21:06 -0800294 qr{struct\s+$Ident},
295 qr{union\s+$Ident},
296 qr{enum\s+$Ident},
297 qr{${Ident}_t},
298 qr{${Ident}_handler},
299 qr{${Ident}_handler_fn},
300);
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700301our @modifierList = (
302 qr{fastcall},
303);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800304
Wolfram Sang7840a942010-08-09 17:20:57 -0700305our $allowed_asm_includes = qr{(?x:
306 irq|
307 memory
308)};
309# memory.h: ARM has a custom one
310
Andy Whitcroft8905a672007-11-28 16:21:06 -0800311sub build_types {
Andy Whitcroftd2172eb2008-07-23 21:29:07 -0700312 my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
313 my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700314 $Modifier = qr{(?:$Attribute|$Sparse|$mods)};
Andy Whitcroft8905a672007-11-28 16:21:06 -0800315 $NonptrType = qr{
Andy Whitcroftd2172eb2008-07-23 21:29:07 -0700316 (?:$Modifier\s+|const\s+)*
Andy Whitcroftcf655042008-03-04 14:28:20 -0800317 (?:
Andy Whitcroft6b48db22012-01-10 15:10:13 -0800318 (?:typeof|__typeof__)\s*\([^\)]*\)|
Andy Whitcroft8ed22ca2008-10-15 22:02:32 -0700319 (?:$typeTypedefs\b)|
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700320 (?:${all}\b)
Andy Whitcroftcf655042008-03-04 14:28:20 -0800321 )
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700322 (?:\s+$Modifier|\s+const)*
Andy Whitcroft8905a672007-11-28 16:21:06 -0800323 }x;
324 $Type = qr{
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700325 $NonptrType
Andy Whitcroftb337d8b2012-03-23 15:02:18 -0700326 (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*|\[\])+|(?:\s*\[\s*\])+)?
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -0700327 (?:\s+$Inline|\s+$Modifier)*
Andy Whitcroft8905a672007-11-28 16:21:06 -0800328 }x;
329 $Declare = qr{(?:$Storage\s+)?$Type};
330}
331build_types();
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700332
Joe Perches7d2367a2011-07-25 17:13:22 -0700333
334our $Typecast = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
Joe Perchesd1fe9c02012-03-23 15:02:16 -0700335
336# Using $balanced_parens, $LvalOrFunc, or $FuncArg
337# requires at least perl version v5.10.0
338# Any use must be runtime checked with $^V
339
340our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
341our $LvalOrFunc = qr{($Lval)\s*($balanced_parens{0,1})\s*};
Joe Perchesd7c76ba2012-01-10 15:09:58 -0800342our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
Joe Perches7d2367a2011-07-25 17:13:22 -0700343
344sub deparenthesize {
345 my ($string) = @_;
346 return "" if (!defined($string));
347 $string =~ s@^\s*\(\s*@@g;
348 $string =~ s@\s*\)\s*$@@g;
349 $string =~ s@\s+@ @g;
350 return $string;
351}
352
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700353$chk_signoff = 0 if ($file);
354
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700355my @dep_includes = ();
356my @dep_functions = ();
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700357my $removal = "Documentation/feature-removal-schedule.txt";
358if ($tree && -f "$root/$removal") {
Andy Whitcroft21caa132009-01-06 14:41:30 -0800359 open(my $REMOVE, '<', "$root/$removal") ||
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700360 die "$P: $removal: open failed - $!\n";
Andy Whitcroft21caa132009-01-06 14:41:30 -0800361 while (<$REMOVE>) {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700362 if (/^Check:\s+(.*\S)/) {
363 for my $entry (split(/[, ]+/, $1)) {
364 if ($entry =~ m@include/(.*)@) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700365 push(@dep_includes, $1);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700366
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700367 } elsif ($entry !~ m@/@) {
368 push(@dep_functions, $entry);
369 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700370 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700371 }
372 }
Andy Whitcroft21caa132009-01-06 14:41:30 -0800373 close($REMOVE);
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700374}
375
Andy Whitcroft00df3442007-06-08 13:47:06 -0700376my @rawlines = ();
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800377my @lines = ();
378my $vname;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700379for my $filename (@ARGV) {
Andy Whitcroft21caa132009-01-06 14:41:30 -0800380 my $FILE;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700381 if ($file) {
Andy Whitcroft21caa132009-01-06 14:41:30 -0800382 open($FILE, '-|', "diff -u /dev/null $filename") ||
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700383 die "$P: $filename: diff failed - $!\n";
Andy Whitcroft21caa132009-01-06 14:41:30 -0800384 } elsif ($filename eq '-') {
385 open($FILE, '<&STDIN');
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700386 } else {
Andy Whitcroft21caa132009-01-06 14:41:30 -0800387 open($FILE, '<', "$filename") ||
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700388 die "$P: $filename: open failed - $!\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700389 }
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800390 if ($filename eq '-') {
391 $vname = 'Your patch';
392 } else {
393 $vname = $filename;
394 }
Andy Whitcroft21caa132009-01-06 14:41:30 -0800395 while (<$FILE>) {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700396 chomp;
397 push(@rawlines, $_);
398 }
Andy Whitcroft21caa132009-01-06 14:41:30 -0800399 close($FILE);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800400 if (!process($filename)) {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700401 $exit = 1;
402 }
403 @rawlines = ();
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800404 @lines = ();
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700405}
406
407exit($exit);
408
409sub top_of_kernel_tree {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700410 my ($root) = @_;
411
412 my @tree_check = (
413 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
414 "README", "Documentation", "arch", "include", "drivers",
415 "fs", "init", "ipc", "kernel", "lib", "scripts",
416 );
417
418 foreach my $check (@tree_check) {
419 if (! -e $root . '/' . $check) {
420 return 0;
421 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700422 }
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700423 return 1;
Joe Perches000d1cc12011-07-25 17:13:25 -0700424 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700425
Joe Perches20112472011-07-25 17:13:23 -0700426sub parse_email {
427 my ($formatted_email) = @_;
428
429 my $name = "";
430 my $address = "";
431 my $comment = "";
432
433 if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
434 $name = $1;
435 $address = $2;
436 $comment = $3 if defined $3;
437 } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
438 $address = $1;
439 $comment = $2 if defined $2;
440 } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
441 $address = $1;
442 $comment = $2 if defined $2;
443 $formatted_email =~ s/$address.*$//;
444 $name = $formatted_email;
445 $name =~ s/^\s+|\s+$//g;
446 $name =~ s/^\"|\"$//g;
447 # If there's a name left after stripping spaces and
448 # leading quotes, and the address doesn't have both
449 # leading and trailing angle brackets, the address
450 # is invalid. ie:
451 # "joe smith joe@smith.com" bad
452 # "joe smith <joe@smith.com" bad
453 if ($name ne "" && $address !~ /^<[^>]+>$/) {
454 $name = "";
455 $address = "";
456 $comment = "";
457 }
458 }
459
460 $name =~ s/^\s+|\s+$//g;
461 $name =~ s/^\"|\"$//g;
462 $address =~ s/^\s+|\s+$//g;
463 $address =~ s/^\<|\>$//g;
464
465 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
466 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
467 $name = "\"$name\"";
468 }
469
470 return ($name, $address, $comment);
471}
472
473sub format_email {
474 my ($name, $address) = @_;
475
476 my $formatted_email;
477
478 $name =~ s/^\s+|\s+$//g;
479 $name =~ s/^\"|\"$//g;
480 $address =~ s/^\s+|\s+$//g;
481
482 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
483 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
484 $name = "\"$name\"";
485 }
486
487 if ("$name" eq "") {
488 $formatted_email = "$address";
489 } else {
490 $formatted_email = "$name <$address>";
491 }
492
493 return $formatted_email;
494}
495
Joe Perches000d1cc12011-07-25 17:13:25 -0700496sub which_conf {
497 my ($conf) = @_;
498
499 foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
500 if (-e "$path/$conf") {
501 return "$path/$conf";
502 }
503 }
504
505 return "";
506}
507
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700508sub expand_tabs {
509 my ($str) = @_;
510
511 my $res = '';
512 my $n = 0;
513 for my $c (split(//, $str)) {
514 if ($c eq "\t") {
515 $res .= ' ';
516 $n++;
517 for (; ($n % 8) != 0; $n++) {
518 $res .= ' ';
519 }
520 next;
521 }
522 $res .= $c;
523 $n++;
524 }
525
526 return $res;
527}
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700528sub copy_spacing {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700529 (my $res = shift) =~ tr/\t/ /c;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700530 return $res;
531}
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700532
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700533sub line_stats {
534 my ($line) = @_;
535
536 # Drop the diff line leader and expand tabs
537 $line =~ s/^.//;
538 $line = expand_tabs($line);
539
540 # Pick the indent from the front of the line.
541 my ($white) = ($line =~ /^(\s*)/);
542
543 return (length($line), length($white));
544}
545
Andy Whitcroft773647a2008-03-28 14:15:58 -0700546my $sanitise_quote = '';
547
548sub sanitise_line_reset {
549 my ($in_comment) = @_;
550
551 if ($in_comment) {
552 $sanitise_quote = '*/';
553 } else {
554 $sanitise_quote = '';
555 }
556}
Andy Whitcroft00df3442007-06-08 13:47:06 -0700557sub sanitise_line {
558 my ($line) = @_;
559
560 my $res = '';
561 my $l = '';
562
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800563 my $qlen = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700564 my $off = 0;
565 my $c;
Andy Whitcroft00df3442007-06-08 13:47:06 -0700566
Andy Whitcroft773647a2008-03-28 14:15:58 -0700567 # Always copy over the diff marker.
568 $res = substr($line, 0, 1);
569
570 for ($off = 1; $off < length($line); $off++) {
571 $c = substr($line, $off, 1);
572
573 # Comments we are wacking completly including the begin
574 # and end, all to $;.
575 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
576 $sanitise_quote = '*/';
577
578 substr($res, $off, 2, "$;$;");
579 $off++;
580 next;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800581 }
Andy Whitcroft81bc0e02008-10-15 22:02:26 -0700582 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700583 $sanitise_quote = '';
584 substr($res, $off, 2, "$;$;");
585 $off++;
586 next;
587 }
Daniel Walker113f04a2009-09-21 17:04:35 -0700588 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
589 $sanitise_quote = '//';
590
591 substr($res, $off, 2, $sanitise_quote);
592 $off++;
593 next;
594 }
Andy Whitcroft773647a2008-03-28 14:15:58 -0700595
596 # A \ in a string means ignore the next character.
597 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
598 $c eq "\\") {
599 substr($res, $off, 2, 'XX');
600 $off++;
601 next;
602 }
603 # Regular quotes.
604 if ($c eq "'" || $c eq '"') {
605 if ($sanitise_quote eq '') {
606 $sanitise_quote = $c;
607
608 substr($res, $off, 1, $c);
Andy Whitcroft00df3442007-06-08 13:47:06 -0700609 next;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700610 } elsif ($sanitise_quote eq $c) {
611 $sanitise_quote = '';
Andy Whitcroft00df3442007-06-08 13:47:06 -0700612 }
613 }
Andy Whitcroft773647a2008-03-28 14:15:58 -0700614
Andy Whitcroftfae17da2009-01-06 14:41:20 -0800615 #print "c<$c> SQ<$sanitise_quote>\n";
Andy Whitcroft773647a2008-03-28 14:15:58 -0700616 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
617 substr($res, $off, 1, $;);
Daniel Walker113f04a2009-09-21 17:04:35 -0700618 } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
619 substr($res, $off, 1, $;);
Andy Whitcroft773647a2008-03-28 14:15:58 -0700620 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
621 substr($res, $off, 1, 'X');
Andy Whitcroft00df3442007-06-08 13:47:06 -0700622 } else {
Andy Whitcroft773647a2008-03-28 14:15:58 -0700623 substr($res, $off, 1, $c);
Andy Whitcroft00df3442007-06-08 13:47:06 -0700624 }
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800625 }
626
Daniel Walker113f04a2009-09-21 17:04:35 -0700627 if ($sanitise_quote eq '//') {
628 $sanitise_quote = '';
629 }
630
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800631 # The pathname on a #include may be surrounded by '<' and '>'.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700632 if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800633 my $clean = 'X' x length($1);
634 $res =~ s@\<.*\>@<$clean>@;
635
636 # The whole of a #error is a string.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700637 } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800638 my $clean = 'X' x length($1);
Andy Whitcroftc45dcab2008-06-05 22:46:01 -0700639 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800640 }
641
Andy Whitcroft00df3442007-06-08 13:47:06 -0700642 return $res;
643}
644
Andy Whitcroft8905a672007-11-28 16:21:06 -0800645sub ctx_statement_block {
646 my ($linenr, $remain, $off) = @_;
647 my $line = $linenr - 1;
648 my $blk = '';
649 my $soff = $off;
650 my $coff = $off - 1;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700651 my $coff_set = 0;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800652
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800653 my $loff = 0;
654
Andy Whitcroft8905a672007-11-28 16:21:06 -0800655 my $type = '';
656 my $level = 0;
Andy Whitcrofta2750642009-01-15 13:51:04 -0800657 my @stack = ();
Andy Whitcroftcf655042008-03-04 14:28:20 -0800658 my $p;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800659 my $c;
660 my $len = 0;
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800661
662 my $remainder;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800663 while (1) {
Andy Whitcrofta2750642009-01-15 13:51:04 -0800664 @stack = (['', 0]) if ($#stack == -1);
665
Andy Whitcroft773647a2008-03-28 14:15:58 -0700666 #warn "CSB: blk<$blk> remain<$remain>\n";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800667 # If we are about to drop off the end, pull in more
668 # context.
669 if ($off >= $len) {
670 for (; $remain > 0; $line++) {
Andy Whitcroftdea33492008-10-15 22:02:25 -0700671 last if (!defined $lines[$line]);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800672 next if ($lines[$line] =~ /^-/);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800673 $remain--;
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800674 $loff = $len;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -0800675 $blk .= $lines[$line] . "\n";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800676 $len = length($blk);
677 $line++;
678 last;
679 }
680 # Bail if there is no further context.
681 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800682 if ($off >= $len) {
Andy Whitcroft8905a672007-11-28 16:21:06 -0800683 last;
684 }
Andy Whitcroftf74bd192012-01-10 15:09:54 -0800685 if ($level == 0 && substr($blk, $off) =~ /^.\s*#\s*define/) {
686 $level++;
687 $type = '#';
688 }
Andy Whitcroft8905a672007-11-28 16:21:06 -0800689 }
Andy Whitcroftcf655042008-03-04 14:28:20 -0800690 $p = $c;
Andy Whitcroft8905a672007-11-28 16:21:06 -0800691 $c = substr($blk, $off, 1);
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800692 $remainder = substr($blk, $off);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800693
Andy Whitcroft773647a2008-03-28 14:15:58 -0700694 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
Andy Whitcroft4635f4f2009-01-06 14:41:27 -0800695
696 # Handle nested #if/#else.
697 if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
698 push(@stack, [ $type, $level ]);
699 } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
700 ($type, $level) = @{$stack[$#stack - 1]};
701 } elsif ($remainder =~ /^#\s*endif\b/) {
702 ($type, $level) = @{pop(@stack)};
703 }
704
Andy Whitcroft8905a672007-11-28 16:21:06 -0800705 # Statement ends at the ';' or a close '}' at the
706 # outermost level.
707 if ($level == 0 && $c eq ';') {
708 last;
709 }
710
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800711 # An else is really a conditional as long as its not else if
Andy Whitcroft773647a2008-03-28 14:15:58 -0700712 if ($level == 0 && $coff_set == 0 &&
713 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
714 $remainder =~ /^(else)(?:\s|{)/ &&
715 $remainder !~ /^else\s+if\b/) {
716 $coff = $off + length($1) - 1;
717 $coff_set = 1;
718 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
719 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800720 }
721
Andy Whitcroft8905a672007-11-28 16:21:06 -0800722 if (($type eq '' || $type eq '(') && $c eq '(') {
723 $level++;
724 $type = '(';
725 }
726 if ($type eq '(' && $c eq ')') {
727 $level--;
728 $type = ($level != 0)? '(' : '';
729
730 if ($level == 0 && $coff < $soff) {
731 $coff = $off;
Andy Whitcroft773647a2008-03-28 14:15:58 -0700732 $coff_set = 1;
733 #warn "CSB: mark coff<$coff>\n";
Andy Whitcroft8905a672007-11-28 16:21:06 -0800734 }
735 }
736 if (($type eq '' || $type eq '{') && $c eq '{') {
737 $level++;
738 $type = '{';
739 }
740 if ($type eq '{' && $c eq '}') {
741 $level--;
742 $type = ($level != 0)? '{' : '';
743
744 if ($level == 0) {
Patrick Pannutob998e002010-08-09 17:21:03 -0700745 if (substr($blk, $off + 1, 1) eq ';') {
746 $off++;
747 }
Andy Whitcroft8905a672007-11-28 16:21:06 -0800748 last;
749 }
750 }
Andy Whitcroftf74bd192012-01-10 15:09:54 -0800751 # Preprocessor commands end at the newline unless escaped.
752 if ($type eq '#' && $c eq "\n" && $p ne "\\") {
753 $level--;
754 $type = '';
755 $off++;
756 last;
757 }
Andy Whitcroft8905a672007-11-28 16:21:06 -0800758 $off++;
759 }
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -0700760 # We are truly at the end, so shuffle to the next line.
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800761 if ($off == $len) {
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -0700762 $loff = $len + 1;
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800763 $line++;
764 $remain--;
765 }
Andy Whitcroft8905a672007-11-28 16:21:06 -0800766
767 my $statement = substr($blk, $soff, $off - $soff + 1);
768 my $condition = substr($blk, $soff, $coff - $soff + 1);
769
770 #warn "STATEMENT<$statement>\n";
771 #warn "CONDITION<$condition>\n";
772
Andy Whitcroft773647a2008-03-28 14:15:58 -0700773 #print "coff<$coff> soff<$off> loff<$loff>\n";
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800774
775 return ($statement, $condition,
776 $line, $remain + 1, $off - $loff + 1, $level);
777}
778
Andy Whitcroftcf655042008-03-04 14:28:20 -0800779sub statement_lines {
780 my ($stmt) = @_;
781
782 # Strip the diff line prefixes and rip blank lines at start and end.
783 $stmt =~ s/(^|\n)./$1/g;
784 $stmt =~ s/^\s*//;
785 $stmt =~ s/\s*$//;
786
787 my @stmt_lines = ($stmt =~ /\n/g);
788
789 return $#stmt_lines + 2;
790}
791
792sub statement_rawlines {
793 my ($stmt) = @_;
794
795 my @stmt_lines = ($stmt =~ /\n/g);
796
797 return $#stmt_lines + 2;
798}
799
800sub statement_block_size {
801 my ($stmt) = @_;
802
803 $stmt =~ s/(^|\n)./$1/g;
804 $stmt =~ s/^\s*{//;
805 $stmt =~ s/}\s*$//;
806 $stmt =~ s/^\s*//;
807 $stmt =~ s/\s*$//;
808
809 my @stmt_lines = ($stmt =~ /\n/g);
810 my @stmt_statements = ($stmt =~ /;/g);
811
812 my $stmt_lines = $#stmt_lines + 2;
813 my $stmt_statements = $#stmt_statements + 1;
814
815 if ($stmt_lines > $stmt_statements) {
816 return $stmt_lines;
817 } else {
818 return $stmt_statements;
819 }
820}
821
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800822sub ctx_statement_full {
823 my ($linenr, $remain, $off) = @_;
824 my ($statement, $condition, $level);
825
826 my (@chunks);
827
Andy Whitcroftcf655042008-03-04 14:28:20 -0800828 # Grab the first conditional/block pair.
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800829 ($statement, $condition, $linenr, $remain, $off, $level) =
830 ctx_statement_block($linenr, $remain, $off);
Andy Whitcroft773647a2008-03-28 14:15:58 -0700831 #print "F: c<$condition> s<$statement> remain<$remain>\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -0800832 push(@chunks, [ $condition, $statement ]);
833 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
834 return ($level, $linenr, @chunks);
835 }
836
837 # Pull in the following conditional/block pairs and see if they
838 # could continue the statement.
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800839 for (;;) {
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800840 ($statement, $condition, $linenr, $remain, $off, $level) =
841 ctx_statement_block($linenr, $remain, $off);
Andy Whitcroftcf655042008-03-04 14:28:20 -0800842 #print "C: c<$condition> s<$statement> remain<$remain>\n";
Andy Whitcroft773647a2008-03-28 14:15:58 -0700843 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
Andy Whitcroftcf655042008-03-04 14:28:20 -0800844 #print "C: push\n";
845 push(@chunks, [ $condition, $statement ]);
Andy Whitcroft13214ad2008-02-08 04:22:03 -0800846 }
847
848 return ($level, $linenr, @chunks);
Andy Whitcroft8905a672007-11-28 16:21:06 -0800849}
850
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700851sub ctx_block_get {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700852 my ($linenr, $remain, $outer, $open, $close, $off) = @_;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700853 my $line;
854 my $start = $linenr - 1;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700855 my $blk = '';
856 my @o;
857 my @c;
858 my @res = ();
859
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700860 my $level = 0;
Andy Whitcroft4635f4f2009-01-06 14:41:27 -0800861 my @stack = ($level);
Andy Whitcroft00df3442007-06-08 13:47:06 -0700862 for ($line = $start; $remain > 0; $line++) {
863 next if ($rawlines[$line] =~ /^-/);
864 $remain--;
865
866 $blk .= $rawlines[$line];
Andy Whitcroft4635f4f2009-01-06 14:41:27 -0800867
868 # Handle nested #if/#else.
Andy Whitcroft01464f32010-10-26 14:23:19 -0700869 if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
Andy Whitcroft4635f4f2009-01-06 14:41:27 -0800870 push(@stack, $level);
Andy Whitcroft01464f32010-10-26 14:23:19 -0700871 } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
Andy Whitcroft4635f4f2009-01-06 14:41:27 -0800872 $level = $stack[$#stack - 1];
Andy Whitcroft01464f32010-10-26 14:23:19 -0700873 } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
Andy Whitcroft4635f4f2009-01-06 14:41:27 -0800874 $level = pop(@stack);
875 }
876
Andy Whitcroft01464f32010-10-26 14:23:19 -0700877 foreach my $c (split(//, $lines[$line])) {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700878 ##print "C<$c>L<$level><$open$close>O<$off>\n";
879 if ($off > 0) {
880 $off--;
881 next;
882 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700883
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700884 if ($c eq $close && $level > 0) {
885 $level--;
886 last if ($level == 0);
887 } elsif ($c eq $open) {
888 $level++;
889 }
890 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700891
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700892 if (!$outer || $level <= 1) {
Andy Whitcroft00df3442007-06-08 13:47:06 -0700893 push(@res, $rawlines[$line]);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700894 }
895
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700896 last if ($level == 0);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700897 }
898
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700899 return ($level, @res);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700900}
901sub ctx_block_outer {
902 my ($linenr, $remain) = @_;
903
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700904 my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
905 return @r;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700906}
907sub ctx_block {
908 my ($linenr, $remain) = @_;
909
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700910 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
911 return @r;
Andy Whitcroft653d4872007-06-23 17:16:34 -0700912}
913sub ctx_statement {
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700914 my ($linenr, $remain, $off) = @_;
915
916 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
917 return @r;
918}
919sub ctx_block_level {
Andy Whitcroft653d4872007-06-23 17:16:34 -0700920 my ($linenr, $remain) = @_;
921
Andy Whitcroftf0a594c2007-07-19 01:48:34 -0700922 return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700923}
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700924sub ctx_statement_level {
925 my ($linenr, $remain, $off) = @_;
926
927 return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
928}
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700929
930sub ctx_locate_comment {
931 my ($first_line, $end_line) = @_;
932
933 # Catch a comment on the end of the line itself.
Andy Whitcroftbeae6332008-07-23 21:28:59 -0700934 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700935 return $current_comment if (defined $current_comment);
936
937 # Look through the context and try and figure out if there is a
938 # comment.
939 my $in_comment = 0;
940 $current_comment = '';
941 for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
Andy Whitcroft00df3442007-06-08 13:47:06 -0700942 my $line = $rawlines[$linenr - 1];
943 #warn " $line\n";
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700944 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
945 $in_comment = 1;
946 }
947 if ($line =~ m@/\*@) {
948 $in_comment = 1;
949 }
950 if (!$in_comment && $current_comment ne '') {
951 $current_comment = '';
952 }
953 $current_comment .= $line . "\n" if ($in_comment);
954 if ($line =~ m@\*/@) {
955 $in_comment = 0;
956 }
957 }
958
959 chomp($current_comment);
960 return($current_comment);
961}
962sub ctx_has_comment {
963 my ($first_line, $end_line) = @_;
964 my $cmt = ctx_locate_comment($first_line, $end_line);
965
Andy Whitcroft00df3442007-06-08 13:47:06 -0700966 ##print "LINE: $rawlines[$end_line - 1 ]\n";
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -0700967 ##print "CMMT: $cmt\n";
968
969 return ($cmt ne '');
970}
971
Andy Whitcroft4d001e42008-10-15 22:02:21 -0700972sub raw_line {
973 my ($linenr, $cnt) = @_;
974
975 my $offset = $linenr - 1;
976 $cnt++;
977
978 my $line;
979 while ($cnt) {
980 $line = $rawlines[$offset++];
981 next if (defined($line) && $line =~ /^-/);
982 $cnt--;
983 }
984
985 return $line;
986}
987
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700988sub cat_vet {
989 my ($vet) = @_;
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700990 my ($res, $coded);
Andy Whitcroft0a920b52007-06-01 00:46:48 -0700991
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700992 $res = '';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -0700993 while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
994 $res .= $1;
995 if ($2 ne '') {
996 $coded = sprintf("^%c", unpack('C', $2) + 64);
997 $res .= $coded;
998 }
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -0700999 }
1000 $res =~ s/$/\$/;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001001
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001002 return $res;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001003}
1004
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001005my $av_preprocessor = 0;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001006my $av_pending;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001007my @av_paren_type;
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001008my $av_pend_colon;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001009
1010sub annotate_reset {
1011 $av_preprocessor = 0;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001012 $av_pending = '_';
1013 @av_paren_type = ('E');
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001014 $av_pend_colon = 'O';
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001015}
1016
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001017sub annotate_values {
1018 my ($stream, $type) = @_;
1019
1020 my $res;
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001021 my $var = '_' x length($stream);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001022 my $cur = $stream;
1023
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001024 print "$stream\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001025
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001026 while (length($cur)) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001027 @av_paren_type = ('E') if ($#av_paren_type < 0);
Andy Whitcroftcf655042008-03-04 14:28:20 -08001028 print " <" . join('', @av_paren_type) .
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001029 "> <$type> <$av_pending>" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001030 if ($cur =~ /^(\s+)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001031 print "WS($1)\n" if ($dbg_values > 1);
1032 if ($1 =~ /\n/ && $av_preprocessor) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001033 $type = pop(@av_paren_type);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001034 $av_preprocessor = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001035 }
1036
Florian Micklerc023e4732011-01-12 16:59:58 -08001037 } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
Andy Whitcroft9446ef52010-10-26 14:23:13 -07001038 print "CAST($1)\n" if ($dbg_values > 1);
1039 push(@av_paren_type, $type);
Andy Whitcroftaddcdce2012-01-10 15:10:11 -08001040 $type = 'c';
Andy Whitcroft9446ef52010-10-26 14:23:13 -07001041
Andy Whitcrofte91b6e22010-10-26 14:23:11 -07001042 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001043 print "DECLARE($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001044 $type = 'T';
1045
Andy Whitcroft389a2fe2008-07-23 21:29:05 -07001046 } elsif ($cur =~ /^($Modifier)\s*/) {
1047 print "MODIFIER($1)\n" if ($dbg_values > 1);
1048 $type = 'T';
1049
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001050 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001051 print "DEFINE($1,$2)\n" if ($dbg_values > 1);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001052 $av_preprocessor = 1;
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001053 push(@av_paren_type, $type);
1054 if ($2 ne '') {
1055 $av_pending = 'N';
1056 }
1057 $type = 'E';
1058
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001059 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001060 print "UNDEF($1)\n" if ($dbg_values > 1);
1061 $av_preprocessor = 1;
1062 push(@av_paren_type, $type);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001063
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001064 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001065 print "PRE_START($1)\n" if ($dbg_values > 1);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001066 $av_preprocessor = 1;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001067
1068 push(@av_paren_type, $type);
1069 push(@av_paren_type, $type);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001070 $type = 'E';
Andy Whitcroftcf655042008-03-04 14:28:20 -08001071
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001072 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001073 print "PRE_RESTART($1)\n" if ($dbg_values > 1);
1074 $av_preprocessor = 1;
1075
1076 push(@av_paren_type, $av_paren_type[$#av_paren_type]);
1077
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001078 $type = 'E';
Andy Whitcroftcf655042008-03-04 14:28:20 -08001079
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001080 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001081 print "PRE_END($1)\n" if ($dbg_values > 1);
1082
1083 $av_preprocessor = 1;
1084
1085 # Assume all arms of the conditional end as this
1086 # one does, and continue as if the #endif was not here.
1087 pop(@av_paren_type);
1088 push(@av_paren_type, $type);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001089 $type = 'E';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001090
1091 } elsif ($cur =~ /^(\\\n)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001092 print "PRECONT($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001093
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001094 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
1095 print "ATTR($1)\n" if ($dbg_values > 1);
1096 $av_pending = $type;
1097 $type = 'N';
1098
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001099 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001100 print "SIZEOF($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001101 if (defined $2) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001102 $av_pending = 'V';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001103 }
1104 $type = 'N';
1105
Andy Whitcroft14b111c2008-10-15 22:02:16 -07001106 } elsif ($cur =~ /^(if|while|for)\b/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001107 print "COND($1)\n" if ($dbg_values > 1);
Andy Whitcroft14b111c2008-10-15 22:02:16 -07001108 $av_pending = 'E';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001109 $type = 'N';
1110
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001111 } elsif ($cur =~/^(case)/o) {
1112 print "CASE($1)\n" if ($dbg_values > 1);
1113 $av_pend_colon = 'C';
1114 $type = 'N';
1115
Andy Whitcroft14b111c2008-10-15 22:02:16 -07001116 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001117 print "KEYWORD($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001118 $type = 'N';
1119
1120 } elsif ($cur =~ /^(\()/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001121 print "PAREN('$1')\n" if ($dbg_values > 1);
Andy Whitcroftcf655042008-03-04 14:28:20 -08001122 push(@av_paren_type, $av_pending);
1123 $av_pending = '_';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001124 $type = 'N';
1125
1126 } elsif ($cur =~ /^(\))/o) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08001127 my $new_type = pop(@av_paren_type);
1128 if ($new_type ne '_') {
1129 $type = $new_type;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001130 print "PAREN('$1') -> $type\n"
1131 if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001132 } else {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001133 print "PAREN('$1')\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001134 }
1135
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -07001136 } elsif ($cur =~ /^($Ident)\s*\(/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001137 print "FUNC($1)\n" if ($dbg_values > 1);
Andy Whitcroftc8cb2ca2008-07-23 21:28:57 -07001138 $type = 'V';
Andy Whitcroftcf655042008-03-04 14:28:20 -08001139 $av_pending = 'V';
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001140
Andy Whitcroft8e761b02009-01-06 14:41:19 -08001141 } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
1142 if (defined $2 && $type eq 'C' || $type eq 'T') {
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001143 $av_pend_colon = 'B';
Andy Whitcroft8e761b02009-01-06 14:41:19 -08001144 } elsif ($type eq 'E') {
1145 $av_pend_colon = 'L';
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001146 }
1147 print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
1148 $type = 'V';
1149
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001150 } elsif ($cur =~ /^($Ident|$Constant)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001151 print "IDENT($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001152 $type = 'V';
1153
1154 } elsif ($cur =~ /^($Assignment)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001155 print "ASSIGN($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001156 $type = 'N';
1157
Andy Whitcroftcf655042008-03-04 14:28:20 -08001158 } elsif ($cur =~/^(;|{|})/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001159 print "END($1)\n" if ($dbg_values > 1);
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001160 $type = 'E';
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001161 $av_pend_colon = 'O';
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001162
Andy Whitcroft8e761b02009-01-06 14:41:19 -08001163 } elsif ($cur =~/^(,)/) {
1164 print "COMMA($1)\n" if ($dbg_values > 1);
1165 $type = 'C';
1166
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001167 } elsif ($cur =~ /^(\?)/o) {
1168 print "QUESTION($1)\n" if ($dbg_values > 1);
1169 $type = 'N';
1170
1171 } elsif ($cur =~ /^(:)/o) {
1172 print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
1173
1174 substr($var, length($res), 1, $av_pend_colon);
1175 if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
1176 $type = 'E';
1177 } else {
1178 $type = 'N';
1179 }
1180 $av_pend_colon = 'O';
1181
Andy Whitcroft8e761b02009-01-06 14:41:19 -08001182 } elsif ($cur =~ /^(\[)/o) {
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001183 print "CLOSE($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001184 $type = 'N';
1185
Andy Whitcroft0d413862008-10-15 22:02:16 -07001186 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
Andy Whitcroft74048ed2008-07-23 21:29:10 -07001187 my $variant;
1188
1189 print "OPV($1)\n" if ($dbg_values > 1);
1190 if ($type eq 'V') {
1191 $variant = 'B';
1192 } else {
1193 $variant = 'U';
1194 }
1195
1196 substr($var, length($res), 1, $variant);
1197 $type = 'N';
1198
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001199 } elsif ($cur =~ /^($Operators)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001200 print "OP($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001201 if ($1 ne '++' && $1 ne '--') {
1202 $type = 'N';
1203 }
1204
1205 } elsif ($cur =~ /(^.)/o) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001206 print "C($1)\n" if ($dbg_values > 1);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001207 }
1208 if (defined $1) {
1209 $cur = substr($cur, length($1));
1210 $res .= $type x length($1);
1211 }
1212 }
1213
Andy Whitcroft1f65f942008-07-23 21:29:10 -07001214 return ($res, $var);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001215}
1216
Andy Whitcroft8905a672007-11-28 16:21:06 -08001217sub possible {
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001218 my ($possible, $line) = @_;
Andy Whitcroft9a974fd2009-10-26 16:50:12 -07001219 my $notPermitted = qr{(?:
Andy Whitcroft0776e592008-10-15 22:02:29 -07001220 ^(?:
1221 $Modifier|
1222 $Storage|
1223 $Type|
Andy Whitcroft9a974fd2009-10-26 16:50:12 -07001224 DEFINE_\S+
1225 )$|
1226 ^(?:
Andy Whitcroft0776e592008-10-15 22:02:29 -07001227 goto|
1228 return|
1229 case|
1230 else|
1231 asm|__asm__|
Andy Whitcroft89a88352012-01-10 15:10:00 -08001232 do|
1233 \#|
1234 \#\#|
Andy Whitcroft9a974fd2009-10-26 16:50:12 -07001235 )(?:\s|$)|
Andy Whitcroft0776e592008-10-15 22:02:29 -07001236 ^(?:typedef|struct|enum)\b
Andy Whitcroft9a974fd2009-10-26 16:50:12 -07001237 )}x;
1238 warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1239 if ($possible !~ $notPermitted) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001240 # Check for modifiers.
1241 $possible =~ s/\s*$Storage\s*//g;
1242 $possible =~ s/\s*$Sparse\s*//g;
1243 if ($possible =~ /^\s*$/) {
1244
1245 } elsif ($possible =~ /\s/) {
1246 $possible =~ s/\s*$Type\s*//g;
Andy Whitcroftd2506582008-07-23 21:29:09 -07001247 for my $modifier (split(' ', $possible)) {
Andy Whitcroft9a974fd2009-10-26 16:50:12 -07001248 if ($modifier !~ $notPermitted) {
1249 warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1250 push(@modifierList, $modifier);
1251 }
Andy Whitcroftd2506582008-07-23 21:29:09 -07001252 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001253
1254 } else {
1255 warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1256 push(@typeList, $possible);
1257 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08001258 build_types();
Andy Whitcroft0776e592008-10-15 22:02:29 -07001259 } else {
1260 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001261 }
1262}
1263
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001264my $prefix = '';
1265
Joe Perches000d1cc12011-07-25 17:13:25 -07001266sub show_type {
1267 return !defined $ignore_type{$_[0]};
1268}
1269
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001270sub report {
Joe Perches000d1cc12011-07-25 17:13:25 -07001271 if (!show_type($_[1]) ||
1272 (defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001273 return 0;
1274 }
Joe Perches000d1cc12011-07-25 17:13:25 -07001275 my $line;
1276 if ($show_types) {
1277 $line = "$prefix$_[0]:$_[1]: $_[2]\n";
1278 } else {
1279 $line = "$prefix$_[0]: $_[2]\n";
1280 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08001281 $line = (split('\n', $line))[0] . "\n" if ($terse);
1282
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001283 push(our @report, $line);
Andy Whitcroft773647a2008-03-28 14:15:58 -07001284
1285 return 1;
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001286}
1287sub report_dump {
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001288 our @report;
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07001289}
Joe Perches000d1cc12011-07-25 17:13:25 -07001290
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001291sub ERROR {
Joe Perches000d1cc12011-07-25 17:13:25 -07001292 if (report("ERROR", $_[0], $_[1])) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001293 our $clean = 0;
1294 our $cnt_error++;
1295 }
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001296}
1297sub WARN {
Joe Perches000d1cc12011-07-25 17:13:25 -07001298 if (report("WARNING", $_[0], $_[1])) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001299 our $clean = 0;
1300 our $cnt_warn++;
1301 }
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001302}
1303sub CHK {
Joe Perches000d1cc12011-07-25 17:13:25 -07001304 if ($check && report("CHECK", $_[0], $_[1])) {
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001305 our $clean = 0;
1306 our $cnt_chk++;
1307 }
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001308}
1309
Andy Whitcroft6ecd9672008-10-15 22:02:21 -07001310sub check_absolute_file {
1311 my ($absolute, $herecurr) = @_;
1312 my $file = $absolute;
1313
1314 ##print "absolute<$absolute>\n";
1315
1316 # See if any suffix of this path is a path within the tree.
1317 while ($file =~ s@^[^/]*/@@) {
1318 if (-f "$root/$file") {
1319 ##print "file<$file>\n";
1320 last;
1321 }
1322 }
1323 if (! -f _) {
1324 return 0;
1325 }
1326
1327 # It is, so see if the prefix is acceptable.
1328 my $prefix = $absolute;
1329 substr($prefix, -length($file)) = '';
1330
1331 ##print "prefix<$prefix>\n";
1332 if ($prefix ne ".../") {
Joe Perches000d1cc12011-07-25 17:13:25 -07001333 WARN("USE_RELATIVE_PATH",
1334 "use relative pathname instead of absolute in changelog text\n" . $herecurr);
Andy Whitcroft6ecd9672008-10-15 22:02:21 -07001335 }
1336}
1337
Joe Perchesd1fe9c02012-03-23 15:02:16 -07001338sub pos_last_openparen {
1339 my ($line) = @_;
1340
1341 my $pos = 0;
1342
1343 my $opens = $line =~ tr/\(/\(/;
1344 my $closes = $line =~ tr/\)/\)/;
1345
1346 my $last_openparen = 0;
1347
1348 if (($opens == 0) || ($closes >= $opens)) {
1349 return -1;
1350 }
1351
1352 my $len = length($line);
1353
1354 for ($pos = 0; $pos < $len; $pos++) {
1355 my $string = substr($line, $pos);
1356 if ($string =~ /^($FuncArg|$balanced_parens)/) {
1357 $pos += length($1) - 1;
1358 } elsif (substr($line, $pos, 1) eq '(') {
1359 $last_openparen = $pos;
1360 } elsif (index($string, '(') == -1) {
1361 last;
1362 }
1363 }
1364
1365 return $last_openparen + 1;
1366}
1367
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001368sub process {
1369 my $filename = shift;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001370
1371 my $linenr=0;
1372 my $prevline="";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001373 my $prevrawline="";
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001374 my $stashline="";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001375 my $stashrawline="";
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001376
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001377 my $length;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001378 my $indent;
1379 my $previndent=0;
1380 my $stashindent=0;
1381
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001382 our $clean = 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001383 my $signoff = 0;
1384 my $is_patch = 0;
1385
Joe Perches15662b32011-10-31 17:13:12 -07001386 my $in_header_lines = 1;
1387 my $in_commit_log = 0; #Scanning lines before patch
1388
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001389 our @report = ();
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001390 our $cnt_lines = 0;
1391 our $cnt_error = 0;
1392 our $cnt_warn = 0;
1393 our $cnt_chk = 0;
1394
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001395 # Trace the real file/line as we go.
1396 my $realfile = '';
1397 my $realline = 0;
1398 my $realcnt = 0;
1399 my $here = '';
1400 my $in_comment = 0;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001401 my $comment_edge = 0;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001402 my $first_line = 0;
Wolfram Sang1e855722009-01-06 14:41:24 -08001403 my $p1_prefix = '';
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001404
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001405 my $prev_values = 'E';
1406
1407 # suppression flags
Andy Whitcroft773647a2008-03-28 14:15:58 -07001408 my %suppress_ifbraces;
Andy Whitcroft170d3a22008-10-15 22:02:30 -07001409 my %suppress_whiletrailers;
Andy Whitcroft2b474a12009-10-26 16:50:16 -07001410 my %suppress_export;
Andy Whitcroft3e469cd2012-01-10 15:10:01 -08001411 my $suppress_statement = 0;
Andy Whitcroft653d4872007-06-23 17:16:34 -07001412
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001413 # Pre-scan the patch sanitizing the lines.
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001414 # Pre-scan the patch looking for any __setup documentation.
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001415 #
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001416 my @setup_docs = ();
1417 my $setup_docs = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -07001418
1419 sanitise_line_reset();
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001420 my $line;
1421 foreach my $rawline (@rawlines) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001422 $linenr++;
1423 $line = $rawline;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001424
Andy Whitcroft773647a2008-03-28 14:15:58 -07001425 if ($rawline=~/^\+\+\+\s+(\S+)/) {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001426 $setup_docs = 0;
1427 if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1428 $setup_docs = 1;
1429 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001430 #next;
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001431 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001432 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1433 $realline=$1-1;
1434 if (defined $2) {
1435 $realcnt=$3+1;
1436 } else {
1437 $realcnt=1+1;
1438 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001439 $in_comment = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -07001440
1441 # Guestimate if this is a continuing comment. Run
1442 # the context looking for a comment "edge". If this
1443 # edge is a close comment then we must be in a comment
1444 # at context start.
1445 my $edge;
Andy Whitcroft01fa9142008-10-15 22:02:19 -07001446 my $cnt = $realcnt;
1447 for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1448 next if (defined $rawlines[$ln - 1] &&
1449 $rawlines[$ln - 1] =~ /^-/);
1450 $cnt--;
1451 #print "RAW<$rawlines[$ln - 1]>\n";
Andy Whitcroft721c1cb2009-01-06 14:41:16 -08001452 last if (!defined $rawlines[$ln - 1]);
Andy Whitcroftfae17da2009-01-06 14:41:20 -08001453 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1454 $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1455 ($edge) = $1;
1456 last;
1457 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001458 }
1459 if (defined $edge && $edge eq '*/') {
1460 $in_comment = 1;
1461 }
1462
1463 # Guestimate if this is a continuing comment. If this
1464 # is the start of a diff block and this line starts
1465 # ' *' then it is very likely a comment.
1466 if (!defined $edge &&
Andy Whitcroft83242e02009-01-06 14:41:17 -08001467 $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
Andy Whitcroft773647a2008-03-28 14:15:58 -07001468 {
1469 $in_comment = 1;
1470 }
1471
1472 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1473 sanitise_line_reset($in_comment);
1474
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001475 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001476 # Standardise the strings and chars within the input to
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001477 # simplify matching -- only bother with positive lines.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001478 $line = sanitise_line($rawline);
1479 }
1480 push(@lines, $line);
1481
1482 if ($realcnt > 1) {
1483 $realcnt-- if ($line =~ /^(?:\+| |$)/);
1484 } else {
1485 $realcnt = 0;
1486 }
1487
1488 #print "==>$rawline\n";
1489 #print "-->$line\n";
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001490
1491 if ($setup_docs && $line =~ /^\+/) {
1492 push(@setup_docs, $line);
1493 }
1494 }
1495
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001496 $prefix = '';
1497
Andy Whitcroft773647a2008-03-28 14:15:58 -07001498 $realcnt = 0;
1499 $linenr = 0;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001500 foreach my $line (@lines) {
1501 $linenr++;
1502
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001503 my $rawline = $rawlines[$linenr - 1];
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001504
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001505#extract the line range in the file after the patch is applied
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001506 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001507 $is_patch = 1;
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001508 $first_line = $linenr + 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001509 $realline=$1-1;
1510 if (defined $2) {
1511 $realcnt=$3+1;
1512 } else {
1513 $realcnt=1+1;
1514 }
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001515 annotate_reset();
Andy Whitcroft13214ad2008-02-08 04:22:03 -08001516 $prev_values = 'E';
1517
Andy Whitcroft773647a2008-03-28 14:15:58 -07001518 %suppress_ifbraces = ();
Andy Whitcroft170d3a22008-10-15 22:02:30 -07001519 %suppress_whiletrailers = ();
Andy Whitcroft2b474a12009-10-26 16:50:16 -07001520 %suppress_export = ();
Andy Whitcroft3e469cd2012-01-10 15:10:01 -08001521 $suppress_statement = 0;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001522 next;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001523
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001524# track the line number as we move through the hunk, note that
1525# new versions of GNU diff omit the leading space on completely
1526# blank context lines so we need to count that too.
Andy Whitcroft773647a2008-03-28 14:15:58 -07001527 } elsif ($line =~ /^( |\+|$)/) {
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001528 $realline++;
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001529 $realcnt-- if ($realcnt != 0);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001530
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001531 # Measure the line length and indent.
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001532 ($length, $indent) = line_stats($rawline);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001533
1534 # Track the previous line.
1535 ($prevline, $stashline) = ($stashline, $line);
1536 ($previndent, $stashindent) = ($stashindent, $indent);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001537 ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1538
Andy Whitcroft773647a2008-03-28 14:15:58 -07001539 #warn "line<$line>\n";
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001540
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001541 } elsif ($realcnt == 1) {
1542 $realcnt--;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001543 }
1544
Andy Whitcroftcc77cdc2009-10-26 16:50:13 -07001545 my $hunk_line = ($realcnt != 0);
1546
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001547#make up the handle for any error we report on this line
Andy Whitcroft773647a2008-03-28 14:15:58 -07001548 $prefix = "$filename:$realline: " if ($emacs && $file);
1549 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1550
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001551 $here = "#$linenr: " if (!$file);
1552 $here = "#$realline: " if ($file);
Andy Whitcroft773647a2008-03-28 14:15:58 -07001553
1554 # extract the filename as it passes
Rabin Vincent3bf9a002010-10-26 14:23:16 -07001555 if ($line =~ /^diff --git.*?(\S+)$/) {
1556 $realfile = $1;
1557 $realfile =~ s@^([^/]*)/@@;
Joe Perches270c49a2012-01-10 15:09:50 -08001558 $in_commit_log = 0;
Rabin Vincent3bf9a002010-10-26 14:23:16 -07001559 } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07001560 $realfile = $1;
Wolfram Sang1e855722009-01-06 14:41:24 -08001561 $realfile =~ s@^([^/]*)/@@;
Joe Perches270c49a2012-01-10 15:09:50 -08001562 $in_commit_log = 0;
Wolfram Sang1e855722009-01-06 14:41:24 -08001563
1564 $p1_prefix = $1;
Andy Whitcrofte2f7aa42009-02-27 14:03:06 -08001565 if (!$file && $tree && $p1_prefix ne '' &&
1566 -e "$root/$p1_prefix") {
Joe Perches000d1cc12011-07-25 17:13:25 -07001567 WARN("PATCH_PREFIX",
1568 "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
Wolfram Sang1e855722009-01-06 14:41:24 -08001569 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07001570
Andy Whitcroftc1ab3322008-10-15 22:02:20 -07001571 if ($realfile =~ m@^include/asm/@) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001572 ERROR("MODIFIED_INCLUDE_ASM",
1573 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
Andy Whitcroft773647a2008-03-28 14:15:58 -07001574 }
1575 next;
1576 }
1577
Randy Dunlap389834b2007-06-08 13:47:03 -07001578 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001579
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001580 my $hereline = "$here\n$rawline\n";
1581 my $herecurr = "$here\n$rawline\n";
1582 my $hereprev = "$here\n$prevrawline\n$rawline\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001583
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001584 $cnt_lines++ if ($realcnt != 0);
1585
Rabin Vincent3bf9a002010-10-26 14:23:16 -07001586# Check for incorrect file permissions
1587 if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
1588 my $permhere = $here . "FILE: $realfile\n";
1589 if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001590 ERROR("EXECUTE_PERMISSIONS",
1591 "do not set execute permissions for source files\n" . $permhere);
Rabin Vincent3bf9a002010-10-26 14:23:16 -07001592 }
1593 }
1594
Joe Perches20112472011-07-25 17:13:23 -07001595# Check the patch for a signoff:
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07001596 if ($line =~ /^\s*signed-off-by:/i) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07001597 $signoff++;
Joe Perches15662b32011-10-31 17:13:12 -07001598 $in_commit_log = 0;
Joe Perches20112472011-07-25 17:13:23 -07001599 }
1600
1601# Check signature styles
Joe Perches270c49a2012-01-10 15:09:50 -08001602 if (!$in_header_lines &&
Joe Perchesce0338df3c2012-07-30 14:41:18 -07001603 $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
Joe Perches20112472011-07-25 17:13:23 -07001604 my $space_before = $1;
1605 my $sign_off = $2;
1606 my $space_after = $3;
1607 my $email = $4;
1608 my $ucfirst_sign_off = ucfirst(lc($sign_off));
1609
Joe Perchesce0338df3c2012-07-30 14:41:18 -07001610 if ($sign_off !~ /$signature_tags/) {
1611 WARN("BAD_SIGN_OFF",
1612 "Non-standard signature: $sign_off\n" . $herecurr);
1613 }
Joe Perches20112472011-07-25 17:13:23 -07001614 if (defined $space_before && $space_before ne "") {
Joe Perches000d1cc12011-07-25 17:13:25 -07001615 WARN("BAD_SIGN_OFF",
1616 "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001617 }
Joe Perches20112472011-07-25 17:13:23 -07001618 if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001619 WARN("BAD_SIGN_OFF",
1620 "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
Joe Perches20112472011-07-25 17:13:23 -07001621 }
1622 if (!defined $space_after || $space_after ne " ") {
Joe Perches000d1cc12011-07-25 17:13:25 -07001623 WARN("BAD_SIGN_OFF",
1624 "Use a single space after $ucfirst_sign_off\n" . $herecurr);
Joe Perches20112472011-07-25 17:13:23 -07001625 }
1626
1627 my ($email_name, $email_address, $comment) = parse_email($email);
1628 my $suggested_email = format_email(($email_name, $email_address));
1629 if ($suggested_email eq "") {
Joe Perches000d1cc12011-07-25 17:13:25 -07001630 ERROR("BAD_SIGN_OFF",
1631 "Unrecognized email address: '$email'\n" . $herecurr);
Joe Perches20112472011-07-25 17:13:23 -07001632 } else {
1633 my $dequoted = $suggested_email;
1634 $dequoted =~ s/^"//;
1635 $dequoted =~ s/" </ </;
1636 # Don't force email to have quotes
1637 # Allow just an angle bracketed address
1638 if ("$dequoted$comment" ne $email &&
1639 "<$email_address>$comment" ne $email &&
1640 "$suggested_email$comment" ne $email) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001641 WARN("BAD_SIGN_OFF",
1642 "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
Joe Perches20112472011-07-25 17:13:23 -07001643 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001644 }
1645 }
1646
Andy Whitcroft00df3442007-06-08 13:47:06 -07001647# Check for wrappage within a valid hunk of the file
Andy Whitcroft8905a672007-11-28 16:21:06 -08001648 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001649 ERROR("CORRUPTED_PATCH",
1650 "patch seems to be corrupt (line wrapped?)\n" .
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07001651 $herecurr) if (!$emitted_corrupt++);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001652 }
1653
Andy Whitcroft6ecd9672008-10-15 22:02:21 -07001654# Check for absolute kernel paths.
1655 if ($tree) {
1656 while ($line =~ m{(?:^|\s)(/\S*)}g) {
1657 my $file = $1;
1658
1659 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1660 check_absolute_file($1, $herecurr)) {
1661 #
1662 } else {
1663 check_absolute_file($file, $herecurr);
1664 }
1665 }
1666 }
1667
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07001668# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1669 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001670 $rawline !~ m/^$UTF8*$/) {
1671 my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1672
1673 my $blank = copy_spacing($rawline);
1674 my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1675 my $hereptr = "$hereline$ptr\n";
1676
Joe Perches34d99212011-07-25 17:13:26 -07001677 CHK("INVALID_UTF8",
1678 "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
Andy Whitcroft00df3442007-06-08 13:47:06 -07001679 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001680
Joe Perches15662b32011-10-31 17:13:12 -07001681# Check if it's the start of a commit log
1682# (not a header line and we haven't seen the patch filename)
1683 if ($in_header_lines && $realfile =~ /^$/ &&
Joe Perches270c49a2012-01-10 15:09:50 -08001684 $rawline !~ /^(commit\b|from\b|[\w-]+:).+$/i) {
Joe Perches15662b32011-10-31 17:13:12 -07001685 $in_header_lines = 0;
1686 $in_commit_log = 1;
1687 }
1688
1689# Still not yet in a patch, check for any UTF-8
1690 if ($in_commit_log && $realfile =~ /^$/ &&
1691 $rawline =~ /$NON_ASCII_UTF8/) {
1692 CHK("UTF8_BEFORE_PATCH",
1693 "8-bit UTF-8 used in possible commit log\n" . $herecurr);
1694 }
1695
Andy Whitcroft306708542008-10-15 22:02:28 -07001696# ignore non-hunk lines and lines being removed
1697 next if (!$hunk_line || $line =~ /^-/);
Andy Whitcroft00df3442007-06-08 13:47:06 -07001698
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001699#trailing whitespace
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001700 if ($line =~ /^\+.*\015/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001701 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001702 ERROR("DOS_LINE_ENDINGS",
1703 "DOS line endings\n" . $herevet);
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001704
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001705 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1706 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001707 ERROR("TRAILING_WHITESPACE",
1708 "trailing whitespace\n" . $herevet);
Andy Whitcroftd2c0a232010-10-26 14:23:12 -07001709 $rpt_cleaners = 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001710 }
Andy Whitcroft5368df22008-10-15 22:02:27 -07001711
Andi Kleen33549572010-05-24 14:33:29 -07001712# check for Kconfig help text having a real description
Andy Whitcroft9fe287d72010-10-26 14:23:15 -07001713# Only applies when adding the entry originally, after that we do not have
1714# sufficient context to determine whether it is indeed long enough.
Andi Kleen33549572010-05-24 14:33:29 -07001715 if ($realfile =~ /Kconfig/ &&
Andy Whitcrofta1385802012-01-10 15:10:03 -08001716 $line =~ /.\s*config\s+/) {
Andi Kleen33549572010-05-24 14:33:29 -07001717 my $length = 0;
Andy Whitcroft9fe287d72010-10-26 14:23:15 -07001718 my $cnt = $realcnt;
1719 my $ln = $linenr + 1;
1720 my $f;
Andy Whitcrofta1385802012-01-10 15:10:03 -08001721 my $is_start = 0;
Andy Whitcroft9fe287d72010-10-26 14:23:15 -07001722 my $is_end = 0;
Andy Whitcrofta1385802012-01-10 15:10:03 -08001723 for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
Andy Whitcroft9fe287d72010-10-26 14:23:15 -07001724 $f = $lines[$ln - 1];
1725 $cnt-- if ($lines[$ln - 1] !~ /^-/);
1726 $is_end = $lines[$ln - 1] =~ /^\+/;
Andy Whitcroft9fe287d72010-10-26 14:23:15 -07001727
1728 next if ($f =~ /^-/);
Andy Whitcrofta1385802012-01-10 15:10:03 -08001729
1730 if ($lines[$ln - 1] =~ /.\s*(?:bool|tristate)\s*\"/) {
1731 $is_start = 1;
1732 } elsif ($lines[$ln - 1] =~ /.\s*(?:---)?help(?:---)?$/) {
1733 $length = -1;
1734 }
1735
Andy Whitcroft9fe287d72010-10-26 14:23:15 -07001736 $f =~ s/^.//;
Andi Kleen33549572010-05-24 14:33:29 -07001737 $f =~ s/#.*//;
1738 $f =~ s/^\s+//;
1739 next if ($f =~ /^$/);
Andy Whitcroft9fe287d72010-10-26 14:23:15 -07001740 if ($f =~ /^\s*config\s/) {
1741 $is_end = 1;
1742 last;
1743 }
Andi Kleen33549572010-05-24 14:33:29 -07001744 $length++;
1745 }
Joe Perches000d1cc12011-07-25 17:13:25 -07001746 WARN("CONFIG_DESCRIPTION",
Andy Whitcrofta1385802012-01-10 15:10:03 -08001747 "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
1748 #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
Andi Kleen33549572010-05-24 14:33:29 -07001749 }
1750
Arnaud Lacombec68e5872011-08-15 01:07:14 -04001751 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
1752 ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
1753 my $flag = $1;
1754 my $replacement = {
1755 'EXTRA_AFLAGS' => 'asflags-y',
1756 'EXTRA_CFLAGS' => 'ccflags-y',
1757 'EXTRA_CPPFLAGS' => 'cppflags-y',
1758 'EXTRA_LDFLAGS' => 'ldflags-y',
1759 };
1760
1761 WARN("DEPRECATED_VARIABLE",
1762 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
1763 }
1764
Andy Whitcroft5368df22008-10-15 22:02:27 -07001765# check we are in a valid source file if not then ignore this hunk
1766 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1767
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001768#80 column limit
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001769 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
Andy Whitcroftf4c014c2008-07-23 21:29:01 -07001770 $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
Joe Perches0fccc622011-05-24 17:13:41 -07001771 !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
Joe Perches8bbea962010-08-09 17:21:01 -07001772 $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
Andy Whitcroftf4c014c2008-07-23 21:29:01 -07001773 $length > 80)
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001774 {
Joe Perches000d1cc12011-07-25 17:13:25 -07001775 WARN("LONG_LINE",
1776 "line over 80 characters\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001777 }
1778
Josh Triplettca56dc02012-03-23 15:02:21 -07001779# Check for user-visible strings broken across lines, which breaks the ability
1780# to grep for the string. Limited to strings used as parameters (those
1781# following an open parenthesis), which almost completely eliminates false
1782# positives, as well as warning only once per parameter rather than once per
1783# line of the string. Make an exception when the previous string ends in a
1784# newline (multiple lines in one string constant) or \n\t (common in inline
1785# assembly to indent the instruction on the following line).
1786 if ($line =~ /^\+\s*"/ &&
1787 $prevline =~ /"\s*$/ &&
1788 $prevline =~ /\(/ &&
1789 $prevrawline !~ /\\n(?:\\t)*"\s*$/) {
1790 WARN("SPLIT_STRING",
1791 "quoted string split across lines\n" . $hereprev);
1792 }
1793
Joe Perches5e79d962010-03-05 13:43:55 -08001794# check for spaces before a quoted newline
1795 if ($rawline =~ /^.*\".*\s\\n/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001796 WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
1797 "unnecessary whitespace before a quoted newline\n" . $herecurr);
Joe Perches5e79d962010-03-05 13:43:55 -08001798 }
1799
Andy Whitcroft8905a672007-11-28 16:21:06 -08001800# check for adding lines without a newline.
1801 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001802 WARN("MISSING_EOF_NEWLINE",
1803 "adding a line without newline at end of file\n" . $herecurr);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001804 }
1805
Mike Frysinger42e41c52009-09-21 17:04:40 -07001806# Blackfin: use hi/lo macros
1807 if ($realfile =~ m@arch/blackfin/.*\.S$@) {
1808 if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
1809 my $herevet = "$here\n" . cat_vet($line) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001810 ERROR("LO_MACRO",
1811 "use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
Mike Frysinger42e41c52009-09-21 17:04:40 -07001812 }
1813 if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
1814 my $herevet = "$here\n" . cat_vet($line) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001815 ERROR("HI_MACRO",
1816 "use the HI() macro, not (... >> 16)\n" . $herevet);
Mike Frysinger42e41c52009-09-21 17:04:40 -07001817 }
1818 }
1819
Andy Whitcroftb9ea10d2008-10-15 22:02:24 -07001820# check we are in a valid source file C or perl if not then ignore this hunk
1821 next if ($realfile !~ /\.(h|c|pl)$/);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001822
1823# at the beginning of a line any tabs must come first and anything
1824# more than 8 must use tabs.
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001825 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1826 $rawline =~ /^\+\s* \s*/) {
1827 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001828 ERROR("CODE_INDENT",
1829 "code indent should use tabs where possible\n" . $herevet);
Andy Whitcroftd2c0a232010-10-26 14:23:12 -07001830 $rpt_cleaners = 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07001831 }
1832
Alberto Panizzo08e44362010-03-05 13:43:54 -08001833# check for space before tabs.
1834 if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
1835 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001836 WARN("SPACE_BEFORE_TAB",
1837 "please, no space before tabs\n" . $herevet);
Alberto Panizzo08e44362010-03-05 13:43:54 -08001838 }
1839
Joe Perchesd1fe9c02012-03-23 15:02:16 -07001840# check for && or || at the start of a line
1841 if ($rawline =~ /^\+\s*(&&|\|\|)/) {
1842 CHK("LOGICAL_CONTINUATIONS",
1843 "Logical continuations should be on the previous line\n" . $hereprev);
1844 }
1845
1846# check multi-line statement indentation matches previous line
1847 if ($^V && $^V ge 5.10.0 &&
1848 $prevline =~ /^\+(\t*)(if \(|$Ident\().*(\&\&|\|\||,)\s*$/) {
1849 $prevline =~ /^\+(\t*)(.*)$/;
1850 my $oldindent = $1;
1851 my $rest = $2;
1852
1853 my $pos = pos_last_openparen($rest);
1854 if ($pos >= 0) {
Joe Perchesb34a26f2012-07-30 14:41:16 -07001855 $line =~ /^(\+| )([ \t]*)/;
1856 my $newindent = $2;
Joe Perchesd1fe9c02012-03-23 15:02:16 -07001857
1858 my $goodtabindent = $oldindent .
1859 "\t" x ($pos / 8) .
1860 " " x ($pos % 8);
1861 my $goodspaceindent = $oldindent . " " x $pos;
1862
1863 if ($newindent ne $goodtabindent &&
1864 $newindent ne $goodspaceindent) {
1865 CHK("PARENTHESIS_ALIGNMENT",
1866 "Alignment should match open parenthesis\n" . $hereprev);
1867 }
1868 }
1869 }
1870
Joe Perchesaad4f612012-03-23 15:02:19 -07001871 if ($line =~ /^\+.*\*[ \t]*\)[ \t]+/) {
1872 CHK("SPACING",
1873 "No space is necessary after a cast\n" . $hereprev);
1874 }
1875
Raffaele Recalcati5f7ddae2010-08-09 17:20:59 -07001876# check for spaces at the beginning of a line.
Andy Whitcroft6b4c5be2010-10-26 14:23:11 -07001877# Exceptions:
1878# 1) within comments
1879# 2) indented preprocessor commands
1880# 3) hanging labels
1881 if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/) {
Raffaele Recalcati5f7ddae2010-08-09 17:20:59 -07001882 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001883 WARN("LEADING_SPACE",
1884 "please, no spaces at the start of a line\n" . $herevet);
Raffaele Recalcati5f7ddae2010-08-09 17:20:59 -07001885 }
1886
Andy Whitcroftb9ea10d2008-10-15 22:02:24 -07001887# check we are in a valid C source file if not then ignore this hunk
1888 next if ($realfile !~ /\.(h|c)$/);
1889
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001890# check for RCS/CVS revision markers
Andy Whitcroftcf655042008-03-04 14:28:20 -08001891 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07001892 WARN("CVS_KEYWORD",
1893 "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001894 }
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07001895
Mike Frysinger42e41c52009-09-21 17:04:40 -07001896# Blackfin: don't use __builtin_bfin_[cs]sync
1897 if ($line =~ /__builtin_bfin_csync/) {
1898 my $herevet = "$here\n" . cat_vet($line) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001899 ERROR("CSYNC",
1900 "use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
Mike Frysinger42e41c52009-09-21 17:04:40 -07001901 }
1902 if ($line =~ /__builtin_bfin_ssync/) {
1903 my $herevet = "$here\n" . cat_vet($line) . "\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07001904 ERROR("SSYNC",
1905 "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
Mike Frysinger42e41c52009-09-21 17:04:40 -07001906 }
1907
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001908# Check for potential 'bare' types
Andy Whitcroft2b474a12009-10-26 16:50:16 -07001909 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
1910 $realline_next);
Andy Whitcroft3e469cd2012-01-10 15:10:01 -08001911#print "LINE<$line>\n";
1912 if ($linenr >= $suppress_statement &&
1913 $realcnt && $line =~ /.\s*\S/) {
Andy Whitcroft170d3a22008-10-15 22:02:30 -07001914 ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
Andy Whitcroftf5fe35d2008-07-23 21:29:03 -07001915 ctx_statement_block($linenr, $realcnt, 0);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001916 $stat =~ s/\n./\n /g;
1917 $cond =~ s/\n./\n /g;
1918
Andy Whitcroft3e469cd2012-01-10 15:10:01 -08001919#print "linenr<$linenr> <$stat>\n";
1920 # If this statement has no statement boundaries within
1921 # it there is no point in retrying a statement scan
1922 # until we hit end of it.
1923 my $frag = $stat; $frag =~ s/;+\s*$//;
1924 if ($frag !~ /(?:{|;)/) {
1925#print "skip<$line_nr_next>\n";
1926 $suppress_statement = $line_nr_next;
1927 }
Andy Whitcroftf74bd192012-01-10 15:09:54 -08001928
Andy Whitcroft2b474a12009-10-26 16:50:16 -07001929 # Find the real next line.
1930 $realline_next = $line_nr_next;
1931 if (defined $realline_next &&
1932 (!defined $lines[$realline_next - 1] ||
1933 substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
1934 $realline_next++;
1935 }
1936
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001937 my $s = $stat;
1938 $s =~ s/{.*$//s;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001939
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001940 # Ignore goto labels.
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001941 if ($s =~ /$Ident:\*$/s) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001942
1943 # Ignore functions being called
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001944 } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001945
Andy Whitcroft463f2862009-09-21 17:04:34 -07001946 } elsif ($s =~ /^.\s*else\b/s) {
1947
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001948 # declarations always start with types
Andy Whitcroftd2506582008-07-23 21:29:09 -07001949 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001950 my $type = $1;
1951 $type =~ s/\s+/ /g;
1952 possible($type, "A:" . $s);
1953
Andy Whitcroft8905a672007-11-28 16:21:06 -08001954 # definitions in global scope can only start with types
Andy Whitcrofta6a840622008-10-15 22:02:30 -07001955 } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001956 possible($1, "B:" . $s);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08001957 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08001958
1959 # any (foo ... *) is a pointer cast, and foo is a type
Andy Whitcroft65863862009-01-06 14:41:21 -08001960 while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001961 possible($1, "C:" . $s);
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001962 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08001963
1964 # Check for any sort of function declaration.
1965 # int foo(something bar, other baz);
1966 # void (*store_gdt)(x86_descr_ptr *);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07001967 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
Andy Whitcroft8905a672007-11-28 16:21:06 -08001968 my ($name_len) = length($1);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001969
Andy Whitcroftcf655042008-03-04 14:28:20 -08001970 my $ctx = $s;
Andy Whitcroft773647a2008-03-28 14:15:58 -07001971 substr($ctx, 0, $name_len + 1, '');
Andy Whitcroft8905a672007-11-28 16:21:06 -08001972 $ctx =~ s/\)[^\)]*$//;
Andy Whitcroftcf655042008-03-04 14:28:20 -08001973
Andy Whitcroft8905a672007-11-28 16:21:06 -08001974 for my $arg (split(/\s*,\s*/, $ctx)) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001975 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
Andy Whitcroft8905a672007-11-28 16:21:06 -08001976
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07001977 possible($1, "D:" . $s);
Andy Whitcroft8905a672007-11-28 16:21:06 -08001978 }
1979 }
1980 }
1981
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07001982 }
1983
Andy Whitcroft653d4872007-06-23 17:16:34 -07001984#
1985# Checks which may be anchored in the context.
1986#
1987
1988# Check for switch () and associated case and default
1989# statements should be at the same indent.
Andy Whitcroft00df3442007-06-08 13:47:06 -07001990 if ($line=~/\bswitch\s*\(.*\)/) {
1991 my $err = '';
1992 my $sep = '';
1993 my @ctx = ctx_block_outer($linenr, $realcnt);
1994 shift(@ctx);
1995 for my $ctx (@ctx) {
1996 my ($clen, $cindent) = line_stats($ctx);
1997 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1998 $indent != $cindent) {
1999 $err .= "$sep$ctx\n";
2000 $sep = '';
2001 } else {
2002 $sep = "[...]\n";
2003 }
2004 }
2005 if ($err ne '') {
Joe Perches000d1cc12011-07-25 17:13:25 -07002006 ERROR("SWITCH_CASE_INDENT_LEVEL",
2007 "switch and case should be at the same indent\n$hereline$err");
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002008 }
2009 }
2010
2011# if/while/etc brace do not go on next line, unless defining a do while loop,
2012# or if that brace on the next line is for something else
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002013 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07002014 my $pre_ctx = "$1$2";
2015
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002016 my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
Joe Perches8eef05d2012-02-03 15:20:39 -08002017
2018 if ($line =~ /^\+\t{6,}/) {
2019 WARN("DEEP_INDENTATION",
2020 "Too many leading tabs - consider code refactoring\n" . $herecurr);
2021 }
2022
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002023 my $ctx_cnt = $realcnt - $#ctx - 1;
2024 my $ctx = join("\n", @ctx);
2025
Andy Whitcroft548596d2008-07-23 21:29:01 -07002026 my $ctx_ln = $linenr;
2027 my $ctx_skip = $realcnt;
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002028
Andy Whitcroft548596d2008-07-23 21:29:01 -07002029 while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
2030 defined $lines[$ctx_ln - 1] &&
2031 $lines[$ctx_ln - 1] =~ /^-/)) {
2032 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2033 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
Andy Whitcroft773647a2008-03-28 14:15:58 -07002034 $ctx_ln++;
2035 }
Andy Whitcroft548596d2008-07-23 21:29:01 -07002036
Andy Whitcroft53210162008-07-23 21:29:03 -07002037 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2038 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
Andy Whitcroft773647a2008-03-28 14:15:58 -07002039
2040 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002041 ERROR("OPEN_BRACE",
2042 "that open brace { should be on the previous line\n" .
Andy Whitcroft01464f32010-10-26 14:23:19 -07002043 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
Andy Whitcroft00df3442007-06-08 13:47:06 -07002044 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07002045 if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
2046 $ctx =~ /\)\s*\;\s*$/ &&
2047 defined $lines[$ctx_ln - 1])
2048 {
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002049 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
2050 if ($nindent > $indent) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002051 WARN("TRAILING_SEMICOLON",
2052 "trailing semicolon indicates no statements, indent implies otherwise\n" .
Andy Whitcroft01464f32010-10-26 14:23:19 -07002053 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002054 }
2055 }
Andy Whitcroft00df3442007-06-08 13:47:06 -07002056 }
2057
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002058# Check relative indent for conditionals and blocks.
2059 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
Andy Whitcroft3e469cd2012-01-10 15:10:01 -08002060 ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2061 ctx_statement_block($linenr, $realcnt, 0)
2062 if (!defined $stat);
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002063 my ($s, $c) = ($stat, $cond);
2064
2065 substr($s, 0, length($c), '');
2066
2067 # Make sure we remove the line prefixes as we have
2068 # none on the first line, and are going to readd them
2069 # where necessary.
2070 $s =~ s/\n./\n/gs;
2071
2072 # Find out how long the conditional actually is.
Andy Whitcroft6f779c12008-10-15 22:02:27 -07002073 my @newlines = ($c =~ /\n/gs);
2074 my $cond_lines = 1 + $#newlines;
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002075
2076 # We want to check the first line inside the block
2077 # starting at the end of the conditional, so remove:
2078 # 1) any blank line termination
2079 # 2) any opening brace { on end of the line
2080 # 3) any do (...) {
2081 my $continuation = 0;
2082 my $check = 0;
2083 $s =~ s/^.*\bdo\b//;
2084 $s =~ s/^\s*{//;
2085 if ($s =~ s/^\s*\\//) {
2086 $continuation = 1;
2087 }
Andy Whitcroft9bd49ef2008-10-15 22:02:22 -07002088 if ($s =~ s/^\s*?\n//) {
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002089 $check = 1;
2090 $cond_lines++;
2091 }
2092
2093 # Also ignore a loop construct at the end of a
2094 # preprocessor statement.
2095 if (($prevline =~ /^.\s*#\s*define\s/ ||
2096 $prevline =~ /\\\s*$/) && $continuation == 0) {
2097 $check = 0;
2098 }
2099
Andy Whitcroft9bd49ef2008-10-15 22:02:22 -07002100 my $cond_ptr = -1;
Andy Whitcroft740504c2008-10-15 22:02:35 -07002101 $continuation = 0;
Andy Whitcroft9bd49ef2008-10-15 22:02:22 -07002102 while ($cond_ptr != $cond_lines) {
2103 $cond_ptr = $cond_lines;
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002104
Andy Whitcroftf16fa282008-10-15 22:02:32 -07002105 # If we see an #else/#elif then the code
2106 # is not linear.
2107 if ($s =~ /^\s*\#\s*(?:else|elif)/) {
2108 $check = 0;
2109 }
2110
Andy Whitcroft9bd49ef2008-10-15 22:02:22 -07002111 # Ignore:
2112 # 1) blank lines, they should be at 0,
2113 # 2) preprocessor lines, and
2114 # 3) labels.
Andy Whitcroft740504c2008-10-15 22:02:35 -07002115 if ($continuation ||
2116 $s =~ /^\s*?\n/ ||
Andy Whitcroft9bd49ef2008-10-15 22:02:22 -07002117 $s =~ /^\s*#\s*?/ ||
2118 $s =~ /^\s*$Ident\s*:/) {
Andy Whitcroft740504c2008-10-15 22:02:35 -07002119 $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
Andy Whitcroft30dad6e2009-09-21 17:04:36 -07002120 if ($s =~ s/^.*?\n//) {
2121 $cond_lines++;
2122 }
Andy Whitcroft9bd49ef2008-10-15 22:02:22 -07002123 }
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002124 }
2125
2126 my (undef, $sindent) = line_stats("+" . $s);
2127 my $stat_real = raw_line($linenr, $cond_lines);
2128
2129 # Check if either of these lines are modified, else
2130 # this is not this patch's fault.
2131 if (!defined($stat_real) ||
2132 $stat !~ /^\+/ && $stat_real !~ /^\+/) {
2133 $check = 0;
2134 }
2135 if (defined($stat_real) && $cond_lines > 1) {
2136 $stat_real = "[...]\n$stat_real";
2137 }
2138
Andy Whitcroft9bd49ef2008-10-15 22:02:22 -07002139 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002140
2141 if ($check && (($sindent % 8) != 0 ||
2142 ($sindent <= $indent && $s ne ''))) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002143 WARN("SUSPECT_CODE_INDENT",
2144 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
Andy Whitcroft4d001e42008-10-15 22:02:21 -07002145 }
2146 }
2147
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002148 # Track the 'values' across context and added lines.
2149 my $opline = $line; $opline =~ s/^./ /;
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002150 my ($curr_values, $curr_vars) =
2151 annotate_values($opline . "\n", $prev_values);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002152 $curr_values = $prev_values . $curr_values;
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002153 if ($dbg_values) {
2154 my $outline = $opline; $outline =~ s/\t/ /g;
Andy Whitcroftcf655042008-03-04 14:28:20 -08002155 print "$linenr > .$outline\n";
2156 print "$linenr > $curr_values\n";
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002157 print "$linenr > $curr_vars\n";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002158 }
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002159 $prev_values = substr($curr_values, -1);
2160
Andy Whitcroft00df3442007-06-08 13:47:06 -07002161#ignore lines not being added
2162 if ($line=~/^[^\+]/) {next;}
2163
Andy Whitcroft653d4872007-06-23 17:16:34 -07002164# TEST: allow direct testing of the type matcher.
Andy Whitcroft7429c692008-07-23 21:29:06 -07002165 if ($dbg_type) {
2166 if ($line =~ /^.\s*$Declare\s*$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002167 ERROR("TEST_TYPE",
2168 "TEST: is type\n" . $herecurr);
Andy Whitcroft7429c692008-07-23 21:29:06 -07002169 } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002170 ERROR("TEST_NOT_TYPE",
2171 "TEST: is not type ($1 is)\n". $herecurr);
Andy Whitcroft7429c692008-07-23 21:29:06 -07002172 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002173 next;
2174 }
Andy Whitcrofta1ef2772008-10-15 22:02:17 -07002175# TEST: allow direct testing of the attribute matcher.
2176 if ($dbg_attr) {
Andy Whitcroft9360b0e2009-02-27 14:03:08 -08002177 if ($line =~ /^.\s*$Modifier\s*$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002178 ERROR("TEST_ATTR",
2179 "TEST: is attr\n" . $herecurr);
Andy Whitcroft9360b0e2009-02-27 14:03:08 -08002180 } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002181 ERROR("TEST_NOT_ATTR",
2182 "TEST: is not attr ($1 is)\n". $herecurr);
Andy Whitcrofta1ef2772008-10-15 22:02:17 -07002183 }
2184 next;
2185 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002186
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002187# check for initialisation to aggregates open brace on the next line
Andy Whitcroft99423c22009-10-26 16:50:15 -07002188 if ($line =~ /^.\s*{/ &&
2189 $prevline =~ /(?:^|[^=])=\s*$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002190 ERROR("OPEN_BRACE",
2191 "that open brace { should be on the previous line\n" . $hereprev);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002192 }
2193
Andy Whitcroft653d4872007-06-23 17:16:34 -07002194#
2195# Checks which are anchored on the added line.
2196#
2197
2198# check for malformed paths in #include statements (uses RAW line)
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002199 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
Andy Whitcroft653d4872007-06-23 17:16:34 -07002200 my $path = $1;
2201 if ($path =~ m{//}) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002202 ERROR("MALFORMED_INCLUDE",
2203 "malformed #include filename\n" .
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002204 $herecurr);
Andy Whitcroft653d4872007-06-23 17:16:34 -07002205 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002206 }
Andy Whitcroft00df3442007-06-08 13:47:06 -07002207
2208# no C99 // comments
2209 if ($line =~ m{//}) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002210 ERROR("C99_COMMENTS",
2211 "do not use C99 // comments\n" . $herecurr);
Andy Whitcroft00df3442007-06-08 13:47:06 -07002212 }
2213 # Remove C99 comments.
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002214 $line =~ s@//.*@@;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002215 $opline =~ s@//.*@@;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002216
Andy Whitcroft2b474a12009-10-26 16:50:16 -07002217# EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
2218# the whole statement.
2219#print "APW <$lines[$realline_next - 1]>\n";
2220 if (defined $realline_next &&
2221 exists $lines[$realline_next - 1] &&
2222 !defined $suppress_export{$realline_next} &&
2223 ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2224 $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
Andy Whitcroft3cbf62d2010-10-26 14:23:18 -07002225 # Handle definitions which produce identifiers with
2226 # a prefix:
2227 # XXX(foo);
2228 # EXPORT_SYMBOL(something_foo);
Andy Whitcroft653d4872007-06-23 17:16:34 -07002229 my $name = $1;
Andy Whitcroft87a53872012-01-10 15:10:04 -08002230 if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
Andy Whitcroft3cbf62d2010-10-26 14:23:18 -07002231 $name =~ /^${Ident}_$2/) {
2232#print "FOO C name<$name>\n";
2233 $suppress_export{$realline_next} = 1;
2234
2235 } elsif ($stat !~ /(?:
Andy Whitcroft2b474a12009-10-26 16:50:16 -07002236 \n.}\s*$|
Andy Whitcroft48012052008-10-15 22:02:34 -07002237 ^.DEFINE_$Ident\(\Q$name\E\)|
2238 ^.DECLARE_$Ident\(\Q$name\E\)|
2239 ^.LIST_HEAD\(\Q$name\E\)|
Andy Whitcroft2b474a12009-10-26 16:50:16 -07002240 ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
2241 \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
Andy Whitcroft48012052008-10-15 22:02:34 -07002242 )/x) {
Andy Whitcroft2b474a12009-10-26 16:50:16 -07002243#print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
2244 $suppress_export{$realline_next} = 2;
2245 } else {
2246 $suppress_export{$realline_next} = 1;
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002247 }
2248 }
Andy Whitcroft2b474a12009-10-26 16:50:16 -07002249 if (!defined $suppress_export{$linenr} &&
2250 $prevline =~ /^.\s*$/ &&
2251 ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2252 $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2253#print "FOO B <$lines[$linenr - 1]>\n";
2254 $suppress_export{$linenr} = 2;
2255 }
2256 if (defined $suppress_export{$linenr} &&
2257 $suppress_export{$linenr} == 2) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002258 WARN("EXPORT_SYMBOL",
2259 "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
Andy Whitcroft2b474a12009-10-26 16:50:16 -07002260 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002261
Joe Eloff5150bda2010-08-09 17:21:00 -07002262# check for global initialisers.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002263 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002264 ERROR("GLOBAL_INITIALISERS",
2265 "do not initialise globals to 0 or NULL\n" .
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002266 $herecurr);
2267 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002268# check for static initialisers.
Andy Whitcroft2d1bafd2009-01-06 14:41:28 -08002269 if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002270 ERROR("INITIALISED_STATIC",
2271 "do not initialise statics to 0 or NULL\n" .
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002272 $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002273 }
2274
Joe Perchescb710ec2010-10-26 14:23:20 -07002275# check for static const char * arrays.
2276 if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002277 WARN("STATIC_CONST_CHAR_ARRAY",
2278 "static const char * array should probably be static const char * const\n" .
Joe Perchescb710ec2010-10-26 14:23:20 -07002279 $herecurr);
2280 }
2281
2282# check for static char foo[] = "bar" declarations.
2283 if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002284 WARN("STATIC_CONST_CHAR_ARRAY",
2285 "static char array declaration should probably be static const char\n" .
Joe Perchescb710ec2010-10-26 14:23:20 -07002286 $herecurr);
2287 }
2288
Joe Perches93ed0e22010-10-26 14:23:21 -07002289# check for declarations of struct pci_device_id
2290 if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002291 WARN("DEFINE_PCI_DEVICE_TABLE",
2292 "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
Joe Perches93ed0e22010-10-26 14:23:21 -07002293 }
2294
Andy Whitcroft653d4872007-06-23 17:16:34 -07002295# check for new typedefs, only function parameters and sparse annotations
2296# make sense.
2297 if ($line =~ /\btypedef\s/ &&
Andy Whitcroft80545762009-01-06 14:41:26 -08002298 $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002299 $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
Andy Whitcroft8ed22ca2008-10-15 22:02:32 -07002300 $line !~ /\b$typeTypedefs\b/ &&
Andy Whitcroft653d4872007-06-23 17:16:34 -07002301 $line !~ /\b__bitwise(?:__|)\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002302 WARN("NEW_TYPEDEFS",
2303 "do not add new typedefs\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002304 }
2305
2306# * goes on variable not on type
Andy Whitcroft65863862009-01-06 14:41:21 -08002307 # (char*[ const])
Andy Whitcroftbfcb2cc2012-01-10 15:10:15 -08002308 while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
2309 #print "AA<$1>\n";
2310 my ($from, $to) = ($2, $2);
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002311
Andy Whitcroft65863862009-01-06 14:41:21 -08002312 # Should start with a space.
2313 $to =~ s/^(\S)/ $1/;
2314 # Should not end with a space.
2315 $to =~ s/\s+$//;
2316 # '*'s should not have spaces between.
Andy Whitcroftf9a0b3d2009-01-15 13:51:05 -08002317 while ($to =~ s/\*\s+\*/\*\*/) {
Andy Whitcroft65863862009-01-06 14:41:21 -08002318 }
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002319
Andy Whitcroft65863862009-01-06 14:41:21 -08002320 #print "from<$from> to<$to>\n";
2321 if ($from ne $to) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002322 ERROR("POINTER_LOCATION",
2323 "\"(foo$from)\" should be \"(foo$to)\"\n" . $herecurr);
Andy Whitcroft65863862009-01-06 14:41:21 -08002324 }
Andy Whitcroftbfcb2cc2012-01-10 15:10:15 -08002325 }
2326 while ($line =~ m{(\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident))}g) {
2327 #print "BB<$1>\n";
2328 my ($from, $to, $ident) = ($2, $2, $3);
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002329
Andy Whitcroft65863862009-01-06 14:41:21 -08002330 # Should start with a space.
2331 $to =~ s/^(\S)/ $1/;
2332 # Should not end with a space.
2333 $to =~ s/\s+$//;
2334 # '*'s should not have spaces between.
Andy Whitcroftf9a0b3d2009-01-15 13:51:05 -08002335 while ($to =~ s/\*\s+\*/\*\*/) {
Andy Whitcroft65863862009-01-06 14:41:21 -08002336 }
2337 # Modifiers should have spaces.
2338 $to =~ s/(\b$Modifier$)/$1 /;
2339
Andy Whitcroft667026e2009-02-27 14:03:08 -08002340 #print "from<$from> to<$to> ident<$ident>\n";
2341 if ($from ne $to && $ident !~ /^$Modifier$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002342 ERROR("POINTER_LOCATION",
2343 "\"foo${from}bar\" should be \"foo${to}bar\"\n" . $herecurr);
Andy Whitcroft65863862009-01-06 14:41:21 -08002344 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002345 }
2346
2347# # no BUG() or BUG_ON()
2348# if ($line =~ /\b(BUG|BUG_ON)\b/) {
2349# print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
2350# print "$herecurr";
2351# $clean = 0;
2352# }
2353
Andy Whitcroft8905a672007-11-28 16:21:06 -08002354 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002355 WARN("LINUX_VERSION_CODE",
2356 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
Andy Whitcroft8905a672007-11-28 16:21:06 -08002357 }
2358
Joe Perches17441222011-06-15 15:08:17 -07002359# check for uses of printk_ratelimit
2360 if ($line =~ /\bprintk_ratelimit\s*\(/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002361 WARN("PRINTK_RATELIMITED",
2362"Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
Joe Perches17441222011-06-15 15:08:17 -07002363 }
2364
Andy Whitcroft00df3442007-06-08 13:47:06 -07002365# printk should use KERN_* levels. Note that follow on printk's on the
2366# same line do not need a level, so we use the current block context
2367# to try and find and validate the current printk. In summary the current
Lucas De Marchi25985ed2011-03-30 22:57:33 -03002368# printk includes all preceding printk's which have no newline on the end.
Andy Whitcroft00df3442007-06-08 13:47:06 -07002369# we assume the first bad printk is the one to report.
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002370 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
Andy Whitcroft00df3442007-06-08 13:47:06 -07002371 my $ok = 0;
2372 for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
2373 #print "CHECK<$lines[$ln - 1]\n";
Lucas De Marchi25985ed2011-03-30 22:57:33 -03002374 # we have a preceding printk if it ends
Andy Whitcroft00df3442007-06-08 13:47:06 -07002375 # with "\n" ignore it, else it is to blame
2376 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
2377 if ($rawlines[$ln - 1] !~ m{\\n"}) {
2378 $ok = 1;
2379 }
2380 last;
2381 }
2382 }
2383 if ($ok == 0) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002384 WARN("PRINTK_WITHOUT_KERN_LEVEL",
2385 "printk() should include KERN_ facility level\n" . $herecurr);
Andy Whitcroft00df3442007-06-08 13:47:06 -07002386 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002387 }
2388
Joe Perches243f3802012-05-31 16:26:09 -07002389 if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
2390 my $orig = $1;
2391 my $level = lc($orig);
2392 $level = "warn" if ($level eq "warning");
2393 WARN("PREFER_PR_LEVEL",
2394 "Prefer pr_$level(... to printk(KERN_$1, ...\n" . $herecurr);
2395 }
2396
2397 if ($line =~ /\bpr_warning\s*\(/) {
2398 WARN("PREFER_PR_LEVEL",
2399 "Prefer pr_warn(... to pr_warning(...\n" . $herecurr);
2400 }
2401
Andy Whitcroft653d4872007-06-23 17:16:34 -07002402# function brace can't be on same line, except for #defines of do while,
2403# or if closed on same line
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002404 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
2405 !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002406 ERROR("OPEN_BRACE",
2407 "open brace '{' following function declarations go on the next line\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002408 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002409
Andy Whitcroft8905a672007-11-28 16:21:06 -08002410# open braces for enum, union and struct go on the same line.
2411 if ($line =~ /^.\s*{/ &&
2412 $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002413 ERROR("OPEN_BRACE",
2414 "open brace '{' following $1 go on the same line\n" . $hereprev);
Andy Whitcroft8905a672007-11-28 16:21:06 -08002415 }
2416
Andy Whitcroft0c73b4e2010-10-26 14:23:15 -07002417# missing space after union, struct or enum definition
2418 if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002419 WARN("SPACING",
2420 "missing space after $1 definition\n" . $herecurr);
Andy Whitcroft0c73b4e2010-10-26 14:23:15 -07002421 }
2422
Andy Whitcroft8d31cfc2008-07-23 21:29:02 -07002423# check for spacing round square brackets; allowed:
2424# 1. with a type on the left -- int [] a;
Andy Whitcroftfe2a7db2008-10-15 22:02:15 -07002425# 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
2426# 3. inside a curly brace -- = { [0...10] = 5 }
Andy Whitcroft8d31cfc2008-07-23 21:29:02 -07002427 while ($line =~ /(.*?\s)\[/g) {
2428 my ($where, $prefix) = ($-[1], $1);
2429 if ($prefix !~ /$Type\s+$/ &&
Andy Whitcroftfe2a7db2008-10-15 22:02:15 -07002430 ($where != 0 || $prefix !~ /^.\s+$/) &&
Andy Whitcroftdaebc532012-03-23 15:02:17 -07002431 $prefix !~ /[{,]\s+$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002432 ERROR("BRACKET_SPACE",
2433 "space prohibited before open square bracket '['\n" . $herecurr);
Andy Whitcroft8d31cfc2008-07-23 21:29:02 -07002434 }
2435 }
2436
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002437# check for spaces between functions and their parentheses.
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002438 while ($line =~ /($Ident)\s+\(/g) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002439 my $name = $1;
Andy Whitcroft773647a2008-03-28 14:15:58 -07002440 my $ctx_before = substr($line, 0, $-[1]);
2441 my $ctx = "$ctx_before$name";
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002442
2443 # Ignore those directives where spaces _are_ permitted.
Andy Whitcroft773647a2008-03-28 14:15:58 -07002444 if ($name =~ /^(?:
2445 if|for|while|switch|return|case|
2446 volatile|__volatile__|
2447 __attribute__|format|__extension__|
2448 asm|__asm__)$/x)
2449 {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002450
2451 # cpp #define statements have non-optional spaces, ie
2452 # if there is a space between the name and the open
2453 # parenthesis it is simply not a parameter group.
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002454 } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07002455
2456 # cpp #elif statement condition may start with a (
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002457 } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002458
2459 # If this whole things ends with a type its most
2460 # likely a typedef for a function.
Andy Whitcroft773647a2008-03-28 14:15:58 -07002461 } elsif ($ctx =~ /$Type$/) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002462
2463 } else {
Joe Perches000d1cc12011-07-25 17:13:25 -07002464 WARN("SPACING",
2465 "space prohibited between function name and open parenthesis '('\n" . $herecurr);
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002466 }
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002467 }
Eric Nelson9a4cad42012-05-31 16:26:09 -07002468
2469# check for whitespace before a non-naked semicolon
2470 if ($line =~ /^\+.*\S\s+;/) {
2471 CHK("SPACING",
2472 "space prohibited before semicolon\n" . $herecurr);
2473 }
2474
Andy Whitcroft653d4872007-06-23 17:16:34 -07002475# Check operator spacing.
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002476 if (!($line=~/\#\s*include/)) {
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002477 my $ops = qr{
2478 <<=|>>=|<=|>=|==|!=|
2479 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
2480 =>|->|<<|>>|<|>|=|!|~|
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002481 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
2482 \?|:
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002483 }x;
Andy Whitcroftcf655042008-03-04 14:28:20 -08002484 my @elements = split(/($ops|;)/, $opline);
Andy Whitcroft00df3442007-06-08 13:47:06 -07002485 my $off = 0;
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002486
2487 my $blank = copy_spacing($opline);
2488
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002489 for (my $n = 0; $n < $#elements; $n += 2) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002490 $off += length($elements[$n]);
2491
Lucas De Marchi25985ed2011-03-30 22:57:33 -03002492 # Pick up the preceding and succeeding characters.
Andy Whitcroft773647a2008-03-28 14:15:58 -07002493 my $ca = substr($opline, 0, $off);
2494 my $cc = '';
2495 if (length($opline) >= ($off + length($elements[$n + 1]))) {
2496 $cc = substr($opline, $off + length($elements[$n + 1]));
2497 }
2498 my $cb = "$ca$;$cc";
2499
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002500 my $a = '';
2501 $a = 'V' if ($elements[$n] ne '');
2502 $a = 'W' if ($elements[$n] =~ /\s$/);
Andy Whitcroftcf655042008-03-04 14:28:20 -08002503 $a = 'C' if ($elements[$n] =~ /$;$/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002504 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
2505 $a = 'O' if ($elements[$n] eq '');
Andy Whitcroft773647a2008-03-28 14:15:58 -07002506 $a = 'E' if ($ca =~ /^\s*$/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002507
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002508 my $op = $elements[$n + 1];
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002509
2510 my $c = '';
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002511 if (defined $elements[$n + 2]) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002512 $c = 'V' if ($elements[$n + 2] ne '');
2513 $c = 'W' if ($elements[$n + 2] =~ /^\s/);
Andy Whitcroftcf655042008-03-04 14:28:20 -08002514 $c = 'C' if ($elements[$n + 2] =~ /^$;/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002515 $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
2516 $c = 'O' if ($elements[$n + 2] eq '');
Andy Whitcroft8b1b3372009-01-06 14:41:27 -08002517 $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002518 } else {
2519 $c = 'E';
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002520 }
2521
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002522 my $ctx = "${a}x${c}";
2523
2524 my $at = "(ctx:$ctx)";
2525
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002526 my $ptr = substr($blank, 0, $off) . "^";
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002527 my $hereptr = "$hereline$ptr\n";
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002528
Andy Whitcroft74048ed2008-07-23 21:29:10 -07002529 # Pull out the value of this operator.
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07002530 my $op_type = substr($curr_values, $off + 1, 1);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002531
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002532 # Get the full operator variant.
2533 my $opv = $op . substr($curr_vars, $off, 1);
2534
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002535 # Ignore operators passed as parameters.
2536 if ($op_type ne 'V' &&
2537 $ca =~ /\s$/ && $cc =~ /^\s*,/) {
2538
Andy Whitcroftcf655042008-03-04 14:28:20 -08002539# # Ignore comments
2540# } elsif ($op =~ /^$;+$/) {
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002541
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002542 # ; should have either the end of line or a space or \ after it
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002543 } elsif ($op eq ';') {
Andy Whitcroftcf655042008-03-04 14:28:20 -08002544 if ($ctx !~ /.x[WEBC]/ &&
2545 $cc !~ /^\\/ && $cc !~ /^;/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002546 ERROR("SPACING",
2547 "space required after that '$op' $at\n" . $hereptr);
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002548 }
2549
2550 # // is a comment
2551 } elsif ($op eq '//') {
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002552
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002553 # No spaces for:
2554 # ->
2555 # : when part of a bitfield
2556 } elsif ($op eq '->' || $opv eq ':B') {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002557 if ($ctx =~ /Wx.|.xW/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002558 ERROR("SPACING",
2559 "spaces prohibited around that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002560 }
2561
2562 # , must have a space on the right.
2563 } elsif ($op eq ',') {
Andy Whitcroftcf655042008-03-04 14:28:20 -08002564 if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002565 ERROR("SPACING",
2566 "space required after that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002567 }
2568
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002569 # '*' as part of a type definition -- reported already.
Andy Whitcroft74048ed2008-07-23 21:29:10 -07002570 } elsif ($opv eq '*_') {
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002571 #warn "'*' is part of type\n";
2572
2573 # unary operators should have a space before and
2574 # none after. May be left adjacent to another
2575 # unary operator, or a cast
2576 } elsif ($op eq '!' || $op eq '~' ||
Andy Whitcroft74048ed2008-07-23 21:29:10 -07002577 $opv eq '*U' || $opv eq '-U' ||
Andy Whitcroft0d413862008-10-15 22:02:16 -07002578 $opv eq '&U' || $opv eq '&&U') {
Andy Whitcroftcf655042008-03-04 14:28:20 -08002579 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002580 ERROR("SPACING",
2581 "space required before that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002582 }
Andy Whitcrofta3340b32009-02-27 14:03:07 -08002583 if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002584 # A unary '*' may be const
2585
2586 } elsif ($ctx =~ /.xW/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002587 ERROR("SPACING",
2588 "space prohibited after that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002589 }
2590
2591 # unary ++ and unary -- are allowed no space on one side.
2592 } elsif ($op eq '++' or $op eq '--') {
Andy Whitcroft773647a2008-03-28 14:15:58 -07002593 if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002594 ERROR("SPACING",
2595 "space required one side of that '$op' $at\n" . $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002596 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07002597 if ($ctx =~ /Wx[BE]/ ||
2598 ($ctx =~ /Wx./ && $cc =~ /^;/)) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002599 ERROR("SPACING",
2600 "space prohibited before that '$op' $at\n" . $hereptr);
Andy Whitcroft653d4872007-06-23 17:16:34 -07002601 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07002602 if ($ctx =~ /ExW/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002603 ERROR("SPACING",
2604 "space prohibited after that '$op' $at\n" . $hereptr);
Andy Whitcroft773647a2008-03-28 14:15:58 -07002605 }
2606
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002607
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002608 # << and >> may either have or not have spaces both sides
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002609 } elsif ($op eq '<<' or $op eq '>>' or
2610 $op eq '&' or $op eq '^' or $op eq '|' or
2611 $op eq '+' or $op eq '-' or
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002612 $op eq '*' or $op eq '/' or
2613 $op eq '%')
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002614 {
Andy Whitcroft773647a2008-03-28 14:15:58 -07002615 if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002616 ERROR("SPACING",
2617 "need consistent spacing around '$op' $at\n" .
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002618 $hereptr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002619 }
2620
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002621 # A colon needs no spaces before when it is
2622 # terminating a case value or a label.
2623 } elsif ($opv eq ':C' || $opv eq ':L') {
2624 if ($ctx =~ /Wx./) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002625 ERROR("SPACING",
2626 "space prohibited before that '$op' $at\n" . $hereptr);
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002627 }
2628
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002629 # All the others need spaces both sides.
Andy Whitcroftcf655042008-03-04 14:28:20 -08002630 } elsif ($ctx !~ /[EWC]x[CWE]/) {
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002631 my $ok = 0;
2632
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002633 # Ignore email addresses <foo@bar>
Andy Whitcroft1f65f942008-07-23 21:29:10 -07002634 if (($op eq '<' &&
2635 $cc =~ /^\S+\@\S+>/) ||
2636 ($op eq '>' &&
2637 $ca =~ /<\S+\@\S+$/))
2638 {
2639 $ok = 1;
2640 }
2641
2642 # Ignore ?:
2643 if (($opv eq ':O' && $ca =~ /\?$/) ||
2644 ($op eq '?' && $cc =~ /^:/)) {
2645 $ok = 1;
2646 }
2647
2648 if ($ok == 0) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002649 ERROR("SPACING",
2650 "spaces required around that '$op' $at\n" . $hereptr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002651 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002652 }
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002653 $off += length($elements[$n + 1]);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002654 }
2655 }
2656
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002657# check for multiple assignments
2658 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002659 CHK("MULTIPLE_ASSIGNMENTS",
2660 "multiple assignments should be avoided\n" . $herecurr);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002661 }
2662
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002663## # check for multiple declarations, allowing for a function declaration
2664## # continuation.
2665## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
2666## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
2667##
2668## # Remove any bracketed sections to ensure we do not
2669## # falsly report the parameters of functions.
2670## my $ln = $line;
2671## while ($ln =~ s/\([^\(\)]*\)//g) {
2672## }
2673## if ($ln =~ /,/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002674## WARN("MULTIPLE_DECLARATION",
2675## "declaring multiple variables together should be avoided\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002676## }
2677## }
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07002678
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002679#need space before brace following if, while, etc
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002680 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
2681 $line =~ /do{/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002682 ERROR("SPACING",
2683 "space required before the open brace '{'\n" . $herecurr);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002684 }
2685
2686# closing brace should have a space following it when it has anything
2687# on the line
2688 if ($line =~ /}(?!(?:,|;|\)))\S/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002689 ERROR("SPACING",
2690 "space required after that close brace '}'\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002691 }
2692
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002693# check spacing on square brackets
2694 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002695 ERROR("SPACING",
2696 "space prohibited after that open square bracket '['\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002697 }
2698 if ($line =~ /\s\]/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002699 ERROR("SPACING",
2700 "space prohibited before that close square bracket ']'\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002701 }
2702
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002703# check spacing on parentheses
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07002704 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
2705 $line !~ /for\s*\(\s+;/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002706 ERROR("SPACING",
2707 "space prohibited after that open parenthesis '('\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002708 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002709 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002710 $line !~ /for\s*\(.*;\s+\)/ &&
2711 $line !~ /:\s+\)/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002712 ERROR("SPACING",
2713 "space prohibited before that close parenthesis ')'\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07002714 }
2715
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002716#goto labels aren't indented, allow a single space however
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002717 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002718 !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002719 WARN("INDENTED_LABEL",
2720 "labels should not be indented\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002721 }
2722
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002723# Return is not a function.
2724 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
2725 my $spacing = $1;
2726 my $value = $2;
2727
Andy Whitcroft86f9d052009-01-06 14:41:24 -08002728 # Flatten any parentheses
Andy Whitcroftfb2d2c12010-10-26 14:23:12 -07002729 $value =~ s/\(/ \(/g;
2730 $value =~ s/\)/\) /g;
Andy Whitcrofte01886a2012-01-10 15:10:08 -08002731 while ($value =~ s/\[[^\[\]]*\]/1/ ||
Andy Whitcroft63f17f82009-01-15 13:51:06 -08002732 $value !~ /(?:$Ident|-?$Constant)\s*
2733 $Compare\s*
2734 (?:$Ident|-?$Constant)/x &&
2735 $value =~ s/\([^\(\)]*\)/1/) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002736 }
Andy Whitcroftfb2d2c12010-10-26 14:23:12 -07002737#print "value<$value>\n";
2738 if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002739 ERROR("RETURN_PARENTHESES",
2740 "return is not a function, parentheses are not required\n" . $herecurr);
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002741
2742 } elsif ($spacing !~ /\s+/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002743 ERROR("SPACING",
2744 "space required before the open parenthesis '('\n" . $herecurr);
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002745 }
2746 }
Andy Whitcroft53a3c442010-10-26 14:23:14 -07002747# Return of what appears to be an errno should normally be -'ve
2748 if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
2749 my $name = $1;
2750 if ($name ne 'EOF' && $name ne 'ERROR') {
Joe Perches000d1cc12011-07-25 17:13:25 -07002751 WARN("USE_NEGATIVE_ERRNO",
2752 "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
Andy Whitcroft53a3c442010-10-26 14:23:14 -07002753 }
2754 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002755
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002756# Need a space before open parenthesis after if, while etc
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07002757 if ($line=~/\b(if|while|for|switch)\(/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002758 ERROR("SPACING", "space required before the open parenthesis '('\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002759 }
2760
Andy Whitcroftf5fe35d2008-07-23 21:29:03 -07002761# Check for illegal assignment in if conditional -- and check for trailing
2762# statements after the conditional.
Andy Whitcroft170d3a22008-10-15 22:02:30 -07002763 if ($line =~ /do\s*(?!{)/) {
Andy Whitcroft3e469cd2012-01-10 15:10:01 -08002764 ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2765 ctx_statement_block($linenr, $realcnt, 0)
2766 if (!defined $stat);
Andy Whitcroft170d3a22008-10-15 22:02:30 -07002767 my ($stat_next) = ctx_statement_block($line_nr_next,
2768 $remain_next, $off_next);
2769 $stat_next =~ s/\n./\n /g;
2770 ##print "stat<$stat> stat_next<$stat_next>\n";
2771
2772 if ($stat_next =~ /^\s*while\b/) {
2773 # If the statement carries leading newlines,
2774 # then count those as offsets.
2775 my ($whitespace) =
2776 ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
2777 my $offset =
2778 statement_rawlines($whitespace) - 1;
2779
2780 $suppress_whiletrailers{$line_nr_next +
2781 $offset} = 1;
2782 }
2783 }
2784 if (!defined $suppress_whiletrailers{$linenr} &&
2785 $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07002786 my ($s, $c) = ($stat, $cond);
Andy Whitcroft8905a672007-11-28 16:21:06 -08002787
Andy Whitcroftb53c8e12009-01-06 14:41:29 -08002788 if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002789 ERROR("ASSIGN_IN_IF",
2790 "do not use assignment in if condition\n" . $herecurr);
Andy Whitcroft8905a672007-11-28 16:21:06 -08002791 }
2792
2793 # Find out what is on the end of the line after the
2794 # conditional.
Andy Whitcroft773647a2008-03-28 14:15:58 -07002795 substr($s, 0, length($c), '');
Andy Whitcroft8905a672007-11-28 16:21:06 -08002796 $s =~ s/\n.*//g;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002797 $s =~ s/$;//g; # Remove any comments
Andy Whitcroft53210162008-07-23 21:29:03 -07002798 if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
2799 $c !~ /}\s*while\s*/)
Andy Whitcroft773647a2008-03-28 14:15:58 -07002800 {
Andy Whitcroftbb44ad32008-10-15 22:02:34 -07002801 # Find out how long the conditional actually is.
2802 my @newlines = ($c =~ /\n/gs);
2803 my $cond_lines = 1 + $#newlines;
Hidetoshi Seto42bdf742010-03-05 13:43:50 -08002804 my $stat_real = '';
Andy Whitcroftbb44ad32008-10-15 22:02:34 -07002805
Hidetoshi Seto42bdf742010-03-05 13:43:50 -08002806 $stat_real = raw_line($linenr, $cond_lines)
2807 . "\n" if ($cond_lines);
Andy Whitcroftbb44ad32008-10-15 22:02:34 -07002808 if (defined($stat_real) && $cond_lines > 1) {
2809 $stat_real = "[...]\n$stat_real";
2810 }
2811
Joe Perches000d1cc12011-07-25 17:13:25 -07002812 ERROR("TRAILING_STATEMENTS",
2813 "trailing statements should be on next line\n" . $herecurr . $stat_real);
Andy Whitcroft8905a672007-11-28 16:21:06 -08002814 }
2815 }
2816
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002817# Check for bitwise tests written as boolean
2818 if ($line =~ /
2819 (?:
2820 (?:\[|\(|\&\&|\|\|)
2821 \s*0[xX][0-9]+\s*
2822 (?:\&\&|\|\|)
2823 |
2824 (?:\&\&|\|\|)
2825 \s*0[xX][0-9]+\s*
2826 (?:\&\&|\|\||\)|\])
2827 )/x)
2828 {
Joe Perches000d1cc12011-07-25 17:13:25 -07002829 WARN("HEXADECIMAL_BOOLEAN_TEST",
2830 "boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002831 }
2832
Andy Whitcroft8905a672007-11-28 16:21:06 -08002833# if and else should not have general statements after it
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002834 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
2835 my $s = $1;
2836 $s =~ s/$;//g; # Remove any comments
2837 if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002838 ERROR("TRAILING_STATEMENTS",
2839 "trailing statements should be on next line\n" . $herecurr);
Andy Whitcroft13214ad2008-02-08 04:22:03 -08002840 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002841 }
Andy Whitcroft39667782009-01-15 13:51:06 -08002842# if should not continue a brace
2843 if ($line =~ /}\s*if\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002844 ERROR("TRAILING_STATEMENTS",
2845 "trailing statements should be on next line\n" .
Andy Whitcroft39667782009-01-15 13:51:06 -08002846 $herecurr);
2847 }
Andy Whitcrofta1080bf2008-10-15 22:02:25 -07002848# case and default should not have general statements after them
2849 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
2850 $line !~ /\G(?:
Andy Whitcroft3fef12d2008-10-15 22:02:36 -07002851 (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
Andy Whitcrofta1080bf2008-10-15 22:02:25 -07002852 \s*return\s+
2853 )/xg)
2854 {
Joe Perches000d1cc12011-07-25 17:13:25 -07002855 ERROR("TRAILING_STATEMENTS",
2856 "trailing statements should be on next line\n" . $herecurr);
Andy Whitcrofta1080bf2008-10-15 22:02:25 -07002857 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002858
2859 # Check for }<nl>else {, these must be at the same
2860 # indent level to be relevant to each other.
2861 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
2862 $previndent == $indent) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002863 ERROR("ELSE_AFTER_BRACE",
2864 "else should follow close brace '}'\n" . $hereprev);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002865 }
2866
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002867 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
2868 $previndent == $indent) {
2869 my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
2870
2871 # Find out what is on the end of the line after the
2872 # conditional.
Andy Whitcroft773647a2008-03-28 14:15:58 -07002873 substr($s, 0, length($c), '');
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002874 $s =~ s/\n.*//g;
2875
2876 if ($s =~ /^\s*;/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002877 ERROR("WHILE_AFTER_BRACE",
2878 "while should follow close brace '}'\n" . $hereprev);
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08002879 }
2880 }
2881
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002882#studly caps, commented out until figure out how to distinguish between use of existing and adding new
2883# if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
2884# print "No studly caps, use _\n";
2885# print "$herecurr";
2886# $clean = 0;
2887# }
2888
2889#no spaces allowed after \ in define
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002890 if ($line=~/\#\s*define.*\\\s$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002891 WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
2892 "Whitepspace after \\ makes next lines useless\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002893 }
2894
Andy Whitcroft653d4872007-06-23 17:16:34 -07002895#warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002896 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
Andy Whitcrofte09dec42008-10-15 22:02:20 -07002897 my $file = "$1.h";
2898 my $checkfile = "include/linux/$file";
2899 if (-f "$root/$checkfile" &&
2900 $realfile ne $checkfile &&
Wolfram Sang7840a942010-08-09 17:20:57 -07002901 $1 !~ /$allowed_asm_includes/)
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002902 {
Andy Whitcrofte09dec42008-10-15 22:02:20 -07002903 if ($realfile =~ m{^arch/}) {
Joe Perches000d1cc12011-07-25 17:13:25 -07002904 CHK("ARCH_INCLUDE_LINUX",
2905 "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
Andy Whitcrofte09dec42008-10-15 22:02:20 -07002906 } else {
Joe Perches000d1cc12011-07-25 17:13:25 -07002907 WARN("INCLUDE_LINUX",
2908 "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
Andy Whitcrofte09dec42008-10-15 22:02:20 -07002909 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002910 }
2911 }
2912
Andy Whitcroft653d4872007-06-23 17:16:34 -07002913# multi-statement macros should be enclosed in a do while loop, grab the
2914# first statement and ensure its the whole macro if its not enclosed
Andy Whitcroftcf655042008-03-04 14:28:20 -08002915# in a known good container
Andy Whitcroftb8f96a32008-07-23 21:29:07 -07002916 if ($realfile !~ m@/vmlinux.lds.h$@ &&
2917 $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002918 my $ln = $linenr;
2919 my $cnt = $realcnt;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002920 my ($off, $dstat, $dcond, $rest);
2921 my $ctx = '';
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002922 ($dstat, $dcond, $ln, $cnt, $off) =
Andy Whitcroftf74bd192012-01-10 15:09:54 -08002923 ctx_statement_block($linenr, $realcnt, 0);
2924 $ctx = $dstat;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002925 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
Andy Whitcrofta3bb97a2008-07-23 21:29:00 -07002926 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002927
Andy Whitcroftf74bd192012-01-10 15:09:54 -08002928 $dstat =~ s/^.\s*\#\s*define\s+$Ident(?:\([^\)]*\))?\s*//;
Andy Whitcroft292f1a92008-07-23 21:29:11 -07002929 $dstat =~ s/$;//g;
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002930 $dstat =~ s/\\\n.//g;
2931 $dstat =~ s/^\s*//s;
2932 $dstat =~ s/\s*$//s;
2933
2934 # Flatten any parentheses and braces
Andy Whitcroftbf30d6e2008-10-15 22:02:33 -07002935 while ($dstat =~ s/\([^\(\)]*\)/1/ ||
2936 $dstat =~ s/\{[^\{\}]*\}/1/ ||
Andy Whitcroftc81769f2012-01-10 15:10:10 -08002937 $dstat =~ s/\[[^\[\]]*\]/1/)
Andy Whitcroftbf30d6e2008-10-15 22:02:33 -07002938 {
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07002939 }
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002940
Andy Whitcrofte45bab82012-03-23 15:02:18 -07002941 # Flatten any obvious string concatentation.
2942 while ($dstat =~ s/("X*")\s*$Ident/$1/ ||
2943 $dstat =~ s/$Ident\s*("X*")/$1/)
2944 {
2945 }
2946
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002947 my $exceptions = qr{
2948 $Declare|
2949 module_param_named|
2950 MODULE_PARAM_DESC|
2951 DECLARE_PER_CPU|
2952 DEFINE_PER_CPU|
Andy Whitcroft383099f2009-01-06 14:41:18 -08002953 __typeof__\(|
Stefani Seibold22fd2d32010-03-05 13:43:52 -08002954 union|
2955 struct|
Andy Whitcroftea71a0a2009-09-21 17:04:38 -07002956 \.$Ident\s*=\s*|
2957 ^\"|\"$
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002958 }x;
Andy Whitcroft5eaa20b2010-10-26 14:23:18 -07002959 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
Andy Whitcroftf74bd192012-01-10 15:09:54 -08002960 if ($dstat ne '' &&
2961 $dstat !~ /^(?:$Ident|-?$Constant),$/ && # 10, // foo(),
2962 $dstat !~ /^(?:$Ident|-?$Constant);$/ && # foo();
Andy Whitcroftfd1b57a2012-03-23 15:02:18 -07002963 $dstat !~ /^[!~-]?(?:$Ident|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo
Andy Whitcroftb9df76a2012-03-23 15:02:17 -07002964 $dstat !~ /^'X'$/ && # character constants
Andy Whitcroftf74bd192012-01-10 15:09:54 -08002965 $dstat !~ /$exceptions/ &&
2966 $dstat !~ /^\.$Ident\s*=/ && # .foo =
Andy Whitcroft72f115f2012-01-10 15:10:06 -08002967 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
Andy Whitcroftf74bd192012-01-10 15:09:54 -08002968 $dstat !~ /^for\s*$Constant$/ && # for (...)
2969 $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ && # for (...) bar()
2970 $dstat !~ /^do\s*{/ && # do {...
2971 $dstat !~ /^\({/) # ({...
2972 {
2973 $ctx =~ s/\n*$//;
2974 my $herectx = $here . "\n";
2975 my $cnt = statement_rawlines($ctx);
2976
2977 for (my $n = 0; $n < $cnt; $n++) {
2978 $herectx .= raw_line($linenr, $n) . "\n";
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07002979 }
2980
Andy Whitcroftf74bd192012-01-10 15:09:54 -08002981 if ($dstat =~ /;/) {
2982 ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
2983 "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
2984 } else {
Joe Perches000d1cc12011-07-25 17:13:25 -07002985 ERROR("COMPLEX_MACRO",
Andy Whitcroftf74bd192012-01-10 15:09:54 -08002986 "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
Andy Whitcroftd8aaf122007-06-23 17:16:44 -07002987 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07002988 }
Andy Whitcroft0a920b52007-06-01 00:46:48 -07002989 }
2990
Joe Perchesb13edf72012-07-30 14:41:24 -07002991# do {} while (0) macro tests:
2992# single-statement macros do not need to be enclosed in do while (0) loop,
2993# macro should not end with a semicolon
2994 if ($^V && $^V ge 5.10.0 &&
2995 $realfile !~ m@/vmlinux.lds.h$@ &&
2996 $line =~ /^.\s*\#\s*define\s+$Ident(\()?/) {
2997 my $ln = $linenr;
2998 my $cnt = $realcnt;
2999 my ($off, $dstat, $dcond, $rest);
3000 my $ctx = '';
3001 ($dstat, $dcond, $ln, $cnt, $off) =
3002 ctx_statement_block($linenr, $realcnt, 0);
3003 $ctx = $dstat;
3004
3005 $dstat =~ s/\\\n.//g;
3006
3007 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
3008 my $stmts = $2;
3009 my $semis = $3;
3010
3011 $ctx =~ s/\n*$//;
3012 my $cnt = statement_rawlines($ctx);
3013 my $herectx = $here . "\n";
3014
3015 for (my $n = 0; $n < $cnt; $n++) {
3016 $herectx .= raw_line($linenr, $n) . "\n";
3017 }
3018
Joe Perchesac8e97f2012-08-21 16:15:53 -07003019 if (($stmts =~ tr/;/;/) == 1 &&
3020 $stmts !~ /^\s*(if|while|for|switch)\b/) {
Joe Perchesb13edf72012-07-30 14:41:24 -07003021 WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
3022 "Single statement macros should not use a do {} while (0) loop\n" . "$herectx");
3023 }
3024 if (defined $semis && $semis ne "") {
3025 WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON",
3026 "do {} while (0) macros should not be semicolon terminated\n" . "$herectx");
3027 }
3028 }
3029 }
3030
Mike Frysinger080ba922009-01-06 14:41:25 -08003031# make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
3032# all assignments may have only one of the following with an assignment:
3033# .
3034# ALIGN(...)
3035# VMLINUX_SYMBOL(...)
3036 if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003037 WARN("MISSING_VMLINUX_SYMBOL",
3038 "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
Mike Frysinger080ba922009-01-06 14:41:25 -08003039 }
3040
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003041# check for redundant bracing round if etc
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003042 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
3043 my ($level, $endln, @chunks) =
Andy Whitcroftcf655042008-03-04 14:28:20 -08003044 ctx_statement_full($linenr, $realcnt, 1);
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003045 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08003046 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
3047 if ($#chunks > 0 && $level == 0) {
Joe Perchesaad4f612012-03-23 15:02:19 -07003048 my @allowed = ();
3049 my $allow = 0;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003050 my $seen = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -07003051 my $herectx = $here . "\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08003052 my $ln = $linenr - 1;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003053 for my $chunk (@chunks) {
3054 my ($cond, $block) = @{$chunk};
3055
Andy Whitcroft773647a2008-03-28 14:15:58 -07003056 # If the condition carries leading newlines, then count those as offsets.
3057 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
3058 my $offset = statement_rawlines($whitespace) - 1;
3059
Joe Perchesaad4f612012-03-23 15:02:19 -07003060 $allowed[$allow] = 0;
Andy Whitcroft773647a2008-03-28 14:15:58 -07003061 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
3062
3063 # We have looked at and allowed this specific line.
3064 $suppress_ifbraces{$ln + $offset} = 1;
3065
3066 $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08003067 $ln += statement_rawlines($block) - 1;
3068
Andy Whitcroft773647a2008-03-28 14:15:58 -07003069 substr($block, 0, length($cond), '');
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003070
3071 $seen++ if ($block =~ /^\s*{/);
3072
Joe Perchesaad4f612012-03-23 15:02:19 -07003073 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08003074 if (statement_lines($cond) > 1) {
3075 #print "APW: ALLOWED: cond<$cond>\n";
Joe Perchesaad4f612012-03-23 15:02:19 -07003076 $allowed[$allow] = 1;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003077 }
3078 if ($block =~/\b(?:if|for|while)\b/) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08003079 #print "APW: ALLOWED: block<$block>\n";
Joe Perchesaad4f612012-03-23 15:02:19 -07003080 $allowed[$allow] = 1;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003081 }
Andy Whitcroftcf655042008-03-04 14:28:20 -08003082 if (statement_block_size($block) > 1) {
3083 #print "APW: ALLOWED: lines block<$block>\n";
Joe Perchesaad4f612012-03-23 15:02:19 -07003084 $allowed[$allow] = 1;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003085 }
Joe Perchesaad4f612012-03-23 15:02:19 -07003086 $allow++;
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003087 }
Joe Perchesaad4f612012-03-23 15:02:19 -07003088 if ($seen) {
3089 my $sum_allowed = 0;
3090 foreach (@allowed) {
3091 $sum_allowed += $_;
3092 }
3093 if ($sum_allowed == 0) {
3094 WARN("BRACES",
3095 "braces {} are not necessary for any arm of this statement\n" . $herectx);
3096 } elsif ($sum_allowed != $allow &&
3097 $seen != $allow) {
3098 CHK("BRACES",
3099 "braces {} should be used on all arms of this statement\n" . $herectx);
3100 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003101 }
3102 }
3103 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07003104 if (!defined $suppress_ifbraces{$linenr - 1} &&
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003105 $line =~ /\b(if|while|for|else)\b/) {
Andy Whitcroftcf655042008-03-04 14:28:20 -08003106 my $allowed = 0;
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003107
Andy Whitcroftcf655042008-03-04 14:28:20 -08003108 # Check the pre-context.
3109 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
3110 #print "APW: ALLOWED: pre<$1>\n";
3111 $allowed = 1;
3112 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07003113
3114 my ($level, $endln, @chunks) =
3115 ctx_statement_full($linenr, $realcnt, $-[0]);
3116
Andy Whitcroftcf655042008-03-04 14:28:20 -08003117 # Check the condition.
3118 my ($cond, $block) = @{$chunks[0]};
Andy Whitcroft773647a2008-03-28 14:15:58 -07003119 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08003120 if (defined $cond) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07003121 substr($block, 0, length($cond), '');
Andy Whitcroftcf655042008-03-04 14:28:20 -08003122 }
3123 if (statement_lines($cond) > 1) {
3124 #print "APW: ALLOWED: cond<$cond>\n";
3125 $allowed = 1;
3126 }
3127 if ($block =~/\b(?:if|for|while)\b/) {
3128 #print "APW: ALLOWED: block<$block>\n";
3129 $allowed = 1;
3130 }
3131 if (statement_block_size($block) > 1) {
3132 #print "APW: ALLOWED: lines block<$block>\n";
3133 $allowed = 1;
3134 }
3135 # Check the post-context.
3136 if (defined $chunks[1]) {
3137 my ($cond, $block) = @{$chunks[1]};
3138 if (defined $cond) {
Andy Whitcroft773647a2008-03-28 14:15:58 -07003139 substr($block, 0, length($cond), '');
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003140 }
Andy Whitcroftcf655042008-03-04 14:28:20 -08003141 if ($block =~ /^\s*\{/) {
3142 #print "APW: ALLOWED: chunk-1 block<$block>\n";
3143 $allowed = 1;
3144 }
3145 }
3146 if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
Justin P. Mattock69932482011-07-26 23:06:29 -07003147 my $herectx = $here . "\n";
Andy Whitcroftf0556632008-10-15 22:02:23 -07003148 my $cnt = statement_rawlines($block);
Andy Whitcroftcf655042008-03-04 14:28:20 -08003149
Andy Whitcroftf0556632008-10-15 22:02:23 -07003150 for (my $n = 0; $n < $cnt; $n++) {
Justin P. Mattock69932482011-07-26 23:06:29 -07003151 $herectx .= raw_line($linenr, $n) . "\n";
Andy Whitcroftcf655042008-03-04 14:28:20 -08003152 }
3153
Joe Perches000d1cc12011-07-25 17:13:25 -07003154 WARN("BRACES",
3155 "braces {} are not necessary for single statement blocks\n" . $herectx);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003156 }
3157 }
3158
Andy Whitcroft653d4872007-06-23 17:16:34 -07003159# don't include deprecated include files (uses RAW line)
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003160 for my $inc (@dep_includes) {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003161 if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003162 ERROR("DEPRECATED_INCLUDE",
3163 "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003164 }
3165 }
3166
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003167# don't use deprecated functions
3168 for my $func (@dep_functions) {
Andy Whitcroft00df3442007-06-08 13:47:06 -07003169 if ($line =~ /\b$func\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003170 ERROR("DEPRECATED_FUNCTION",
3171 "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003172 }
3173 }
3174
3175# no volatiles please
Andy Whitcroft6c72ffa2007-10-18 03:05:08 -07003176 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
3177 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003178 WARN("VOLATILE",
3179 "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003180 }
3181
Andy Whitcroft00df3442007-06-08 13:47:06 -07003182# warn about #if 0
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003183 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003184 CHK("REDUNDANT_CODE",
3185 "if this code is redundant consider removing it\n" .
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07003186 $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003187 }
3188
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003189# check for needless kfree() checks
3190 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3191 my $expr = $1;
3192 if ($line =~ /\bkfree\(\Q$expr\E\);/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003193 WARN("NEEDLESS_KFREE",
3194 "kfree(NULL) is safe this check is probably not required\n" . $hereprev);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003195 }
3196 }
Greg Kroah-Hartman4c432a82008-07-23 21:29:04 -07003197# check for needless usb_free_urb() checks
3198 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3199 my $expr = $1;
3200 if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003201 WARN("NEEDLESS_USB_FREE_URB",
3202 "usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
Greg Kroah-Hartman4c432a82008-07-23 21:29:04 -07003203 }
3204 }
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003205
Patrick Pannuto1a15a252010-08-09 17:21:01 -07003206# prefer usleep_range over udelay
3207 if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
3208 # ignore udelay's < 10, however
3209 if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003210 CHK("USLEEP_RANGE",
3211 "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
Patrick Pannuto1a15a252010-08-09 17:21:01 -07003212 }
3213 }
3214
Patrick Pannuto09ef8722010-08-09 17:21:02 -07003215# warn about unexpectedly long msleep's
3216 if ($line =~ /\bmsleep\s*\((\d+)\);/) {
3217 if ($1 < 20) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003218 WARN("MSLEEP",
3219 "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
Patrick Pannuto09ef8722010-08-09 17:21:02 -07003220 }
3221 }
3222
Andy Whitcroft00df3442007-06-08 13:47:06 -07003223# warn about #ifdefs in C files
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003224# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
Andy Whitcroft00df3442007-06-08 13:47:06 -07003225# print "#ifdef in C files should be avoided\n";
3226# print "$herecurr";
3227# $clean = 0;
3228# }
3229
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07003230# warn about spacing in #ifdefs
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003231 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003232 ERROR("SPACING",
3233 "exactly one space required after that #$1\n" . $herecurr);
Andy Whitcroft22f2a2e2007-08-10 13:01:03 -07003234 }
3235
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003236# check for spinlock_t definitions without a comment.
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07003237 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
3238 $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003239 my $which = $1;
3240 if (!ctx_has_comment($first_line, $linenr)) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003241 CHK("UNCOMMENTED_DEFINITION",
3242 "$1 definition without comment\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003243 }
3244 }
3245# check for memory barriers without a comment.
3246 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
3247 if (!ctx_has_comment($first_line, $linenr)) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003248 CHK("MEMORY_BARRIER",
3249 "memory barrier without comment\n" . $herecurr);
Andy Whitcroft4a0df2e2007-06-08 13:46:39 -07003250 }
3251 }
3252# check of hardware specific defines
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003253 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003254 CHK("ARCH_DEFINES",
3255 "architecture specific defines should be avoided\n" . $herecurr);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003256 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07003257
Tobias Klauserd4977c72010-05-24 14:33:30 -07003258# Check that the storage class is at the beginning of a declaration
3259 if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003260 WARN("STORAGE_CLASS",
3261 "storage class should be at the beginning of the declaration\n" . $herecurr)
Tobias Klauserd4977c72010-05-24 14:33:30 -07003262 }
3263
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07003264# check the location of the inline attribute, that it is between
3265# storage class and type.
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07003266 if ($line =~ /\b$Type\s+$Inline\b/ ||
3267 $line =~ /\b$Inline\s+$Storage\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003268 ERROR("INLINE_LOCATION",
3269 "inline keyword should sit between storage class and type\n" . $herecurr);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07003270 }
3271
Andy Whitcroft8905a672007-11-28 16:21:06 -08003272# Check for __inline__ and __inline, prefer inline
3273 if ($line =~ /\b(__inline__|__inline)\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003274 WARN("INLINE",
3275 "plain inline is preferred over $1\n" . $herecurr);
Andy Whitcroft8905a672007-11-28 16:21:06 -08003276 }
3277
Joe Perches3d130fd2011-01-12 17:00:00 -08003278# Check for __attribute__ packed, prefer __packed
3279 if ($line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003280 WARN("PREFER_PACKED",
3281 "__packed is preferred over __attribute__((packed))\n" . $herecurr);
Joe Perches3d130fd2011-01-12 17:00:00 -08003282 }
3283
Joe Perches39b7e282011-07-25 17:13:24 -07003284# Check for __attribute__ aligned, prefer __aligned
3285 if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003286 WARN("PREFER_ALIGNED",
3287 "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
Joe Perches39b7e282011-07-25 17:13:24 -07003288 }
3289
Joe Perches5f14d3b2012-01-10 15:09:52 -08003290# Check for __attribute__ format(printf, prefer __printf
3291 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
3292 WARN("PREFER_PRINTF",
3293 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr);
3294 }
3295
Joe Perches6061d942012-03-23 15:02:16 -07003296# Check for __attribute__ format(scanf, prefer __scanf
3297 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\b/) {
3298 WARN("PREFER_SCANF",
3299 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr);
3300 }
3301
Joe Perches8f53a9b2010-03-05 13:43:48 -08003302# check for sizeof(&)
3303 if ($line =~ /\bsizeof\s*\(\s*\&/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003304 WARN("SIZEOF_ADDRESS",
3305 "sizeof(& should be avoided\n" . $herecurr);
Joe Perches8f53a9b2010-03-05 13:43:48 -08003306 }
3307
Joe Perches66c80b62012-07-30 14:41:22 -07003308# check for sizeof without parenthesis
3309 if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) {
3310 WARN("SIZEOF_PARENTHESIS",
3311 "sizeof $1 should be sizeof($1)\n" . $herecurr);
3312 }
3313
Joe Perches428e2fd2011-05-24 17:13:39 -07003314# check for line continuations in quoted strings with odd counts of "
3315 if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003316 WARN("LINE_CONTINUATIONS",
3317 "Avoid line continuations in quoted strings\n" . $herecurr);
Joe Perches428e2fd2011-05-24 17:13:39 -07003318 }
3319
Andy Whitcroft554e1652012-01-10 15:09:57 -08003320# Check for misused memsets
Joe Perchesd1fe9c02012-03-23 15:02:16 -07003321 if ($^V && $^V ge 5.10.0 &&
3322 defined $stat &&
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003323 $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) {
Andy Whitcroft554e1652012-01-10 15:09:57 -08003324
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003325 my $ms_addr = $2;
Joe Perchesd1fe9c02012-03-23 15:02:16 -07003326 my $ms_val = $7;
3327 my $ms_size = $12;
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003328
Andy Whitcroft554e1652012-01-10 15:09:57 -08003329 if ($ms_size =~ /^(0x|)0$/i) {
3330 ERROR("MEMSET",
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003331 "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
Andy Whitcroft554e1652012-01-10 15:09:57 -08003332 } elsif ($ms_size =~ /^(0x|)1$/i) {
3333 WARN("MEMSET",
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003334 "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
3335 }
3336 }
3337
3338# typecasts on min/max could be min_t/max_t
Joe Perchesd1fe9c02012-03-23 15:02:16 -07003339 if ($^V && $^V ge 5.10.0 &&
3340 defined $stat &&
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003341 $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
Joe Perchesd1fe9c02012-03-23 15:02:16 -07003342 if (defined $2 || defined $7) {
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003343 my $call = $1;
3344 my $cast1 = deparenthesize($2);
3345 my $arg1 = $3;
Joe Perchesd1fe9c02012-03-23 15:02:16 -07003346 my $cast2 = deparenthesize($7);
3347 my $arg2 = $8;
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003348 my $cast;
3349
Joe Perchesd1fe9c02012-03-23 15:02:16 -07003350 if ($cast1 ne "" && $cast2 ne "" && $cast1 ne $cast2) {
Joe Perchesd7c76ba2012-01-10 15:09:58 -08003351 $cast = "$cast1 or $cast2";
3352 } elsif ($cast1 ne "") {
3353 $cast = $cast1;
3354 } else {
3355 $cast = $cast2;
3356 }
3357 WARN("MINMAX",
3358 "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
Andy Whitcroft554e1652012-01-10 15:09:57 -08003359 }
3360 }
3361
Joe Perches4a273192012-07-30 14:41:20 -07003362# check usleep_range arguments
3363 if ($^V && $^V ge 5.10.0 &&
3364 defined $stat &&
3365 $stat =~ /^\+(?:.*?)\busleep_range\s*\(\s*($FuncArg)\s*,\s*($FuncArg)\s*\)/) {
3366 my $min = $1;
3367 my $max = $7;
3368 if ($min eq $max) {
3369 WARN("USLEEP_RANGE",
3370 "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
3371 } elsif ($min =~ /^\d+$/ && $max =~ /^\d+$/ &&
3372 $min > $max) {
3373 WARN("USLEEP_RANGE",
3374 "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
3375 }
3376 }
3377
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07003378# check for new externs in .c files.
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07003379 if ($realfile =~ /\.c$/ && defined $stat &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003380 $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07003381 {
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003382 my $function_name = $1;
3383 my $paren_space = $2;
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07003384
3385 my $s = $stat;
3386 if (defined $cond) {
3387 substr($s, 0, length($cond), '');
3388 }
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003389 if ($s =~ /^\s*;/ &&
3390 $function_name ne 'uninitialized_var')
3391 {
Joe Perches000d1cc12011-07-25 17:13:25 -07003392 WARN("AVOID_EXTERNS",
3393 "externs should be avoided in .c files\n" . $herecurr);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07003394 }
3395
3396 if ($paren_space =~ /\n/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003397 WARN("FUNCTION_ARGUMENTS",
3398 "arguments for function declarations should follow identifier\n" . $herecurr);
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07003399 }
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07003400
3401 } elsif ($realfile =~ /\.c$/ && defined $stat &&
3402 $stat =~ /^.\s*extern\s+/)
3403 {
Joe Perches000d1cc12011-07-25 17:13:25 -07003404 WARN("AVOID_EXTERNS",
3405 "externs should be avoided in .c files\n" . $herecurr);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07003406 }
3407
3408# checks for new __setup's
3409 if ($rawline =~ /\b__setup\("([^"]*)"/) {
3410 my $name = $1;
3411
3412 if (!grep(/$name/, @setup_docs)) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003413 CHK("UNDOCUMENTED_SETUP",
3414 "__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
Andy Whitcroftde7d4f02007-07-15 23:37:22 -07003415 }
Andy Whitcroft653d4872007-06-23 17:16:34 -07003416 }
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07003417
3418# check for pointless casting of kmalloc return
Joe Perchescaf2a542011-01-12 16:59:56 -08003419 if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003420 WARN("UNNECESSARY_CASTS",
3421 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
Andy Whitcroft9c0ca6f2007-10-16 23:29:38 -07003422 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003423
Joe Perchescaf2a542011-01-12 16:59:56 -08003424# check for multiple semicolons
3425 if ($line =~ /;\s*;\s*$/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003426 WARN("ONE_SEMICOLON",
3427 "Statements terminations use 1 semicolon\n" . $herecurr);
Joe Perchescaf2a542011-01-12 16:59:56 -08003428 }
3429
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003430# check for gcc specific __FUNCTION__
3431 if ($line =~ /__FUNCTION__/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003432 WARN("USE_FUNC",
3433 "__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003434 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07003435
Joe Perches2c924882012-03-23 15:02:20 -07003436# check for use of yield()
3437 if ($line =~ /\byield\s*\(\s*\)/) {
3438 WARN("YIELD",
3439 "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n" . $herecurr);
3440 }
3441
Thomas Gleixner4882720b2010-09-07 14:34:01 +00003442# check for semaphores initialized locked
3443 if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003444 WARN("CONSIDER_COMPLETION",
3445 "consider using a completion\n" . $herecurr);
Andy Whitcroft773647a2008-03-28 14:15:58 -07003446 }
Joe Perches6712d852012-03-23 15:02:20 -07003447
Joe Perches67d0a072011-10-31 17:13:10 -07003448# recommend kstrto* over simple_strto* and strict_strto*
3449 if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003450 WARN("CONSIDER_KSTRTO",
Joe Perches67d0a072011-10-31 17:13:10 -07003451 "$1 is obsolete, use k$3 instead\n" . $herecurr);
Andy Whitcroft773647a2008-03-28 14:15:58 -07003452 }
Joe Perches6712d852012-03-23 15:02:20 -07003453
Michael Ellermanf3db6632008-07-23 21:28:57 -07003454# check for __initcall(), use device_initcall() explicitly please
3455 if ($line =~ /^.\s*__initcall\s*\(/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003456 WARN("USE_DEVICE_INITCALL",
3457 "please use device_initcall() instead of __initcall()\n" . $herecurr);
Michael Ellermanf3db6632008-07-23 21:28:57 -07003458 }
Joe Perches6712d852012-03-23 15:02:20 -07003459
Emese Revfy79404842010-03-05 13:43:53 -08003460# check for various ops structs, ensure they are const.
3461 my $struct_ops = qr{acpi_dock_ops|
3462 address_space_operations|
3463 backlight_ops|
3464 block_device_operations|
3465 dentry_operations|
3466 dev_pm_ops|
3467 dma_map_ops|
3468 extent_io_ops|
3469 file_lock_operations|
3470 file_operations|
3471 hv_ops|
3472 ide_dma_ops|
3473 intel_dvo_dev_ops|
3474 item_operations|
3475 iwl_ops|
3476 kgdb_arch|
3477 kgdb_io|
3478 kset_uevent_ops|
3479 lock_manager_operations|
3480 microcode_ops|
3481 mtrr_ops|
3482 neigh_ops|
3483 nlmsvc_binding|
3484 pci_raw_ops|
3485 pipe_buf_operations|
3486 platform_hibernation_ops|
3487 platform_suspend_ops|
3488 proto_ops|
3489 rpc_pipe_ops|
3490 seq_operations|
3491 snd_ac97_build_ops|
3492 soc_pcmcia_socket_ops|
3493 stacktrace_ops|
3494 sysfs_ops|
3495 tty_operations|
3496 usb_mon_operations|
3497 wd_ops}x;
Andy Whitcroft6903ffb2009-01-15 13:51:07 -08003498 if ($line !~ /\bconst\b/ &&
Emese Revfy79404842010-03-05 13:43:53 -08003499 $line =~ /\bstruct\s+($struct_ops)\b/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003500 WARN("CONST_STRUCT",
3501 "struct $1 should normally be const\n" .
Andy Whitcroft6903ffb2009-01-15 13:51:07 -08003502 $herecurr);
Andy Whitcroft2b6db5c2009-01-06 14:41:29 -08003503 }
Andy Whitcroft773647a2008-03-28 14:15:58 -07003504
3505# use of NR_CPUS is usually wrong
3506# ignore definitions of NR_CPUS and usage to define arrays as likely right
3507 if ($line =~ /\bNR_CPUS\b/ &&
Andy Whitcroftc45dcab2008-06-05 22:46:01 -07003508 $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
3509 $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
Andy Whitcroft171ae1a2008-04-29 00:59:32 -07003510 $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
3511 $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
3512 $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
Andy Whitcroft773647a2008-03-28 14:15:58 -07003513 {
Joe Perches000d1cc12011-07-25 17:13:25 -07003514 WARN("NR_CPUS",
3515 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
Andy Whitcroft773647a2008-03-28 14:15:58 -07003516 }
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07003517
3518# check for %L{u,d,i} in strings
3519 my $string;
3520 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
3521 $string = substr($rawline, $-[1], $+[1] - $-[1]);
Andy Whitcroft2a1bc5d2008-10-15 22:02:23 -07003522 $string =~ s/%%/__/g;
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07003523 if ($string =~ /(?<!%)%L[udi]/) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003524 WARN("PRINTF_L",
3525 "\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
Andy Whitcroft9c9ba342008-04-29 00:59:33 -07003526 last;
3527 }
3528 }
Andy Whitcroft691d77b2009-01-06 14:41:16 -08003529
3530# whine mightly about in_atomic
3531 if ($line =~ /\bin_atomic\s*\(/) {
3532 if ($realfile =~ m@^drivers/@) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003533 ERROR("IN_ATOMIC",
3534 "do not use in_atomic in drivers\n" . $herecurr);
Andy Whitcroftf4a87732009-02-27 14:03:05 -08003535 } elsif ($realfile !~ m@^kernel/@) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003536 WARN("IN_ATOMIC",
3537 "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
Andy Whitcroft691d77b2009-01-06 14:41:16 -08003538 }
3539 }
Peter Zijlstra1704f472010-03-19 01:37:42 +01003540
3541# check for lockdep_set_novalidate_class
3542 if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
3543 $line =~ /__lockdep_no_validate__\s*\)/ ) {
3544 if ($realfile !~ m@^kernel/lockdep@ &&
3545 $realfile !~ m@^include/linux/lockdep@ &&
3546 $realfile !~ m@^drivers/base/core@) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003547 ERROR("LOCKDEP",
3548 "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
Peter Zijlstra1704f472010-03-19 01:37:42 +01003549 }
3550 }
Dave Jones88f88312011-01-12 16:59:59 -08003551
3552 if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
3553 $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003554 WARN("EXPORTED_WORLD_WRITABLE",
3555 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
Dave Jones88f88312011-01-12 16:59:59 -08003556 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003557 }
3558
3559 # If we have no input at all, then there is nothing to report on
3560 # so just keep quiet.
3561 if ($#rawlines == -1) {
3562 exit(0);
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003563 }
3564
Andy Whitcroft8905a672007-11-28 16:21:06 -08003565 # In mailback mode only produce a report in the negative, for
3566 # things that appear to be patches.
3567 if ($mailback && ($clean == 1 || !$is_patch)) {
3568 exit(0);
3569 }
3570
3571 # This is not a patch, and we are are in 'no-patch' mode so
3572 # just keep quiet.
3573 if (!$chk_patch && !$is_patch) {
3574 exit(0);
3575 }
3576
3577 if (!$is_patch) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003578 ERROR("NOT_UNIFIED_DIFF",
3579 "Does not appear to be a unified-diff format patch\n");
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003580 }
3581 if ($is_patch && $chk_signoff && $signoff == 0) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003582 ERROR("MISSING_SIGN_OFF",
3583 "Missing Signed-off-by: line(s)\n");
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003584 }
3585
Andy Whitcroft8905a672007-11-28 16:21:06 -08003586 print report_dump();
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003587 if ($summary && !($clean == 1 && $quiet == 1)) {
3588 print "$filename " if ($summary_file);
Andy Whitcroft8905a672007-11-28 16:21:06 -08003589 print "total: $cnt_error errors, $cnt_warn warnings, " .
3590 (($check)? "$cnt_chk checks, " : "") .
3591 "$cnt_lines lines checked\n";
3592 print "\n" if ($quiet == 0);
Andy Whitcroftf0a594c2007-07-19 01:48:34 -07003593 }
Andy Whitcroft8905a672007-11-28 16:21:06 -08003594
Andy Whitcroftd2c0a232010-10-26 14:23:12 -07003595 if ($quiet == 0) {
Joe Perchesd1fe9c02012-03-23 15:02:16 -07003596
3597 if ($^V lt 5.10.0) {
3598 print("NOTE: perl $^V is not modern enough to detect all possible issues.\n");
3599 print("An upgrade to at least perl v5.10.0 is suggested.\n\n");
3600 }
3601
Andy Whitcroftd2c0a232010-10-26 14:23:12 -07003602 # If there were whitespace errors which cleanpatch can fix
3603 # then suggest that.
3604 if ($rpt_cleaners) {
3605 print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
3606 print " scripts/cleanfile\n\n";
Mike Frysingerb0781212011-03-22 16:34:43 -07003607 $rpt_cleaners = 0;
Andy Whitcroftd2c0a232010-10-26 14:23:12 -07003608 }
3609 }
3610
Artem Bityutskiy11232682012-03-23 15:02:17 -07003611 if ($quiet == 0 && keys %ignore_type) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003612 print "NOTE: Ignored message types:";
3613 foreach my $ignore (sort keys %ignore_type) {
3614 print " $ignore";
3615 }
Artem Bityutskiy11232682012-03-23 15:02:17 -07003616 print "\n\n";
Joe Perches000d1cc12011-07-25 17:13:25 -07003617 }
3618
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003619 if ($clean == 1 && $quiet == 0) {
Andy Whitcroftc2fdda02008-02-08 04:20:54 -08003620 print "$vname has no obvious style problems and is ready for submission.\n"
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003621 }
3622 if ($clean == 0 && $quiet == 0) {
Joe Perches000d1cc12011-07-25 17:13:25 -07003623 print << "EOM";
3624$vname has style problems, please review.
3625
3626If any of these errors are false positives, please report
3627them to the maintainer, see CHECKPATCH in MAINTAINERS.
3628EOM
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003629 }
Andy Whitcroft13214ad2008-02-08 04:22:03 -08003630
Andy Whitcroft0a920b52007-06-01 00:46:48 -07003631 return $clean;
3632}