Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 1 | /* |
| 2 | * builtin-diff.c |
| 3 | * |
| 4 | * Builtin diff command: Analyze two perf.data input files, look up and read |
| 5 | * DSOs and symbol information, sort them and produce a diff. |
| 6 | */ |
| 7 | #include "builtin.h" |
| 8 | |
| 9 | #include "util/debug.h" |
| 10 | #include "util/event.h" |
| 11 | #include "util/hist.h" |
Arnaldo Carvalho de Melo | 743eb86 | 2011-11-28 07:56:39 -0200 | [diff] [blame] | 12 | #include "util/evsel.h" |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 13 | #include "util/evlist.h" |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 14 | #include "util/session.h" |
Arnaldo Carvalho de Melo | 45694aa | 2011-11-28 08:30:20 -0200 | [diff] [blame] | 15 | #include "util/tool.h" |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 16 | #include "util/sort.h" |
| 17 | #include "util/symbol.h" |
| 18 | #include "util/util.h" |
| 19 | |
| 20 | #include <stdlib.h> |
| 21 | |
Arnaldo Carvalho de Melo | c351c28 | 2009-12-16 13:49:27 -0200 | [diff] [blame] | 22 | static char const *input_old = "perf.data.old", |
| 23 | *input_new = "perf.data"; |
Arnaldo Carvalho de Melo | 604c5c9 | 2009-12-16 14:09:53 -0200 | [diff] [blame] | 24 | static char diff__default_sort_order[] = "dso,symbol"; |
Ian Munsie | c055564 | 2010-04-13 18:37:33 +1000 | [diff] [blame] | 25 | static bool force; |
Jiri Olsa | 61949b2 | 2012-10-05 16:44:44 +0200 | [diff] [blame] | 26 | static bool show_period; |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 27 | static bool show_formula; |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 28 | static bool show_baseline_only; |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 29 | static bool sort_compute; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 30 | |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 31 | static s64 compute_wdiff_w1; |
| 32 | static s64 compute_wdiff_w2; |
| 33 | |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 34 | enum { |
| 35 | COMPUTE_DELTA, |
| 36 | COMPUTE_RATIO, |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 37 | COMPUTE_WEIGHTED_DIFF, |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 38 | COMPUTE_MAX, |
| 39 | }; |
| 40 | |
| 41 | const char *compute_names[COMPUTE_MAX] = { |
| 42 | [COMPUTE_DELTA] = "delta", |
| 43 | [COMPUTE_RATIO] = "ratio", |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 44 | [COMPUTE_WEIGHTED_DIFF] = "wdiff", |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 45 | }; |
| 46 | |
| 47 | static int compute; |
| 48 | |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 49 | static int setup_compute_opt_wdiff(char *opt) |
| 50 | { |
| 51 | char *w1_str = opt; |
| 52 | char *w2_str; |
| 53 | |
| 54 | int ret = -EINVAL; |
| 55 | |
| 56 | if (!opt) |
| 57 | goto out; |
| 58 | |
| 59 | w2_str = strchr(opt, ','); |
| 60 | if (!w2_str) |
| 61 | goto out; |
| 62 | |
| 63 | *w2_str++ = 0x0; |
| 64 | if (!*w2_str) |
| 65 | goto out; |
| 66 | |
| 67 | compute_wdiff_w1 = strtol(w1_str, NULL, 10); |
| 68 | compute_wdiff_w2 = strtol(w2_str, NULL, 10); |
| 69 | |
| 70 | if (!compute_wdiff_w1 || !compute_wdiff_w2) |
| 71 | goto out; |
| 72 | |
| 73 | pr_debug("compute wdiff w1(%" PRId64 ") w2(%" PRId64 ")\n", |
| 74 | compute_wdiff_w1, compute_wdiff_w2); |
| 75 | |
| 76 | ret = 0; |
| 77 | |
| 78 | out: |
| 79 | if (ret) |
| 80 | pr_err("Failed: wrong weight data, use 'wdiff:w1,w2'\n"); |
| 81 | |
| 82 | return ret; |
| 83 | } |
| 84 | |
| 85 | static int setup_compute_opt(char *opt) |
| 86 | { |
| 87 | if (compute == COMPUTE_WEIGHTED_DIFF) |
| 88 | return setup_compute_opt_wdiff(opt); |
| 89 | |
| 90 | if (opt) { |
| 91 | pr_err("Failed: extra option specified '%s'", opt); |
| 92 | return -EINVAL; |
| 93 | } |
| 94 | |
| 95 | return 0; |
| 96 | } |
| 97 | |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 98 | static int setup_compute(const struct option *opt, const char *str, |
| 99 | int unset __maybe_unused) |
| 100 | { |
| 101 | int *cp = (int *) opt->value; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 102 | char *cstr = (char *) str; |
| 103 | char buf[50]; |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 104 | unsigned i; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 105 | char *option; |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 106 | |
| 107 | if (!str) { |
| 108 | *cp = COMPUTE_DELTA; |
| 109 | return 0; |
| 110 | } |
| 111 | |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 112 | if (*str == '+') { |
| 113 | sort_compute = true; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 114 | cstr = (char *) ++str; |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 115 | if (!*str) |
| 116 | return 0; |
| 117 | } |
| 118 | |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 119 | option = strchr(str, ':'); |
| 120 | if (option) { |
| 121 | unsigned len = option++ - str; |
| 122 | |
| 123 | /* |
| 124 | * The str data are not writeable, so we need |
| 125 | * to use another buffer. |
| 126 | */ |
| 127 | |
| 128 | /* No option value is longer. */ |
| 129 | if (len >= sizeof(buf)) |
| 130 | return -EINVAL; |
| 131 | |
| 132 | strncpy(buf, str, len); |
| 133 | buf[len] = 0x0; |
| 134 | cstr = buf; |
| 135 | } |
| 136 | |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 137 | for (i = 0; i < COMPUTE_MAX; i++) |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 138 | if (!strcmp(cstr, compute_names[i])) { |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 139 | *cp = i; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 140 | return setup_compute_opt(option); |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 141 | } |
| 142 | |
| 143 | pr_err("Failed: '%s' is not computation method " |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 144 | "(use 'delta','ratio' or 'wdiff')\n", str); |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 145 | return -EINVAL; |
| 146 | } |
| 147 | |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 148 | double perf_diff__period_percent(struct hist_entry *he, u64 period) |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 149 | { |
| 150 | u64 total = he->hists->stats.total_period; |
| 151 | return (period * 100.0) / total; |
| 152 | } |
| 153 | |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 154 | double perf_diff__compute_delta(struct hist_entry *he, struct hist_entry *pair) |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 155 | { |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 156 | double new_percent = perf_diff__period_percent(he, he->stat.period); |
| 157 | double old_percent = perf_diff__period_percent(pair, pair->stat.period); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 158 | |
| 159 | he->diff.period_ratio_delta = new_percent - old_percent; |
| 160 | he->diff.computed = true; |
| 161 | return he->diff.period_ratio_delta; |
| 162 | } |
| 163 | |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 164 | double perf_diff__compute_ratio(struct hist_entry *he, struct hist_entry *pair) |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 165 | { |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 166 | double new_period = he->stat.period; |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 167 | double old_period = pair->stat.period; |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 168 | |
| 169 | he->diff.computed = true; |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 170 | he->diff.period_ratio = new_period / old_period; |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 171 | return he->diff.period_ratio; |
| 172 | } |
| 173 | |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 174 | s64 perf_diff__compute_wdiff(struct hist_entry *he, struct hist_entry *pair) |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 175 | { |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 176 | u64 new_period = he->stat.period; |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 177 | u64 old_period = pair->stat.period; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 178 | |
| 179 | he->diff.computed = true; |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 180 | he->diff.wdiff = new_period * compute_wdiff_w2 - |
| 181 | old_period * compute_wdiff_w1; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 182 | |
| 183 | return he->diff.wdiff; |
| 184 | } |
| 185 | |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 186 | static int formula_delta(struct hist_entry *he, struct hist_entry *pair, |
| 187 | char *buf, size_t size) |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 188 | { |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 189 | return scnprintf(buf, size, |
| 190 | "(%" PRIu64 " * 100 / %" PRIu64 ") - " |
| 191 | "(%" PRIu64 " * 100 / %" PRIu64 ")", |
| 192 | he->stat.period, he->hists->stats.total_period, |
| 193 | pair->stat.period, pair->hists->stats.total_period); |
| 194 | } |
| 195 | |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 196 | static int formula_ratio(struct hist_entry *he, struct hist_entry *pair, |
| 197 | char *buf, size_t size) |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 198 | { |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 199 | double new_period = he->stat.period; |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 200 | double old_period = pair->stat.period; |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 201 | |
| 202 | return scnprintf(buf, size, "%.0F / %.0F", new_period, old_period); |
| 203 | } |
| 204 | |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 205 | static int formula_wdiff(struct hist_entry *he, struct hist_entry *pair, |
| 206 | char *buf, size_t size) |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 207 | { |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 208 | u64 new_period = he->stat.period; |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 209 | u64 old_period = pair->stat.period; |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 210 | |
| 211 | return scnprintf(buf, size, |
| 212 | "(%" PRIu64 " * " "%" PRId64 ") - (%" PRIu64 " * " "%" PRId64 ")", |
| 213 | new_period, compute_wdiff_w2, old_period, compute_wdiff_w1); |
| 214 | } |
| 215 | |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 216 | int perf_diff__formula(struct hist_entry *he, struct hist_entry *pair, |
| 217 | char *buf, size_t size) |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 218 | { |
| 219 | switch (compute) { |
| 220 | case COMPUTE_DELTA: |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 221 | return formula_delta(he, pair, buf, size); |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 222 | case COMPUTE_RATIO: |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 223 | return formula_ratio(he, pair, buf, size); |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 224 | case COMPUTE_WEIGHTED_DIFF: |
Jiri Olsa | f4c8bae | 2012-11-28 14:52:41 +0100 | [diff] [blame] | 225 | return formula_wdiff(he, pair, buf, size); |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 226 | default: |
| 227 | BUG_ON(1); |
| 228 | } |
| 229 | |
| 230 | return -1; |
| 231 | } |
| 232 | |
Arnaldo Carvalho de Melo | 1c02c4d | 2010-05-10 13:04:11 -0300 | [diff] [blame] | 233 | static int hists__add_entry(struct hists *self, |
Andi Kleen | 0548429 | 2013-01-24 16:10:29 +0100 | [diff] [blame] | 234 | struct addr_location *al, u64 period, |
| 235 | u64 weight) |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 236 | { |
Andi Kleen | 0548429 | 2013-01-24 16:10:29 +0100 | [diff] [blame] | 237 | if (__hists__add_entry(self, al, NULL, period, weight) != NULL) |
Arnaldo Carvalho de Melo | 28e2a10 | 2010-05-09 13:02:23 -0300 | [diff] [blame] | 238 | return 0; |
| 239 | return -ENOMEM; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 240 | } |
| 241 | |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 242 | static int diff__process_sample_event(struct perf_tool *tool __maybe_unused, |
Arnaldo Carvalho de Melo | d20deb6 | 2011-11-25 08:19:45 -0200 | [diff] [blame] | 243 | union perf_event *event, |
Arnaldo Carvalho de Melo | 8d50e5b | 2011-01-29 13:02:00 -0200 | [diff] [blame] | 244 | struct perf_sample *sample, |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 245 | struct perf_evsel *evsel, |
Arnaldo Carvalho de Melo | 743eb86 | 2011-11-28 07:56:39 -0200 | [diff] [blame] | 246 | struct machine *machine) |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 247 | { |
| 248 | struct addr_location al; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 249 | |
Arnaldo Carvalho de Melo | 743eb86 | 2011-11-28 07:56:39 -0200 | [diff] [blame] | 250 | if (perf_event__preprocess_sample(event, machine, &al, sample, NULL) < 0) { |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 251 | pr_warning("problem processing %d event, skipping it.\n", |
| 252 | event->header.type); |
| 253 | return -1; |
| 254 | } |
| 255 | |
Jiri Olsa | d88c48f | 2012-10-05 16:44:46 +0200 | [diff] [blame] | 256 | if (al.filtered) |
Arnaldo Carvalho de Melo | c410a33 | 2009-12-15 20:04:41 -0200 | [diff] [blame] | 257 | return 0; |
| 258 | |
Andi Kleen | 0548429 | 2013-01-24 16:10:29 +0100 | [diff] [blame] | 259 | if (hists__add_entry(&evsel->hists, &al, sample->period, sample->weight)) { |
Arnaldo Carvalho de Melo | c82ee82 | 2010-05-14 14:19:35 -0300 | [diff] [blame] | 260 | pr_warning("problem incrementing symbol period, skipping event\n"); |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 261 | return -1; |
| 262 | } |
| 263 | |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 264 | evsel->hists.stats.total_period += sample->period; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 265 | return 0; |
| 266 | } |
| 267 | |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 268 | static struct perf_tool tool = { |
| 269 | .sample = diff__process_sample_event, |
| 270 | .mmap = perf_event__process_mmap, |
| 271 | .comm = perf_event__process_comm, |
Arnaldo Carvalho de Melo | f62d3f0 | 2012-10-06 15:44:59 -0300 | [diff] [blame] | 272 | .exit = perf_event__process_exit, |
| 273 | .fork = perf_event__process_fork, |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 274 | .lost = perf_event__process_lost, |
| 275 | .ordered_samples = true, |
| 276 | .ordering_requires_timestamps = true, |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 277 | }; |
| 278 | |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 279 | static struct perf_evsel *evsel_match(struct perf_evsel *evsel, |
| 280 | struct perf_evlist *evlist) |
| 281 | { |
| 282 | struct perf_evsel *e; |
| 283 | |
| 284 | list_for_each_entry(e, &evlist->entries, node) |
| 285 | if (perf_evsel__match2(evsel, e)) |
| 286 | return e; |
| 287 | |
| 288 | return NULL; |
| 289 | } |
| 290 | |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 291 | static void perf_evlist__collapse_resort(struct perf_evlist *evlist) |
Jiri Olsa | dd46434 | 2012-10-04 21:49:36 +0900 | [diff] [blame] | 292 | { |
| 293 | struct perf_evsel *evsel; |
| 294 | |
| 295 | list_for_each_entry(evsel, &evlist->entries, node) { |
| 296 | struct hists *hists = &evsel->hists; |
| 297 | |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 298 | hists__collapse_resort(hists); |
Jiri Olsa | dd46434 | 2012-10-04 21:49:36 +0900 | [diff] [blame] | 299 | } |
| 300 | } |
| 301 | |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 302 | static void hists__baseline_only(struct hists *hists) |
| 303 | { |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 304 | struct rb_root *root; |
| 305 | struct rb_node *next; |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 306 | |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 307 | if (sort__need_collapse) |
| 308 | root = &hists->entries_collapsed; |
| 309 | else |
| 310 | root = hists->entries_in; |
| 311 | |
| 312 | next = rb_first(root); |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 313 | while (next != NULL) { |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 314 | struct hist_entry *he = rb_entry(next, struct hist_entry, rb_node_in); |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 315 | |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 316 | next = rb_next(&he->rb_node_in); |
Arnaldo Carvalho de Melo | b821c73 | 2012-10-25 14:42:45 -0200 | [diff] [blame] | 317 | if (!hist_entry__next_pair(he)) { |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 318 | rb_erase(&he->rb_node_in, root); |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 319 | hist_entry__free(he); |
| 320 | } |
| 321 | } |
| 322 | } |
| 323 | |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 324 | static void hists__precompute(struct hists *hists) |
| 325 | { |
| 326 | struct rb_node *next = rb_first(&hists->entries); |
| 327 | |
| 328 | while (next != NULL) { |
| 329 | struct hist_entry *he = rb_entry(next, struct hist_entry, rb_node); |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 330 | struct hist_entry *pair = hist_entry__next_pair(he); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 331 | |
| 332 | next = rb_next(&he->rb_node); |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 333 | if (!pair) |
| 334 | continue; |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 335 | |
| 336 | switch (compute) { |
| 337 | case COMPUTE_DELTA: |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 338 | perf_diff__compute_delta(he, pair); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 339 | break; |
| 340 | case COMPUTE_RATIO: |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 341 | perf_diff__compute_ratio(he, pair); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 342 | break; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 343 | case COMPUTE_WEIGHTED_DIFF: |
Jiri Olsa | 05472da | 2012-11-28 14:52:40 +0100 | [diff] [blame] | 344 | perf_diff__compute_wdiff(he, pair); |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 345 | break; |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 346 | default: |
| 347 | BUG_ON(1); |
| 348 | } |
| 349 | } |
| 350 | } |
| 351 | |
| 352 | static int64_t cmp_doubles(double l, double r) |
| 353 | { |
| 354 | if (l > r) |
| 355 | return -1; |
| 356 | else if (l < r) |
| 357 | return 1; |
| 358 | else |
| 359 | return 0; |
| 360 | } |
| 361 | |
| 362 | static int64_t |
| 363 | hist_entry__cmp_compute(struct hist_entry *left, struct hist_entry *right, |
| 364 | int c) |
| 365 | { |
| 366 | switch (c) { |
| 367 | case COMPUTE_DELTA: |
| 368 | { |
| 369 | double l = left->diff.period_ratio_delta; |
| 370 | double r = right->diff.period_ratio_delta; |
| 371 | |
| 372 | return cmp_doubles(l, r); |
| 373 | } |
| 374 | case COMPUTE_RATIO: |
| 375 | { |
| 376 | double l = left->diff.period_ratio; |
| 377 | double r = right->diff.period_ratio; |
| 378 | |
| 379 | return cmp_doubles(l, r); |
| 380 | } |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 381 | case COMPUTE_WEIGHTED_DIFF: |
| 382 | { |
| 383 | s64 l = left->diff.wdiff; |
| 384 | s64 r = right->diff.wdiff; |
| 385 | |
| 386 | return r - l; |
| 387 | } |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 388 | default: |
| 389 | BUG_ON(1); |
| 390 | } |
| 391 | |
| 392 | return 0; |
| 393 | } |
| 394 | |
| 395 | static void insert_hist_entry_by_compute(struct rb_root *root, |
| 396 | struct hist_entry *he, |
| 397 | int c) |
| 398 | { |
| 399 | struct rb_node **p = &root->rb_node; |
| 400 | struct rb_node *parent = NULL; |
| 401 | struct hist_entry *iter; |
| 402 | |
| 403 | while (*p != NULL) { |
| 404 | parent = *p; |
| 405 | iter = rb_entry(parent, struct hist_entry, rb_node); |
| 406 | if (hist_entry__cmp_compute(he, iter, c) < 0) |
| 407 | p = &(*p)->rb_left; |
| 408 | else |
| 409 | p = &(*p)->rb_right; |
| 410 | } |
| 411 | |
| 412 | rb_link_node(&he->rb_node, parent, p); |
| 413 | rb_insert_color(&he->rb_node, root); |
| 414 | } |
| 415 | |
| 416 | static void hists__compute_resort(struct hists *hists) |
| 417 | { |
Namhyung Kim | 66f97ed | 2012-12-10 17:29:56 +0900 | [diff] [blame] | 418 | struct rb_root *root; |
| 419 | struct rb_node *next; |
| 420 | |
| 421 | if (sort__need_collapse) |
| 422 | root = &hists->entries_collapsed; |
| 423 | else |
| 424 | root = hists->entries_in; |
| 425 | |
| 426 | hists->entries = RB_ROOT; |
| 427 | next = rb_first(root); |
| 428 | |
| 429 | hists->nr_entries = 0; |
| 430 | hists->stats.total_period = 0; |
| 431 | hists__reset_col_len(hists); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 432 | |
| 433 | while (next != NULL) { |
Namhyung Kim | 66f97ed | 2012-12-10 17:29:56 +0900 | [diff] [blame] | 434 | struct hist_entry *he; |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 435 | |
Namhyung Kim | 66f97ed | 2012-12-10 17:29:56 +0900 | [diff] [blame] | 436 | he = rb_entry(next, struct hist_entry, rb_node_in); |
| 437 | next = rb_next(&he->rb_node_in); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 438 | |
Namhyung Kim | 66f97ed | 2012-12-10 17:29:56 +0900 | [diff] [blame] | 439 | insert_hist_entry_by_compute(&hists->entries, he, compute); |
| 440 | hists__inc_nr_entries(hists, he); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 441 | } |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 442 | } |
| 443 | |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 444 | static void hists__process(struct hists *old, struct hists *new) |
| 445 | { |
Arnaldo Carvalho de Melo | 95529be | 2012-11-08 17:54:33 -0300 | [diff] [blame] | 446 | hists__match(new, old); |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 447 | |
| 448 | if (show_baseline_only) |
| 449 | hists__baseline_only(new); |
Arnaldo Carvalho de Melo | bfaef4b | 2012-11-08 18:08:26 -0300 | [diff] [blame] | 450 | else |
| 451 | hists__link(new, old); |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 452 | |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 453 | if (sort_compute) { |
| 454 | hists__precompute(new); |
| 455 | hists__compute_resort(new); |
Namhyung Kim | 66f97ed | 2012-12-10 17:29:56 +0900 | [diff] [blame] | 456 | } else { |
| 457 | hists__output_resort(new); |
Jiri Olsa | 96c47f1 | 2012-10-05 16:44:42 +0200 | [diff] [blame] | 458 | } |
| 459 | |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 460 | hists__fprintf(new, true, 0, 0, stdout); |
| 461 | } |
| 462 | |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 463 | static int __cmd_diff(void) |
| 464 | { |
| 465 | int ret, i; |
Jiri Olsa | 4bf9ce1 | 2012-03-22 14:37:26 +0100 | [diff] [blame] | 466 | #define older (session[0]) |
| 467 | #define newer (session[1]) |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 468 | struct perf_session *session[2]; |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 469 | struct perf_evlist *evlist_new, *evlist_old; |
| 470 | struct perf_evsel *evsel; |
| 471 | bool first = true; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 472 | |
Jiri Olsa | 4bf9ce1 | 2012-03-22 14:37:26 +0100 | [diff] [blame] | 473 | older = perf_session__new(input_old, O_RDONLY, force, false, |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 474 | &tool); |
Jiri Olsa | 4bf9ce1 | 2012-03-22 14:37:26 +0100 | [diff] [blame] | 475 | newer = perf_session__new(input_new, O_RDONLY, force, false, |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 476 | &tool); |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 477 | if (session[0] == NULL || session[1] == NULL) |
| 478 | return -ENOMEM; |
| 479 | |
| 480 | for (i = 0; i < 2; ++i) { |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 481 | ret = perf_session__process_events(session[i], &tool); |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 482 | if (ret) |
| 483 | goto out_delete; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 484 | } |
| 485 | |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 486 | evlist_old = older->evlist; |
| 487 | evlist_new = newer->evlist; |
Arnaldo Carvalho de Melo | 9c443df | 2009-12-28 22:48:36 -0200 | [diff] [blame] | 488 | |
Namhyung Kim | ce74f60 | 2012-12-10 17:29:55 +0900 | [diff] [blame] | 489 | perf_evlist__collapse_resort(evlist_old); |
| 490 | perf_evlist__collapse_resort(evlist_new); |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 491 | |
| 492 | list_for_each_entry(evsel, &evlist_new->entries, node) { |
| 493 | struct perf_evsel *evsel_old; |
| 494 | |
| 495 | evsel_old = evsel_match(evsel, evlist_old); |
| 496 | if (!evsel_old) |
| 497 | continue; |
| 498 | |
| 499 | fprintf(stdout, "%s# Event '%s'\n#\n", first ? "" : "\n", |
| 500 | perf_evsel__name(evsel)); |
| 501 | |
| 502 | first = false; |
| 503 | |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 504 | hists__process(&evsel_old->hists, &evsel->hists); |
Jiri Olsa | 863e451 | 2012-09-06 17:46:55 +0200 | [diff] [blame] | 505 | } |
| 506 | |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 507 | out_delete: |
| 508 | for (i = 0; i < 2; ++i) |
| 509 | perf_session__delete(session[i]); |
| 510 | return ret; |
Jiri Olsa | 4bf9ce1 | 2012-03-22 14:37:26 +0100 | [diff] [blame] | 511 | #undef older |
| 512 | #undef newer |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 513 | } |
| 514 | |
Arnaldo Carvalho de Melo | 0422a4f | 2009-12-18 16:35:58 -0200 | [diff] [blame] | 515 | static const char * const diff_usage[] = { |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 516 | "perf diff [<options>] [old_file] [new_file]", |
Arnaldo Carvalho de Melo | 0422a4f | 2009-12-18 16:35:58 -0200 | [diff] [blame] | 517 | NULL, |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 518 | }; |
| 519 | |
| 520 | static const struct option options[] = { |
Ian Munsie | c055564 | 2010-04-13 18:37:33 +1000 | [diff] [blame] | 521 | OPT_INCR('v', "verbose", &verbose, |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 522 | "be more verbose (show symbol address, etc)"), |
Jiri Olsa | a06d143 | 2012-10-05 16:44:40 +0200 | [diff] [blame] | 523 | OPT_BOOLEAN('b', "baseline-only", &show_baseline_only, |
| 524 | "Show only items with match in baseline"), |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 525 | OPT_CALLBACK('c', "compute", &compute, |
| 526 | "delta,ratio,wdiff:w1,w2 (default delta)", |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 527 | "Entries differential computation selection", |
| 528 | setup_compute), |
Jiri Olsa | 61949b2 | 2012-10-05 16:44:44 +0200 | [diff] [blame] | 529 | OPT_BOOLEAN('p', "period", &show_period, |
| 530 | "Show period values."), |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 531 | OPT_BOOLEAN('F', "formula", &show_formula, |
| 532 | "Show formula."), |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 533 | OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, |
| 534 | "dump raw trace in ASCII"), |
| 535 | OPT_BOOLEAN('f', "force", &force, "don't complain, do it"), |
| 536 | OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules, |
| 537 | "load module symbols - WARNING: use only with -k and LIVE kernel"), |
Arnaldo Carvalho de Melo | c410a33 | 2009-12-15 20:04:41 -0200 | [diff] [blame] | 538 | OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]", |
| 539 | "only consider symbols in these dsos"), |
| 540 | OPT_STRING('C', "comms", &symbol_conf.comm_list_str, "comm[,comm...]", |
| 541 | "only consider symbols in these comms"), |
| 542 | OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]", |
| 543 | "only consider these symbols"), |
Arnaldo Carvalho de Melo | c351c28 | 2009-12-16 13:49:27 -0200 | [diff] [blame] | 544 | OPT_STRING('s', "sort", &sort_order, "key[,key2...]", |
| 545 | "sort by key(s): pid, comm, dso, symbol, parent"), |
| 546 | OPT_STRING('t', "field-separator", &symbol_conf.field_sep, "separator", |
| 547 | "separator for columns, no spaces will be added between " |
| 548 | "columns '.' is reserved."), |
David Ahern | ec5761e | 2010-12-09 13:27:07 -0700 | [diff] [blame] | 549 | OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory", |
| 550 | "Look for files with symbols relative to this directory"), |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 551 | OPT_END() |
| 552 | }; |
| 553 | |
Jiri Olsa | 1d77822 | 2012-10-04 21:49:39 +0900 | [diff] [blame] | 554 | static void ui_init(void) |
| 555 | { |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 556 | /* |
Jiri Olsa | db6d0bb | 2012-12-06 14:22:28 +0100 | [diff] [blame] | 557 | * Display baseline/delta/ratio |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 558 | * formula/periods columns. |
| 559 | */ |
Jiri Olsa | 1240005 | 2012-10-13 00:06:16 +0200 | [diff] [blame] | 560 | perf_hpp__column_enable(PERF_HPP__BASELINE); |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 561 | |
| 562 | switch (compute) { |
| 563 | case COMPUTE_DELTA: |
Jiri Olsa | 1240005 | 2012-10-13 00:06:16 +0200 | [diff] [blame] | 564 | perf_hpp__column_enable(PERF_HPP__DELTA); |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 565 | break; |
| 566 | case COMPUTE_RATIO: |
Jiri Olsa | 1240005 | 2012-10-13 00:06:16 +0200 | [diff] [blame] | 567 | perf_hpp__column_enable(PERF_HPP__RATIO); |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 568 | break; |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 569 | case COMPUTE_WEIGHTED_DIFF: |
Jiri Olsa | 1240005 | 2012-10-13 00:06:16 +0200 | [diff] [blame] | 570 | perf_hpp__column_enable(PERF_HPP__WEIGHTED_DIFF); |
Jiri Olsa | 81d5f95 | 2012-10-05 16:44:43 +0200 | [diff] [blame] | 571 | break; |
Jiri Olsa | 7aaf6b3 | 2012-10-05 16:44:41 +0200 | [diff] [blame] | 572 | default: |
| 573 | BUG_ON(1); |
| 574 | }; |
Jiri Olsa | 1d77822 | 2012-10-04 21:49:39 +0900 | [diff] [blame] | 575 | |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 576 | if (show_formula) |
Jiri Olsa | 1240005 | 2012-10-13 00:06:16 +0200 | [diff] [blame] | 577 | perf_hpp__column_enable(PERF_HPP__FORMULA); |
Jiri Olsa | ed279da | 2012-10-05 16:44:45 +0200 | [diff] [blame] | 578 | |
Jiri Olsa | 61949b2 | 2012-10-05 16:44:44 +0200 | [diff] [blame] | 579 | if (show_period) { |
Jiri Olsa | 1240005 | 2012-10-13 00:06:16 +0200 | [diff] [blame] | 580 | perf_hpp__column_enable(PERF_HPP__PERIOD); |
| 581 | perf_hpp__column_enable(PERF_HPP__PERIOD_BASELINE); |
Jiri Olsa | 61949b2 | 2012-10-05 16:44:44 +0200 | [diff] [blame] | 582 | } |
Jiri Olsa | 1d77822 | 2012-10-04 21:49:39 +0900 | [diff] [blame] | 583 | } |
| 584 | |
Irina Tirdea | 1d037ca | 2012-09-11 01:15:03 +0300 | [diff] [blame] | 585 | int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused) |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 586 | { |
Arnaldo Carvalho de Melo | 604c5c9 | 2009-12-16 14:09:53 -0200 | [diff] [blame] | 587 | sort_order = diff__default_sort_order; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 588 | argc = parse_options(argc, argv, options, diff_usage, 0); |
| 589 | if (argc) { |
| 590 | if (argc > 2) |
| 591 | usage_with_options(diff_usage, options); |
| 592 | if (argc == 2) { |
| 593 | input_old = argv[0]; |
| 594 | input_new = argv[1]; |
| 595 | } else |
| 596 | input_new = argv[0]; |
Zhang, Yanmin | a1645ce | 2010-04-19 13:32:50 +0800 | [diff] [blame] | 597 | } else if (symbol_conf.default_guest_vmlinux_name || |
| 598 | symbol_conf.default_guest_kallsyms) { |
| 599 | input_old = "perf.data.host"; |
| 600 | input_new = "perf.data.guest"; |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 601 | } |
| 602 | |
Arnaldo Carvalho de Melo | c351c28 | 2009-12-16 13:49:27 -0200 | [diff] [blame] | 603 | symbol_conf.exclude_other = false; |
Arnaldo Carvalho de Melo | 655000e | 2009-12-15 20:04:40 -0200 | [diff] [blame] | 604 | if (symbol__init() < 0) |
| 605 | return -1; |
| 606 | |
Jiri Olsa | 1d77822 | 2012-10-04 21:49:39 +0900 | [diff] [blame] | 607 | ui_init(); |
| 608 | |
Namhyung Kim | 5530998 | 2013-02-06 14:57:16 +0900 | [diff] [blame] | 609 | if (setup_sorting() < 0) |
| 610 | usage_with_options(diff_usage, options); |
| 611 | |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 612 | setup_pager(); |
Arnaldo Carvalho de Melo | c351c28 | 2009-12-16 13:49:27 -0200 | [diff] [blame] | 613 | |
| 614 | sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list, "dso", NULL); |
| 615 | sort_entry__setup_elide(&sort_comm, symbol_conf.comm_list, "comm", NULL); |
| 616 | sort_entry__setup_elide(&sort_sym, symbol_conf.sym_list, "symbol", NULL); |
| 617 | |
Arnaldo Carvalho de Melo | 86a9eee | 2009-12-14 20:09:31 -0200 | [diff] [blame] | 618 | return __cmd_diff(); |
| 619 | } |