commit 013448c59b8a8cf71a5ff89641f78b620671ccb0
author Trond Myklebust <Trond.Myklebust@netapp.com> Tue Jul 17 14:47:30 2012 -0400
committer Trond Myklebust <Trond.Myklebust@netapp.com> Tue Jul 17 17:02:57 2012 -0400
tree 60b6918d120e7ef00da6d650efed1717b9bd9762
parent ec409897e7c71596cc080135ef5f86b81a0e9813

SUNRPC: Add a missing spin_unlock to gss_mech_list_pseudoflavors

The patch "SUNRPC: Add rpcauth_list_flavors()" introduces a new error
path in gss_mech_list_pseudoflavors, but fails to release the spin lock.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

net/sunrpc/auth_gss/gss_mech_switch.c

diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c
index 6ac5dfc..b174fcd 100644
--- a/net/sunrpc/auth_gss/gss_mech_switch.c
+++ b/net/sunrpc/auth_gss/gss_mech_switch.c
@@ -257,8 +257,10 @@
 	spin_lock(&registered_mechs_lock);
 	list_for_each_entry(pos, &registered_mechs, gm_list) {
 		for (j = 0; j < pos->gm_pf_num; j++) {
-			if (i >= size)
+			if (i >= size) {
+				spin_unlock(&registered_mechs_lock);
 				return -ENOMEM;
+			}
 			array_ptr[i++] = pos->gm_pfs[j].pseudoflavor;
 		}
 	}