cgroup: rename cgroup_iter to cgroup_task_iter
cgroup now has multiple iterators and it's quite confusing to have
something which walks over tasks of a single cgroup named cgroup_iter.
Let's rename it to cgroup_task_iter.
While at it, reformat / update comments and replace the overview
comment above the interface function decls with proper function
comments. Such overview can be useful but function comments should be
more than enough here.
This is pure rename and doesn't introduce any functional changes.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Cc: Matt Helsley <matthltc@us.ibm.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Balbir Singh <bsingharora@gmail.com>
diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c
index 98ca48d..c9177f8 100644
--- a/kernel/cgroup_freezer.c
+++ b/kernel/cgroup_freezer.c
@@ -258,7 +258,7 @@
{
struct freezer *freezer = css_freezer(css);
struct cgroup_subsys_state *pos;
- struct cgroup_iter it;
+ struct cgroup_task_iter it;
struct task_struct *task;
WARN_ON_ONCE(!rcu_read_lock_held());
@@ -279,9 +279,9 @@
}
/* are all tasks frozen? */
- cgroup_iter_start(css->cgroup, &it);
+ cgroup_task_iter_start(css->cgroup, &it);
- while ((task = cgroup_iter_next(css->cgroup, &it))) {
+ while ((task = cgroup_task_iter_next(css->cgroup, &it))) {
if (freezing(task)) {
/*
* freezer_should_skip() indicates that the task
@@ -296,7 +296,7 @@
freezer->state |= CGROUP_FROZEN;
out_iter_end:
- cgroup_iter_end(css->cgroup, &it);
+ cgroup_task_iter_end(css->cgroup, &it);
out_unlock:
spin_unlock_irq(&freezer->lock);
}
@@ -323,25 +323,25 @@
static void freeze_cgroup(struct freezer *freezer)
{
struct cgroup *cgroup = freezer->css.cgroup;
- struct cgroup_iter it;
+ struct cgroup_task_iter it;
struct task_struct *task;
- cgroup_iter_start(cgroup, &it);
- while ((task = cgroup_iter_next(cgroup, &it)))
+ cgroup_task_iter_start(cgroup, &it);
+ while ((task = cgroup_task_iter_next(cgroup, &it)))
freeze_task(task);
- cgroup_iter_end(cgroup, &it);
+ cgroup_task_iter_end(cgroup, &it);
}
static void unfreeze_cgroup(struct freezer *freezer)
{
struct cgroup *cgroup = freezer->css.cgroup;
- struct cgroup_iter it;
+ struct cgroup_task_iter it;
struct task_struct *task;
- cgroup_iter_start(cgroup, &it);
- while ((task = cgroup_iter_next(cgroup, &it)))
+ cgroup_task_iter_start(cgroup, &it);
+ while ((task = cgroup_task_iter_next(cgroup, &it)))
__thaw_task(task);
- cgroup_iter_end(cgroup, &it);
+ cgroup_task_iter_end(cgroup, &it);
}
/**