tree 2d9715add7a7bb123bd19c80654dec87af91c445
parent 01acd933d6184a7626f5e0dac1ad0cb794aa74a5
author Dan Carpenter <dan.carpenter@oracle.com> 1495454911 +0300
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> 1541864566 -0800

orangefs: off by ones in xattr size checks

[ Upstream commit 5f13e58767a53ebb54265e03c0c4a67650286263 ]

A previous patch which claimed to remove off by ones actually introduced
them.

strlen() returns the length of the string not including the NUL
character.  We are using strcpy() to copy "name" into a buffer which is
ORANGEFS_MAX_XATTR_NAMELEN characters long.  We should make sure to
leave space for the NUL, otherwise we're writing one character beyond
the end of the buffer.

Fixes: e675c5ec51fe ("orangefs: clean up oversize xattr validation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>