commit 1768514eebfa888563049fa165449a1c1eba92d8
author Mark Brown <broonie@kernel.org> Fri Aug 07 21:19:26 2015 +0100
committer Mark Brown <broonie@kernel.org> Wed Aug 12 11:01:29 2015 +0100
tree e9adcb41b282179be2783258d2cd96b61b600f2e
parent 7cd71c3ba166913a0afb8ac0d6bd5d2730fea6df

regulator: core: Reduce rdev locking region when releasing regulator

When we release a regulator we need to remove references to it from the
rdev which means locking the rdev.  Currently we also free resources
associated with the regulator inside the rdev lock but there is no need
to do this, we can reduce the region the lock is held by restricting it
to just actions that affect the rdev.

Signed-off-by: Mark Brown <broonie@kernel.org>

drivers/regulator/core.c

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 62e4f3b..89be8e2 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1601,14 +1601,15 @@
 	if (regulator->dev)
 		sysfs_remove_link(&rdev->dev.kobj, regulator->supply_name);
 	mutex_lock(&rdev->mutex);
-	kfree(regulator->supply_name);
 	list_del(&regulator->list);
-	kfree(regulator);
 
 	rdev->open_count--;
 	rdev->exclusive = 0;
 	mutex_unlock(&rdev->mutex);
 
+	kfree(regulator->supply_name);
+	kfree(regulator);
+
 	module_put(rdev->owner);
 }