usb: dwc3: Suspend USB SS PHY in host mode with device connect case
Currently driver is not suspending USB Super Speed PHY (here USB QMP
PHY) with below usecases.
a. USB super speed HUB is connected and going into bus suspend
b. USB super speed HUB is connected and having USB super speed device
connected on HUB's downstream port
This results into no USB super speed device connect or removal being
detected as autonomous mode is not being enabled with USB QMP PHY.
Fix these issues by suspending USB SS PHY in host mode with device
connect (i.e. HUB or HUB with USB SS device connected) case.
Change-Id: I469b02f0845228f55d9253e7683ea3c133fd9542
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c
index 69d617f..ecc650e 100644
--- a/drivers/usb/dwc3/dwc3-msm.c
+++ b/drivers/usb/dwc3/dwc3-msm.c
@@ -2141,7 +2141,6 @@
static int dwc3_msm_suspend(struct dwc3_msm *mdwc)
{
int ret;
- bool can_suspend_ssphy;
struct dwc3 *dwc = platform_get_drvdata(mdwc->dwc3);
struct dwc3_event_buffer *evt;
struct usb_irq *uirq;
@@ -2198,10 +2197,6 @@
if (ret)
return ret;
- /* Initialize variables here */
- can_suspend_ssphy = !(mdwc->in_host_mode &&
- dwc3_msm_is_host_superspeed(mdwc));
-
/* Disable core irq */
if (dwc->irq)
disable_irq(dwc->irq);
@@ -2217,7 +2212,7 @@
usb_phy_set_suspend(mdwc->hs_phy, 1);
/* Suspend SS PHY */
- if (dwc->maximum_speed == USB_SPEED_SUPER && can_suspend_ssphy) {
+ if (dwc->maximum_speed == USB_SPEED_SUPER) {
/* indicate phy about SS mode */
if (dwc3_msm_is_superspeed(mdwc))
mdwc->ss_phy->flags |= DEVICE_IN_SS_MODE;