commit 1a34456bbbdaa939ffa567d15a0797c269f901b7
author Eric Sesterhenn <snakebyte@gmx.de> Tue Apr 18 21:09:20 2006 -0700
committer James Bottomley <jejb@mulgrave.il.steeleye.com> Wed Apr 19 20:51:38 2006 -0400
tree 6e9aae933bc008c661aa5de29d17862d59037bce
parent 36ab26185c0b6060203829bce32eaeab0fa781ae

[SCSI] Overrun in drivers/scsi/sim710.c

This fixes coverity bug id #480.  Since id_array is declared as
id_array[MAX_SLOTS], the check for i>MAX_SLOTS is obviously false.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

drivers/scsi/sim710.c

diff --git a/drivers/scsi/sim710.c b/drivers/scsi/sim710.c
index 3274ab7..255886a 100644
--- a/drivers/scsi/sim710.c
+++ b/drivers/scsi/sim710.c
@@ -75,7 +75,7 @@
 		else if(!strncmp(pos, "id:", 3)) {
 			if(slot == -1) {
 				printk(KERN_WARNING "sim710: Must specify slot for id parameter\n");
-			} else if(slot > MAX_SLOTS) {
+			} else if(slot >= MAX_SLOTS) {
 				printk(KERN_WARNING "sim710: Illegal slot %d for id %d\n", slot, val);
 			} else {
 				id_array[slot] = val;