msm: kgsl: Fix NULL pointer dereference
Before dereferencing the register base, check
if it has been initialized or not. This saves us
a device failure during gmu snapshot that occurs
before the register base is initialized.
Change-Id: I5402a82b0549b219f75f9268724f7a114aaeddf0
Signed-off-by: Harshdeep Dhatt <hdhatt@codeaurora.org>
Signed-off-by: Sunil Khatri <sunilkh@codeaurora.org>
diff --git a/drivers/gpu/msm/kgsl_iommu.c b/drivers/gpu/msm/kgsl_iommu.c
index 4cf6250..87e1431 100644
--- a/drivers/gpu/msm/kgsl_iommu.c
+++ b/drivers/gpu/msm/kgsl_iommu.c
@@ -2050,6 +2050,8 @@
{
u64 val;
struct kgsl_iommu *iommu = _IOMMU_PRIV(mmu);
+ struct kgsl_iommu_context *ctx = &iommu->ctx[KGSL_IOMMU_CONTEXT_USER];
+
/*
* We cannot enable or disable the clocks in interrupt context, this
* function is called from interrupt context if there is an axi error
@@ -2057,9 +2059,11 @@
if (in_interrupt())
return 0;
+ if (ctx->regbase == NULL)
+ return 0;
+
kgsl_iommu_enable_clk(mmu);
- val = KGSL_IOMMU_GET_CTX_REG_Q(&iommu->ctx[KGSL_IOMMU_CONTEXT_USER],
- TTBR0);
+ val = KGSL_IOMMU_GET_CTX_REG_Q(ctx, TTBR0);
kgsl_iommu_disable_clk(mmu);
return val;
}