commit 1efddcc981c95e62c4e305fd462e3e98b6f9c5cd
author Julia Lawall <julia@diku.dk> Wed May 26 17:59:27 2010 +0200
committer Takashi Iwai <tiwai@suse.de> Thu May 27 09:47:02 2010 +0200
tree 9b2bea6600a1bf6c6a11aeca4ec001a793dc5dcc
parent 4daf7a0c0b3dd3c2e2ec829ecee8608d04d67773

sound: Add missing spin_unlock

Add a spin_unlock missing on the error path.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E1;
@@

* spin_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* spin_unlock(E1,...);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/mips/au1x00.c

diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c
index 3e763d6..446cf97 100644
--- a/sound/mips/au1x00.c
+++ b/sound/mips/au1x00.c
@@ -516,6 +516,7 @@
 			break;
 	if (i == 0x5000) {
 		printk(KERN_ERR "au1000 AC97: AC97 command read timeout\n");
+		spin_unlock(&au1000->ac97_lock);
 		return 0;
 	}