tree e5ee691635cd126cc8e17b8b4ece11d1eec1f1ec
parent e029b8379ed64f5beaddbf53c87873246df300ff
author Kees Cook <keescook@chromium.org> 1494023423 -0700
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> 1542788758 +0100

bna: ethtool: Avoid reading past end of buffer

[ Upstream commit 4dc69c1c1fff2f587f8e737e70b4a4e7565a5c94 ]

Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>