EDAC, xgene: Fix cpuid abuse
The new x-gene EDAC driver incorrectly tried to figure out the version
of one of its IP blocks by looking at the version of the CPU core, which
is only vagely related.
This removes the incorrect code and instead uses the version of the IP
block in the compatible string where it belongs.
Found using build testing on x86, which does not provide the arm64
cpuid interface.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[ Changed subnode to "apm,xgene-edac-pmd-v2", adjusted check. ]
Signed-off-by: Loc Ho <lho@apm.com>
Cc: devicetree@vger.kernel.org
Cc: dougthompson@xmission.com
Cc: ijc+devicetree@hellion.org.uk
Cc: jcm@redhat.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: mark.rutland@arm.com
Cc: mchehab@osg.samsung.com
Cc: patches@apm.com
Cc: robh+dt@kernel.org
Link: http://lkml.kernel.org/r/3195065.IK73o60xya@wuerfel
Signed-off-by: Borislav Petkov <bp@suse.de>
diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
index b515857..14636e4 100644
--- a/drivers/edac/xgene_edac.c
+++ b/drivers/edac/xgene_edac.c
@@ -523,6 +523,7 @@
struct edac_device_ctl_info *edac_dev;
void __iomem *pmd_csr;
u32 pmd;
+ int version;
};
static void xgene_edac_pmd_l1_check(struct edac_device_ctl_info *edac_dev,
@@ -784,50 +785,6 @@
writel(0x00000101, pg_f + MEMERR_CPU_MMUECR_PAGE_OFFSET);
}
-static bool xgene_edac_pmd_l2c_version1(void)
-{
- /* Check all chips with PMD L2C version 1 HW */
- #define REVIDR_MINOR_REV(revidr) ((revidr) & 0x00000007)
-
- switch (MIDR_VARIANT(read_cpuid_id())) {
- case 0:
- switch (MIDR_REVISION(read_cpuid_id())) {
- case 0:
-
- switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) {
- case 1:
- case 2:
- return true;
- };
- break;
- case 1:
- if (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1)) == 1)
- return true;
- break;
- }
- break;
- case 1:
- switch (MIDR_REVISION(read_cpuid_id())) {
- case 0:
- switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) {
- case 1:
- return true;
- };
- break;
- case 1:
- switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) {
- case 1:
- case 0:
- return true;
- };
- break;
- }
- break;
- }
-
- return false;
-}
-
static void xgene_edac_pmd_hw_cfg(struct edac_device_ctl_info *edac_dev)
{
struct xgene_edac_pmd_ctx *ctx = edac_dev->pvt_info;
@@ -837,7 +794,7 @@
/* Enable PMD memory error - MEMERR_L2C_L2ECR and L2C_L2RTOCR */
writel(0x00000703, pg_e + MEMERR_L2C_L2ECR_PAGE_OFFSET);
/* Configure L2C HW request time out feature if supported */
- if (!xgene_edac_pmd_l2c_version1())
+ if (ctx->version > 1)
writel(0x00000119, pg_d + CPUX_L2C_L2RTOCR_PAGE_OFFSET);
}
@@ -956,7 +913,8 @@
return (efuse & (1 << pmd)) ? 0 : 1;
}
-static int xgene_edac_pmd_add(struct xgene_edac *edac, struct device_node *np)
+static int xgene_edac_pmd_add(struct xgene_edac *edac, struct device_node *np,
+ int version)
{
struct edac_device_ctl_info *edac_dev;
struct xgene_edac_pmd_ctx *ctx;
@@ -998,6 +956,7 @@
ctx->edac = edac;
ctx->edac_dev = edac_dev;
ctx->ddev = *edac->dev;
+ ctx->version = version;
edac_dev->dev = &ctx->ddev;
edac_dev->ctl_name = ctx->name;
edac_dev->dev_name = ctx->name;
@@ -1169,7 +1128,9 @@
if (of_device_is_compatible(child, "apm,xgene-edac-mc"))
xgene_edac_mc_add(edac, child);
if (of_device_is_compatible(child, "apm,xgene-edac-pmd"))
- xgene_edac_pmd_add(edac, child);
+ xgene_edac_pmd_add(edac, child, 1);
+ if (of_device_is_compatible(child, "apm,xgene-edac-pmd-v2"))
+ xgene_edac_pmd_add(edac, child, 2);
}
return 0;