commit 55c95e738da85373965cb03b4f975d0fd559865b
author Rami Rosen <ramirose@gmail.com> Thu Jun 03 05:02:29 2010 +0000
committer David S. Miller <davem@davemloft.net> Sat Jun 05 02:23:15 2010 -0700
tree dc3fe475c410606c2ce9cb43fcd204fcec805975
parent 5918e2fb9035b35164002c3a268feaf70b7c04d5

fix return value of __pppoe_xmit() method.

Hi,
 __pppoe_xmit() in drivers/net/pppoe always returns 1.
When the methods fails (via goto abort), it should return 0 and not 1.

Regards,
Rami Rosen

Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/pppoe.c

diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index 805b64d..7ebb8e8 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -949,7 +949,7 @@
 
 abort:
 	kfree_skb(skb);
-	return 1;
+	return 0;
 }
 
 /************************************************************************