tree ea855e0fb1a90c59f4555796c818c77dd636c805
parent 1b573631d1a5b541fb1ef4b9c6443d7cd6f1e1ad
author Will McVicker <willmcvicker@google.com> 1607129328 +0000
committer Luca Weiss <luca.weiss@fairphone.com> 1626347892 +0200

HID: make arrays usage and value to be the same

commit ed9be64eefe26d7d8b0b5b9fa3ffdf425d87a01f upstream.

The HID subsystem allows an "HID report field" to have a different
number of "values" and "usages" when it is allocated. When a field
struct is created, the size of the usage array is guaranteed to be at
least as large as the values array, but it may be larger. This leads to
a potential out-of-bounds write in
__hidinput_change_resolution_multipliers() and an out-of-bounds read in
hidinput_count_leds().

To fix this, let's make sure that both the usage and value arrays are
the same size.

Cc: stable@vger.kernel.org
Signed-off-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit b12d39309ecf08cdcab716a5063f9ec23cb9f001)