commit 5d1618ee8fea3c419d4fe1f5ed197016ee717e07
author Dan Carpenter <dan.carpenter@oracle.com> Mon Jan 14 13:49:46 2019 +0300
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> Wed Jan 29 10:24:11 2020 +0100
tree b4b914c18f8c6c2d598ab1fcf8ea466ddab66629
parent 2f1ba897ed0f4b9b124ab2afa220162a98257436

drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()

[ Upstream commit f8261c376e7f8cb9024af5a6c54be540c7f9108e ]

The etnaviv_gem_get_pages() never returns NULL.  It returns error
pointers on error.

Fixes: a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

drivers/gpu/drm/etnaviv/etnaviv_dump.c

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
index 2bef501..5af7c25 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
@@ -206,7 +206,7 @@
 		mutex_lock(&obj->lock);
 		pages = etnaviv_gem_get_pages(obj);
 		mutex_unlock(&obj->lock);
-		if (pages) {
+		if (!IS_ERR(pages)) {
 			int j;
 
 			iter.hdr->data[0] = bomap - bomap_start;