tree 0be9729efe33be16bb12ccb289ec5992c450fcd9
parent 6b37faa175311128dc920aaa57a5f7fab85537d7
author Steve French <sfrench@us.ibm.com> 1223404972 +0000
committer Steve French <sfrench@us.ibm.com> 1223404972 +0000

[CIFS]  clean up error handling in cifs_unlink

Currently, if a standard delete fails and we end up getting -EACCES
we try to clear ATTR_READONLY and try the delete again. If that
then fails with -ETXTBSY then we try a rename_pending_delete. We
aren't handling other errors appropriately though.

Another client could have deleted the file in the meantime and
we get back -ENOENT, for instance. In that case we wouldn't do a
d_drop. Instead of retrying in a separate call, simply goto the
original call and use the error handling from that.

Also, we weren't properly undoing any attribute changes that
were done before returning an error back to the caller.

CC: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>