| commit | 60e5c1b5ecd99e06d3133a2a20d58d3c2b9968ac | [log] [tgz] |
|---|---|---|
| author | Julia Lawall <julia@diku.dk> | Sat Oct 17 08:42:49 2009 +0200 |
| committer | Ben Dooks <ben-linux@fluff.org> | Wed Oct 28 18:25:57 2009 +0000 |
| tree | 84a2faad185d03646999895ed4d074c7ada03fd7 | |
| parent | d3bf3956c75b38def079fb6db40b5cf3f1466a93 [diff] |
ARM: S3C24XX: arch/arm/plat-s3c24xx: Move dereference after NULL test If the NULL test on buf is needed, then the dereference should be after the NULL test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // <smpl> @match exists@ expression x, E; identifier fld; @@ * x->fld ... when != \(x = E\|&x\) * x == NULL // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Ben Dooks <ben-linux@fluff.org>