greybus: FIXME/XXX removals: We have proper reference counting now
Now that we have proper reference counting for modules, interfaces, and
connections, no need to worry about grabbing a pointer to your "parent"
structure, all is good.
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
diff --git a/drivers/staging/greybus/battery-gb.c b/drivers/staging/greybus/battery-gb.c
index 592b68d..185fa2c 100644
--- a/drivers/staging/greybus/battery-gb.c
+++ b/drivers/staging/greybus/battery-gb.c
@@ -369,7 +369,7 @@
if (!gb)
return -ENOMEM;
- gb->connection = connection; // FIXME refcount!
+ gb->connection = connection;
connection->private = gb;
/* Check the version */
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 2d3421f..722bee4 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -179,7 +179,7 @@
return NULL;
}
- connection->interface = interface; /* XXX refcount? */
+ connection->interface = interface;
connection->interface_cport_id = cport_id;
connection->protocol = protocol;
connection->state = GB_CONNECTION_STATE_DISABLED;
diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c
index a7375a2..163cdc4 100644
--- a/drivers/staging/greybus/interface.c
+++ b/drivers/staging/greybus/interface.c
@@ -61,7 +61,7 @@
if (!interface)
return NULL;
- interface->gmod = gmod; /* XXX refcount? */
+ interface->gmod = gmod;
interface->id = interface_id;
interface->device_id = 0xff; /* Invalid device id to start with */
INIT_LIST_HEAD(&interface->connections);
diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c
index 9b889b1..df3a502 100644
--- a/drivers/staging/greybus/operation.c
+++ b/drivers/staging/greybus/operation.c
@@ -349,7 +349,7 @@
operation = kmem_cache_zalloc(gb_operation_cache, gfp_flags);
if (!operation)
return NULL;
- operation->connection = connection; /* XXX refcount? */
+ operation->connection = connection;
operation->request = gb_operation_gbuf_create(operation, type,
request_size,