tree 250856471e985b57ccdc216ecd5c6f1ba9352679
parent 8f507ef522d55a6e2f9e11a1c1163a92756da044
author Jiri Kosina <jkosina@suse.cz> 1409813766 +0200
committer Jiri Kosina <jkosina@suse.cz> 1409813766 +0200

HID: thingm: fix workqueue race on remove

thingm_remove_rgb() needs to flush the workqueue after all the LED classes
have been unregistered, otherwise the removal might race with another LED
event coming, causing thingm_led_set() to schedule additional work after
thingm_remove_rgb() has flushed it. This obviously causes oops later, as
the scheduled work has been freed in the meantime.

In addition to that, move the hid_hw_stop() to an earlier place, so that
dmesg is not polluted by failure messages about not being able to write
the LED while the device is being shut down.

Reported-and-tested-by: Dylan Alex Simon <dylan-kernel@dylex.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>